sunnysideup / silverstripe-ecommerce_stockcontrol

code/model/BuyableStockOrderEntry.php

<?php
/**
 *@author: Nicolaas [at] Sunny Side Up . Co . Nz
 *@description:
 * keeps a record of the quantity deduction made for each sale.  That is, if we sell 10 widgets in an order then an entry is made in this dataclass for
 * a reduction of ten widgets in the available quantity
 *
 **/

class BuyableStockOrderEntry extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        "Quantity" => "Int",
        "IncludeInCurrentCalculation" => "Boolean"
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        "Parent" => "BuyableStockCalculatedQuantity",
        "Order" => "Order",
    );

    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        "IncludeInCurrentCalculation" => 1
    );


    //MODEL ADMIN STUFF
    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        "Quantity",
        "IncludeInCurrentCalculation",
        "ParentID",
        "OrderID",
    );

    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        "Quantity" => "Calculated Quantity On Hand",
        "IncludeInCurrentCalculation" => "Include in Calculation",
        "ParentID" => "Buyable Calculation",
        "OrderID" => "Order"
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        "OrderID",
        "ParentID",
        "Quantity"
    );


    private static $default_sort = [

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

        'LastEdited' => 'DESC',
        'ParentID' => 'ASC',
        'ID' => 'DESC'
    ];

    private static $indexes = [

Consider using a different property name as you override a private property of the parent class.

The property $indexes is not used and could be removed.

        'LastEdited' => true
    ];

    private static $singular_name = "Stock Sale Entry";

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t("BuyableStockOrderEntry.STOCKSALEENTRY", "Stock Sale Entry");
    }

    private static $plural_name = "Stock Sale Entries";

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t("BuyableStockOrderEntry.STOCKSALEENTRIES", "Stock Sale Entries");
    }

    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    public function canView($member = null)
    {
        return $this->canDoAnything();
    }

    protected function canDoAnything()

This method seems to be duplicated in your project.

    {
        EcommerceConfig::get("EcommerceRole", "admin_permission_code");
        if (!Permission::check("ADMIN") && !Permission::check($shopAdminCode)) {

The variable $shopAdminCode does not exist. Did you forget to declare it?

            Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));

$this is of type this<BuyableStockOrderEntry>, but the function expects a object<Controller>|null.

        }
        return true;
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->ID) {
            //basic checks
            if (!$this->ParentID) {

The property ParentID does not exist on object<BuyableStockOrderEntry>. Since you implemented __get, maybe consider adding a @property annotation.

                $this->delete();
                user_error("Can not create record without associated buyable.", E_USER_ERROR);
            }
            if (!$this->OrderID) {

The property OrderID does not exist on object<BuyableStockOrderEntry>. Since you implemented __get, maybe consider adding a @property annotation.

                $this->delete();
                user_error("Can not create record without order.", E_USER_ERROR);
            }
            //make sure no duplicates are created
            $toBeDeleted = BuyableStockOrderEntry::get()
                                            ->filter(array('OrderID' => $this->OrderID, 'ParentID' => $this->ParentID))

The property OrderID does not exist on object<BuyableStockOrderEntry>. Since you implemented __get, maybe consider adding a @property annotation.

The property ParentID does not exist on object<BuyableStockOrderEntry>. Since you implemented __get, maybe consider adding a @property annotation.

                                            ->exclude(array("ID"=> $this->ID))
                                            ->sort(array('LastEdited' => 'ASC'));
            foreach ($toBeDeleted as $youAreDodo) {
                $youAreDodo->delete();
                $youAreDodo->destroy();
                user_error("deleting BuyableStockOrderEntry because there are multiples!", E_USER_ERROR);
            }
        }
    }
}