sunnysideup / silverstripe-ecommerce_stockcontrol

code/model/BuyableStockManualUpdate.php

<?php
/**
 *@author: Nicolaas [at] Sunny Side Up . Co . Nz
 *@description: manual change for a buyable
 * the buyable available quantity can be changed (manually overridden) using this class.
 *
 * All entries link to the BuyableStockCalculatedQuantity object.
 * The BuyableStockCalculatedQuantity objects calculates, for each buyable,
 * how many are available.
 *
 **/

class BuyableStockManualUpdate extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        "Quantity" => "Int",
        "ExternalUpdate" => "Boolean"
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        "Parent" => "BuyableStockCalculatedQuantity",
        "Member" => "Member"
    );

    //MODEL ADMIN STUFF

    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        "Quantity",
        "MemberID"
    );

    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        "Quantity",
        "ParentID"  => "Buyable",
        "MemberID"  => "Updated by ..."
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        "Parent.Name" => "Buyable",
        "Member.FirstName" => "Updater",
        "Quantity" => "Quantity"
    );

    private static $api_access = true;

Consider using a different property name as you override a private property of the parent class.

The property $api_access is not used and could be removed.

    private static $indexes = [
        'LastEdited' =>  true
    ];

    private static $default_sort = [
        'LastEdited' =>  'DESC',
        'ParentID' => 'ASC',
        'ID' => 'DESC'
    ];

    private static $singular_name = "Stock Manual Update Entry";

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t("BuyableStockManualUpdate.STOCKUPDATEENTRY", "Stock Manual Update Entry");
    }

    private static $plural_name = "Stock Manual Update Entries";

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t("BuyableStockManualUpdate.STOCKUPDATEENTRIES", "Stock Manual Update Entries");
    }

    public function canView($member = null)
    {
        return $this->canDoAnything($member);
    }

    public function canCreate($member = null)
    {
        return $this->canDoAnything($member);
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    protected function canDoAnything($member = null)

The parameter $member is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
        if (!Permission::check($shopAdminCode)) {
            Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));

$this is of type this<BuyableStockManualUpdate>, but the function expects a object<Controller>|null.

        }
        return true;
    }
}