StockControlController::StockProductObjects() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_stockcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7c5b8...080abf )

by Nicolaas

created 2017-07-23 06:03 UTC

StockControlController::StockProductObjects() B

↳ Parent: StockControlController

Complexity

Conditions	5
Paths	5

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	12
nc	5
nop	0

<?php
/**
 * @author Nicolaas [at] sunnysideup.co.nz
 * @package: ecommerce
 * @sub-package: ecommerce_stockcontrol
 * @description:
 *  This is the central management page for organising stock control
 *  You will need to "turn on" the MinMaxModifier and add MinMaxModifier::set_use_stock_quantities(true)
 *  to get this page working.
 *
 *
 **/




class StockControlController extends ContentController
namespace YourVendor;

class YourClass { }
{
    private static $allowed_actions = array(

        "update" => "SHOPADMIN",
        "history" => "SHOPADMIN"
    );

    public function init()
    {
        // Only administrators can run this method
        $shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
        if (!Permission::check("ADMIN") && !Permission::check($shopAdminCode)) {
            Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
        }
        parent::init();

        Requirements::themedCSS("StockControlPage", 'ecommerce_stockcontrol');
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

        //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

        Requirements::javascript("ecommerce_stockcontrol/javascript/StockControlPage.js");
        $url = Director::absoluteURL($this->Link()."update/");
        Requirements::customScript("StockControlPage.set_url('".$url."');", "StockControlPage.set_url");
    }

    public function Link($action = null)
    {
        $link =  "/update-stock/";
        if ($action) {
            $link .=  $action ."/";
        }
        return $link;
    }

    public function StockProductObjects()
    {
        $buyableStockCalculatedQuantities = BuyableStockCalculatedQuantity::get()->limit(1000);
        if ($buyableStockCalculatedQuantities->count()) {
            foreach ($buyableStockCalculatedQuantities as $buyableStockCalculatedQuantity) {
                $buyable = $buyableStockCalculatedQuantity->Buyable();
                if ($buyable) {
                    if ($buyable->UnlimitedStock) {
                        $buyableStockCalculatedQuantities->remove($buyableStockCalculatedQuantity);
                    } else {
                        $buyableStockCalculatedQuantity->calculatedBaseQuantity();
                    }
                } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                    //user_error("Buyable can not be found!", E_USER_NOTICE);

                }
            }
            return $buyableStockCalculatedQuantities;
        }
    }

    public function update($request = null)
    {
        $id = intval($request->param("ID"));
        $newValue = intval($request->param("OtherID"));
        if ($newValue || $newValue === 0) {
            $obj = BuyableStockCalculatedQuantity::get()->byID($id);
            if ($obj) {
                if ($buyable = $obj->getBuyable()) {
                    $buyable->setActualQuantity($newValue);
                    $msg = "<em>".$obj->Name . "</em> quantity updated to <strong>".$newValue."</strong>";
                    return $this->customise(array("Message" => $msg))->renderWith("UpdateStockQuantity");
                } else {
                    user_error("Could not create Calculation object", E_USER_NOTICE);
                }
            } else {
                user_error("could not find record: $id ", E_USER_NOTICE);
            }
        } else {
            user_error("new quantity specified is unknown", E_USER_NOTICE);
        }
    }

    public function history($request = null)
    {
        $id = intval($request->param("ID"));
        $buyableStockCalculatedQuantity = BuyableStockCalculatedQuantity::get()->byID($id);
        if ($buyableStockCalculatedQuantity) {
            $buyableStockCalculatedQuantity->ManualUpdates = BuyableStockManualUpdate::get()->filter(array('ParentID' => $buyableStockCalculatedQuantity->ID));
            $buyableStockCalculatedQuantity->OrderEntries = BuyableStockOrderEntry::get()->filter(array('ParentID' => $buyableStockCalculatedQuantity->ID));
            $graphArray = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            if ($buyableStockCalculatedQuantity->ManualUpdates) {
                foreach ($buyableStockCalculatedQuantity->ManualUpdates as $obj) {

                }
            }
            if ($buyableStockCalculatedQuantity->OrderEntries) {
                foreach ($buyableStockCalculatedQuantity->OrderEntries as $obj) {

                }
            }
            return $this->customise($buyableStockCalculatedQuantity)->renderWith("AjaxStockControlPageHistory");
        } else {
            return " could not find historical data";
        }
    }
}


1			<?php
2			/**
3			* @author Nicolaas [at] sunnysideup.co.nz
4			* @package: ecommerce
5			* @sub-package: ecommerce_stockcontrol
6			* @description:
7			* This is the central management page for organising stock control
8			* You will need to "turn on" the MinMaxModifier and add MinMaxModifier::set_use_stock_quantities(true)
9			* to get this page working.
10			*
11			*
12			**/
13
14
15
16
17			class StockControlController extends ContentController
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
18			{
19			private static $allowed_actions = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			"update" => "SHOPADMIN",
21			"history" => "SHOPADMIN"
22			);
23
24			public function init()
25			{
26			// Only administrators can run this method
27			$shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
28			if (!Permission::check("ADMIN") && !Permission::check($shopAdminCode)) {
29			Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
30			}
31			parent::init();
32
33			Requirements::themedCSS("StockControlPage", 'ecommerce_stockcontrol');
34			Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
35			//Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36			//Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
37			Requirements::javascript("ecommerce_stockcontrol/javascript/StockControlPage.js");
38			$url = Director::absoluteURL($this->Link()."update/");
39			Requirements::customScript("StockControlPage.set_url('".$url."');", "StockControlPage.set_url");
40			}
41
42			public function Link($action = null)
43			{
44			$link = "/update-stock/";
45			if ($action) {
46			$link .= $action ."/";
47			}
48			return $link;
49			}
50
51			public function StockProductObjects()
52			{
53			$buyableStockCalculatedQuantities = BuyableStockCalculatedQuantity::get()->limit(1000);
54			if ($buyableStockCalculatedQuantities->count()) {
55			foreach ($buyableStockCalculatedQuantities as $buyableStockCalculatedQuantity) {
56			$buyable = $buyableStockCalculatedQuantity->Buyable();
57			if ($buyable) {
58			if ($buyable->UnlimitedStock) {
59			$buyableStockCalculatedQuantities->remove($buyableStockCalculatedQuantity);
60			} else {
61			$buyableStockCalculatedQuantity->calculatedBaseQuantity();
62			}
63			} else {
			0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report This `else` statement is empty and can be removed. This check looks for the `else` branches of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `else` branches can be removed. if (rand(1, 6) > 3) { print "Check failed"; } else { //print "Check succeeded"; } could be turned into if (rand(1, 6) > 3) { print "Check failed"; } This is much more concise to read. Loading history...
64			//user_error("Buyable can not be found!", E_USER_NOTICE);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
65			}
66			}
67			return $buyableStockCalculatedQuantities;
68			}
69			}
70
71			public function update($request = null)
72			{
73			$id = intval($request->param("ID"));
74			$newValue = intval($request->param("OtherID"));
75			if ($newValue \|\| $newValue === 0) {
76			$obj = BuyableStockCalculatedQuantity::get()->byID($id);
77			if ($obj) {
78			if ($buyable = $obj->getBuyable()) {
79			$buyable->setActualQuantity($newValue);
80			$msg = "<em>".$obj->Name . "</em> quantity updated to <strong>".$newValue."</strong>";
81			return $this->customise(array("Message" => $msg))->renderWith("UpdateStockQuantity");
82			} else {
83			user_error("Could not create Calculation object", E_USER_NOTICE);
84			}
85			} else {
86			user_error("could not find record: $id ", E_USER_NOTICE);
87			}
88			} else {
89			user_error("new quantity specified is unknown", E_USER_NOTICE);
90			}
91			}
92
93			public function history($request = null)
94			{
95			$id = intval($request->param("ID"));
96			$buyableStockCalculatedQuantity = BuyableStockCalculatedQuantity::get()->byID($id);
97			if ($buyableStockCalculatedQuantity) {
98			$buyableStockCalculatedQuantity->ManualUpdates = BuyableStockManualUpdate::get()->filter(array('ParentID' => $buyableStockCalculatedQuantity->ID));
99			$buyableStockCalculatedQuantity->OrderEntries = BuyableStockOrderEntry::get()->filter(array('ParentID' => $buyableStockCalculatedQuantity->ID));
100			$graphArray = array();
			0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report `$graphArray` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
101			if ($buyableStockCalculatedQuantity->ManualUpdates) {
102			foreach ($buyableStockCalculatedQuantity->ManualUpdates as $obj) {
			0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report This `foreach` statement is empty and can be removed. This check looks for `foreach` loops that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. Consider removing the loop. Loading history...
103			}
104			}
105			if ($buyableStockCalculatedQuantity->OrderEntries) {
106			foreach ($buyableStockCalculatedQuantity->OrderEntries as $obj) {
			0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report This `foreach` statement is empty and can be removed. This check looks for `foreach` loops that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. Consider removing the loop. Loading history...
107			}
108			}
109			return $this->customise($buyableStockCalculatedQuantity)->renderWith("AjaxStockControlPageHistory");
110			} else {
111			return " could not find historical data";
112			}
113			}
114			}
115

sunnysideup / silverstripe-ecommerce_stockcontrol

Push — master ( b7c5b8...080abf )

StockControlController::StockProductObjects() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like