BuyableStockManualUpdate::i18n_plural_name() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_stockcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b7c5b8...080abf )

by Nicolaas

created 2017-07-23 06:03 UTC

BuyableStockManualUpdate::i18n_plural_name() A

↳ Parent: BuyableStockManualUpdate

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 *@author: Nicolaas [at] Sunny Side Up . Co . Nz
 *@description: manual change for a buyable
 * the buyable available quantity can be changed (manually overridden) using this class.
 *
 * All entries link to the BuyableStockCalculatedQuantity object.
 * The BuyableStockCalculatedQuantity objects calculates, for each buyable,
 * how many are available.
 *
 **/

class BuyableStockManualUpdate extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "Quantity" => "Int",
        "ExternalUpdate" => "Boolean"
    );

    private static $has_one = array(

        "Parent" => "BuyableStockCalculatedQuantity",
        "Member" => "Member"
    );

    //MODEL ADMIN STUFF

    private static $searchable_fields = array(

        "Quantity",
        "MemberID"
    );

    private static $field_labels = array(

        "Quantity",
        "ParentID"  => "Buyable",
        "MemberID"  => "Updated by ..."
    );

    private static $summary_fields = array(

        "Parent.Name" => "Buyable",
        "Member.FirstName" => "Updater",
        "Quantity" => "Quantity"
    );

    private static $api_access = true;


    private static $default_sort = "\"LastEdited\" DESC, \"ParentID\" ASC";


    private static $singular_name = "Stock Manual Update Entry";

    public function i18n_singular_name()
    {
        return _t("BuyableStockManualUpdate.STOCKUPDATEENTRY", "Stock Manual Update Entry");
    }

    private static $plural_name = "Stock Manual Update Entries";

    public function i18n_plural_name()
    {
        return _t("BuyableStockManualUpdate.STOCKUPDATEENTRIES", "Stock Manual Update Entries");
    }

    public function canView($member = null)
    {
        return $this->canDoAnything($member);
    }

    public function canCreate($member = null)
    {
        return $this->canDoAnything($member);
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    protected function canDoAnything($member = null)

    {
        $shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
        if (!Permission::check($shopAdminCode)) {
            Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return true;
    }
}


1		<?php
2		/**
3		*@author: Nicolaas [at] Sunny Side Up . Co . Nz
4		*@description: manual change for a buyable
5		* the buyable available quantity can be changed (manually overridden) using this class.
6		*
7		* All entries link to the BuyableStockCalculatedQuantity object.
8		* The BuyableStockCalculatedQuantity objects calculates, for each buyable,
9		* how many are available.
10		*
11		**/
12
13		class BuyableStockManualUpdate extends DataObject
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
14		{
15		private static $db = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16		"Quantity" => "Int",
17		"ExternalUpdate" => "Boolean"
18		);
19
20		private static $has_one = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21		"Parent" => "BuyableStockCalculatedQuantity",
22		"Member" => "Member"
23		);
24
25		//MODEL ADMIN STUFF
26
27		private static $searchable_fields = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28		"Quantity",
29		"MemberID"
30		);
31
32		private static $field_labels = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33		"Quantity",
34		"ParentID" => "Buyable",
35		"MemberID" => "Updated by ..."
36		);
37
38		private static $summary_fields = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
39		"Parent.Name" => "Buyable",
40		"Member.FirstName" => "Updater",
41		"Quantity" => "Quantity"
42		);
43
44		private static $api_access = true;
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$api_access` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
45
46		private static $default_sort = "\"LastEdited\" DESC, \"ParentID\" ASC";
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
47
48		private static $singular_name = "Stock Manual Update Entry";
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
49		public function i18n_singular_name()
50		{
51		return _t("BuyableStockManualUpdate.STOCKUPDATEENTRY", "Stock Manual Update Entry");
52		}
53
54		private static $plural_name = "Stock Manual Update Entries";
		0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
55		public function i18n_plural_name()
56		{
57		return _t("BuyableStockManualUpdate.STOCKUPDATEENTRIES", "Stock Manual Update Entries");
58		}
59
60		public function canView($member = null)
61		{
62		return $this->canDoAnything($member);
63		}
64
65		public function canCreate($member = null)
66		{
67		return $this->canDoAnything($member);
68		}
69
70		public function canEdit($member = null)
71		{
72		return false;
73		}
74
75		public function canDelete($member = null)
76		{
77		return false;
78		}
79
80	View Code Duplication	protected function canDoAnything($member = null)
		0 ignored issues – show Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The parameter `$member` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		{
82		$shopAdminCode = EcommerceConfig::get("EcommerceRole", "admin_permission_code");
83		if (!Permission::check($shopAdminCode)) {
84		Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
		0 ignored issues – show Documentation introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report `$this` is of type `this<BuyableStockManualUpdate>`, but the function expects a `object<Controller>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85		}
86		return true;
87		}
88		}
89

sunnysideup / silverstripe-ecommerce_stockcontrol

Push — master ( b7c5b8...080abf )

BuyableStockManualUpdate::i18n_plural_name() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like