BuyableStockCalculatedQuantity::workoutActualQuantity() - Code Metrics - Inspection of "PATCH: better sum of quantity" - sunnysideup/silverstripe-ecommerce_stockcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 601cd4...b7c5b8 )

by Nicolaas

created 2017-06-15 10:15 UTC

workoutActualQuantity() D

↳ Parent: BuyableStockCalculatedQuantity

Complexity

Conditions	13
Paths	17

Size

Total Lines	94
Code Lines	63

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	94
rs	4.9922
c	0
b	0
f	0
cc	13
eloc	63
nc	17
nop	0

How to fix Long Method Complexity

<?php

/**
 *@author: Nicolaas [at] Sunny Side Up . Co . Nz
 *@description:
 * works out the quantity available for each buyable
 * based on the the number of items sold, recorded in BuyableStockOrderEntry,
 * and manual corrections, recorded in BuyableStockManualUpdate.
 *
 *
 **/

class BuyableStockCalculatedQuantity extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "BaseQuantity" => "Int",
        "BuyableID" => "Int",
        "BuyableClassName" => "Varchar"
    );

    private static $has_many = array(

        "BuyableStockOrderEntry" => "BuyableStockOrderEntry",
        "BuyableStockManualUpdate" => "BuyableStockManualUpdate"
    );

    private static $defaults = array(

        "BaseQuantity" => 0
    );

    private static $casting = array(

        "Name" => "Varchar",
        "Buyable" => "DataObject",
        "UnlimitedStock" => "Boolean"
    );

    //MODEL ADMIN STUFF
    private static $searchable_fields = array(

        "BaseQuantity"
    );

    private static $field_labels = array(

        "BaseQuantity" => "Calculated Quantity On Hand",
        "BuyableID" => "Buyable ID",
        "LastEdited" => "Last Calculated"
    );

    private static $summary_fields = array(

        "Name",
        "BaseQuantity",
        "LastEdited"
    );

    private static $indexes = array(

        "BuyableID" => true,
        "BuyableClassName" => true
    );

    private static $default_sort = "\"BuyableClassName\", \"BaseQuantity\" DESC";


    private static $singular_name = "Stock Calculated Quantity";


    private static $plural_name = "Stock Calculated Quantities";


    private static $calculation_done = array();


    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        return false;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    public function canView($member = null)
    {
        return $this->canDoAnything();
    }

    public function Link($action = "update")
    {
        return "/update-stock/".$action."/".$this->ID."/";
    }

    public function HistoryLink()
    {
        return $this->Link("history");
    }

    public function Buyable()

    {
        return $this->getBuyable();
    }
    public function getBuyable()

    {
        if ($this->BuyableID && class_exists($this->BuyableClassName)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $className = $this->BuyableClassName;

            return $className::get()->byID($this->BuyableID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    public function UnlimitedStock()

    {
        return $this->geUnlimitedStock();

    }
    public function getUnlimitedStock()

    {
        if ($buyable = $this->getBuyable()) {
            return $buyable->UnlimitedStock;
        }
    }

    public function Name()

    {
        return $this->getName();
    }
    public function getName()

    {
        if ($buyable = $this->getBuyable()) {
            return $buyable->getTitle();
        }
        return "no name";
    }

    protected function canDoAnything($member = null)
    {
        if ($buyable = $this->getBuyable()) {
            if ($buyable->canEdit($member)) {
                return true;
            }
        }
        Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public static function get_quantity_by_buyable($buyable)

    {
        $value = 0;
        $item = self::get_by_buyable($buyable);
        if ($item) {
            $value = $item->calculatedBaseQuantity();
            if ($value < 0) {
                $value = 0;
            }
        }
        return $value;
    }

    public static function get_by_buyable($buyable)

    {
        $obj = BuyableStockCalculatedQuantity::get()
                        ->filter(
                            array(
                                'BuyableID' => $buyable->ID,
                                'BuyableClassName' => $buyable->ClassName
                            )
                        )
                        ->First();
        if ($obj) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //do nothing
        } else {
            $obj = new BuyableStockCalculatedQuantity();
            $obj->BuyableID = $buyable->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $obj->BuyableClassName = $buyable->ClassName;

        }
        if ($obj) {
            if (isset($obj->ID) && $obj->exists() && $obj->UnlimitedStock == $buyable->UnlimitedStock) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //do nothing
            } else {
                $obj->UnlimitedStock = $buyable->UnlimitedStock;
                //we must write here to calculate quantities
                $obj->write();
            }
            return $obj;
        }
        user_error("Could not find / create BuyableStockCalculatedQuantity for buyable with ID / ClassName ".$buyableID."/".$buyableClassName, E_WARNING);

    }

    public function calculatedBaseQuantity()
    {
        if (!$this->ID) {
            return 0;
        }
        $actualQuantity = $this->workoutActualQuantity();
        if ($actualQuantity != $this->BaseQuantity) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->BaseQuantity = $actualQuantity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->write();
            return $actualQuantity;
        } else {
            return $this->getField("BaseQuantity");
        }
    }

    protected function calculatedBaseQuantities($buyables = null)
    {
        if ($buyables) {
            foreach ($buyables as $buyable) {
                $buyableStockCalculatedQuantity = BuyableStockCalculatedQuantity::get_by_buyable($buyable);
                if ($buyableStockCalculatedQuantity) {
                    $buyableStockCalculatedQuantity->calculatedBaseQuantity();
                }
            }
        }
    }

    /**
     * TODO: change to submitted from CustomerCanEdit criteria
     */


    protected function workoutActualQuantity()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $actualQuantity = 0;
        if ($buyable = $this->getBuyable()) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $query = Order::get()
                ->where('
                    "OrderItem"."BuyableID" = '.(intval($this->BuyableID) - 0).'
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    AND
                    "OrderItem"."BuyableClassName" = \''.$this->BuyableClassName.'\'

                    AND
                    "OrderStep"."CustomerCanEdit" = 0
                    AND
                    "Order"."ID" <> '.ShoppingCart::current_order()->ID.'
                ')
                ->innerJoin('OrderAttribute', '"OrderAttribute"."OrderID" = "Order"."ID"')
                ->innerJoin('OrderItem', '"OrderAttribute"."ID" = "OrderItem"."ID"')
                ->innerJoin('OrderStep', '"OrderStep"."ID" = "Order"."StatusID"');
            $amountPerOrder = array();
            if($query->count()) {
                foreach ($query as $row) {
                    if(!isset($amountPerOrder[$row->OrderID])) {
                        $amountPerOrder[$row->OrderID] = 0;
                    }
                    $amountPerOrder[$row->OrderID] += $row->Quantity;
                }
                foreach($amountPerOrder as $orderID => $sum) {
                    if ($orderID && $sum) {
                        $buyableStockOrderEntry = BuyableStockOrderEntry::get()
                            ->filter(
                                array(
                                    'OrderID' => $orderID,
                                    'ParentID' => $this->ID
                                )
                            )
                            ->First();
                        if ($buyableStockOrderEntry) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                            //do nothing
                        } else {
                            $buyableStockOrderEntry = new BuyableStockOrderEntry();
                            $buyableStockOrderEntry->OrderID = $orderID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $buyableStockOrderEntry->ParentID = $this->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $buyableStockOrderEntry->IncludeInCurrentCalculation = 1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $buyableStockOrderEntry->Quantity = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        }
                        if ($buyableStockOrderEntry->Quantity != $sum) {
                            $buyableStockOrderEntry->Quantity = $sum;
                            $buyableStockOrderEntry->write();
                        }
                    }
                }
            }
            //find last adjustment
            $latestManualUpdate = BuyableStockManualUpdate::get()
                                                            ->filter(array('ParentID' => $this->ID))
                                                            ->sort(array('LastEdited' => 'DESC'))
                                                            ->First();
            //nullify order quantities that were entered before last adjustment
            if ($latestManualUpdate) {
                $latestManualUpdateQuantity = $latestManualUpdate->Quantity;
                DB::query("
                    UPDATE \"BuyableStockOrderEntry\"
                    SET \"IncludeInCurrentCalculation\" = 0
                    WHERE
                    \"LastEdited\" < '".$latestManualUpdate->LastEdited."'
                        AND
                        \"ParentID\" = ".$this->ID
                );
            } else {
                $latestManualUpdateQuantity = 0;
            }
            //work out additional purchases
            $orderQuantityToDeduct = BuyableStockOrderEntry::get()
                                        ->filter(
                                            array(
                                                'ParentID' => $this->ID,
                                                'IncludeInCurrentCalculation' => 1
                                            )
                                        )->sum('Quantity');
            if (!$orderQuantityToDeduct) {
                $orderQuantityToDeduct = 0;
            }
            //work out base total
            $actualQuantity = $latestManualUpdateQuantity - $orderQuantityToDeduct;
            if (isset($_GET["debug"])) {
                echo "<hr />";
                echo $this->Name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                echo " | Manual SUM: ".$latestManualUpdateQuantity;
                echo " | Order SUM: ".$orderQuantityToDeduct;
                echo " | Total SUM: ".$this->BaseQuantity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                echo "<hr />";
            }
        }
        return $actualQuantity;
    }
}


1			<?php
			0 ignored issues – show Coding Style introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report File has mixed line endings; this may cause incorrect results Loading history...
2			/**
3			*@author: Nicolaas [at] Sunny Side Up . Co . Nz
4			*@description:
5			* works out the quantity available for each buyable
6			* based on the the number of items sold, recorded in BuyableStockOrderEntry,
7			* and manual corrections, recorded in BuyableStockManualUpdate.
8			*
9			*
10			**/
11
12			class BuyableStockCalculatedQuantity extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
13			{
14			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15			"BaseQuantity" => "Int",
16			"BuyableID" => "Int",
17			"BuyableClassName" => "Varchar"
18			);
19
20			private static $has_many = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$has_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21			"BuyableStockOrderEntry" => "BuyableStockOrderEntry",
22			"BuyableStockManualUpdate" => "BuyableStockManualUpdate"
23			);
24
25			private static $defaults = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26			"BaseQuantity" => 0
27			);
28
29			private static $casting = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:13 UTC by Report Bug Copy Issue Report The property `$casting` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
30			"Name" => "Varchar",
31			"Buyable" => "DataObject",
32			"UnlimitedStock" => "Boolean"
33			);
34

sunnysideup / silverstripe-ecommerce_stockcontrol

Push — master ( 601cd4...b7c5b8 )

workoutActualQuantity() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like