Completed
Push — master ( 601cd4...b7c5b8 )
by Nicolaas
03:09
created

workoutActualQuantity()   D

Complexity

Conditions 13
Paths 17

Size

Total Lines 94
Code Lines 63

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 94
rs 4.9922
c 0
b 0
f 0
cc 13
eloc 63
nc 17
nop 0

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
0 ignored issues
show
Coding Style introduced by sunnysideup
File has mixed line endings; this may cause incorrect results
Loading history...
2
/**
3
 *@author: Nicolaas [at] Sunny Side Up . Co . Nz
4
 *@description:
5
 * works out the quantity available for each buyable
6
 * based on the the number of items sold, recorded in BuyableStockOrderEntry,
7
 * and manual corrections, recorded in BuyableStockManualUpdate.
8
 *
9
 *
10
 **/
11
12
class BuyableStockCalculatedQuantity extends DataObject
0 ignored issues
show
Coding Style Compatibility introduced by sunnysideup
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
13
{
14
    private static $db = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $db is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
15
        "BaseQuantity" => "Int",
16
        "BuyableID" => "Int",
17
        "BuyableClassName" => "Varchar"
18
    );
19
20
    private static $has_many = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $has_many is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
21
        "BuyableStockOrderEntry" => "BuyableStockOrderEntry",
22
        "BuyableStockManualUpdate" => "BuyableStockManualUpdate"
23
    );
24
25
    private static $defaults = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $defaults is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
26
        "BaseQuantity" => 0
27
    );
28
29
    private static $casting = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $casting is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
30
        "Name" => "Varchar",
31
        "Buyable" => "DataObject",
32
        "UnlimitedStock" => "Boolean"
33
    );
34
35
    //MODEL ADMIN STUFF
36
    private static $searchable_fields = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $searchable_fields is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
37
        "BaseQuantity"
38
    );
39
40
    private static $field_labels = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $field_labels is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
41
        "BaseQuantity" => "Calculated Quantity On Hand",
42
        "BuyableID" => "Buyable ID",
43
        "LastEdited" => "Last Calculated"
44
    );
45
46
    private static $summary_fields = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $summary_fields is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
47
        "Name",
48
        "BaseQuantity",
49
        "LastEdited"
50
    );
51
52
    private static $indexes = array(
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $indexes is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
53
        "BuyableID" => true,
54
        "BuyableClassName" => true
55
    );
56
57
    private static $default_sort = "\"BuyableClassName\", \"BaseQuantity\" DESC";
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $default_sort is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
58
59
    private static $singular_name = "Stock Calculated Quantity";
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $singular_name is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
60
61
    private static $plural_name = "Stock Calculated Quantities";
0 ignored issues
show
Comprehensibility introduced by sunnysideup
Consider using a different property name as you override a private property of the parent class.
Loading history...
Unused Code introduced by sunnysideup
The property $plural_name is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
62
63
    private static $calculation_done = array();
0 ignored issues
show
Unused Code introduced by sunnysideup
The property $calculation_done is not used and could be removed.

This check marks private properties in classes that are never used. Those properties can be removed.

Loading history...
64
65
    public function canCreate($member = null)
66
    {
67
        return false;
68
    }
69
70
    public function canEdit($member = null)
71
    {
72
        return false;
73
    }
74
75
    public function canDelete($member = null)
76
    {
77
        return false;
78
    }
79
80
    public function canView($member = null)
81
    {
82
        return $this->canDoAnything();
83
    }
84
85
    public function Link($action = "update")
86
    {
87
        return "/update-stock/".$action."/".$this->ID."/";
88
    }
89
90
    public function HistoryLink()
91
    {
92
        return $this->Link("history");
93
    }
94
95
    public function Buyable()
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
96
    {
97
        return $this->getBuyable();
98
    }
99
    public function getBuyable()
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
100
    {
101
        if ($this->BuyableID && class_exists($this->BuyableClassName)) {
0 ignored issues
show
Documentation introduced by sunnysideup
The property BuyableID does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
Bug introduced by sunnysideup
The property BuyableClassName does not seem to exist. Did you mean ClassName?

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
102
            $className = $this->BuyableClassName;
0 ignored issues
show
Bug introduced by sunnysideup
The property BuyableClassName does not seem to exist. Did you mean ClassName?

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
103
            return $className::get()->byID($this->BuyableID);
0 ignored issues
show
Documentation introduced by sunnysideup
The property BuyableID does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
104
        }
105
    }
106
107
    public function UnlimitedStock()
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
108
    {
109
        return $this->geUnlimitedStock();
0 ignored issues
show
Bug introduced by sunnysideup
The method geUnlimitedStock() does not exist on BuyableStockCalculatedQuantity. Did you maybe mean UnlimitedStock()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
110
    }
111
    public function getUnlimitedStock()
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
112
    {
113
        if ($buyable = $this->getBuyable()) {
114
            return $buyable->UnlimitedStock;
115
        }
116
    }
117
118
    public function Name()
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
119
    {
120
        return $this->getName();
121
    }
122
    public function getName()
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
123
    {
124
        if ($buyable = $this->getBuyable()) {
125
            return $buyable->getTitle();
126
        }
127
        return "no name";
128
    }
129
130
    protected function canDoAnything($member = null)
131
    {
132
        if ($buyable = $this->getBuyable()) {
133
            if ($buyable->canEdit($member)) {
134
                return true;
135
            }
136
        }
137
        Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
0 ignored issues
show
Documentation introduced by sunnysideup
$this is of type this<BuyableStockCalculatedQuantity>, but the function expects a object<Controller>|null.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
138
    }
139
140
    public static function get_quantity_by_buyable($buyable)
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
141
    {
142
        $value = 0;
143
        $item = self::get_by_buyable($buyable);
144
        if ($item) {
145
            $value = $item->calculatedBaseQuantity();
146
            if ($value < 0) {
147
                $value = 0;
148
            }
149
        }
150
        return $value;
151
    }
152
153
    public static function get_by_buyable($buyable)
0 ignored issues
show
Documentation introduced by sunnysideup
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
154
    {
155
        $obj = BuyableStockCalculatedQuantity::get()
156
                        ->filter(
157
                            array(
158
                                'BuyableID' => $buyable->ID,
159
                                'BuyableClassName' => $buyable->ClassName
160
                            )
161
                        )
162
                        ->First();
163
        if ($obj) {
0 ignored issues
show
Unused Code introduced by sunnysideup
This if statement is empty and can be removed.

This check looks for the bodies of if statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.

These if bodies can be removed. If you have an empty if but statements in the else branch, consider inverting the condition.

if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}

could be turned into

if (rand(1, 6) <= 3) {
    print "Check succeeded";
}

This is much more concise to read.

Loading history...
164
            //do nothing
165
        } else {
166
            $obj = new BuyableStockCalculatedQuantity();
167
            $obj->BuyableID = $buyable->ID;
0 ignored issues
show
Documentation introduced by sunnysideup
The property BuyableID does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __set, maybe consider adding a @property annotation.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
168
            $obj->BuyableClassName = $buyable->ClassName;
0 ignored issues
show
Bug introduced by sunnysideup
The property BuyableClassName does not seem to exist. Did you mean ClassName?

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
169
        }
170
        if ($obj) {
171
            if (isset($obj->ID) && $obj->exists() && $obj->UnlimitedStock == $buyable->UnlimitedStock) {
0 ignored issues
show
Unused Code introduced by sunnysideup
This if statement is empty and can be removed.

This check looks for the bodies of if statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.

These if bodies can be removed. If you have an empty if but statements in the else branch, consider inverting the condition.

if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}

could be turned into

if (rand(1, 6) <= 3) {
    print "Check succeeded";
}

This is much more concise to read.

Loading history...
172
                //do nothing
173
            } else {
174
                $obj->UnlimitedStock = $buyable->UnlimitedStock;
175
                //we must write here to calculate quantities
176
                $obj->write();
177
            }
178
            return $obj;
179
        }
180
        user_error("Could not find / create BuyableStockCalculatedQuantity for buyable with ID / ClassName ".$buyableID."/".$buyableClassName, E_WARNING);
0 ignored issues
show
Bug introduced by sunnysideup
The variable $buyableID does not exist. Did you mean $buyable?

This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name.

The variable may have been renamed without also renaming all references.

Loading history...
Bug introduced by sunnysideup
The variable $buyableClassName does not exist. Did you mean $buyable?

This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name.

The variable may have been renamed without also renaming all references.

Loading history...
181
    }
182
183
    public function calculatedBaseQuantity()
184
    {
185
        if (!$this->ID) {
186
            return 0;
187
        }
188
        $actualQuantity = $this->workoutActualQuantity();
189
        if ($actualQuantity != $this->BaseQuantity) {
0 ignored issues
show
Documentation introduced by sunnysideup
The property BaseQuantity does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
190
            $this->BaseQuantity = $actualQuantity;
0 ignored issues
show
Documentation introduced by sunnysideup
The property BaseQuantity does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __set, maybe consider adding a @property annotation.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
191
            $this->write();
192
            return $actualQuantity;
193
        } else {
194
            return $this->getField("BaseQuantity");
195
        }
196
    }
197
198
    protected function calculatedBaseQuantities($buyables = null)
199
    {
200
        if ($buyables) {
201
            foreach ($buyables as $buyable) {
202
                $buyableStockCalculatedQuantity = BuyableStockCalculatedQuantity::get_by_buyable($buyable);
203
                if ($buyableStockCalculatedQuantity) {
204
                    $buyableStockCalculatedQuantity->calculatedBaseQuantity();
205
                }
206
            }
207
        }
208
    }
209
210
    /**
211
     * TODO: change to submitted from CustomerCanEdit criteria
212
     */
213
214
215
    protected function workoutActualQuantity()
0 ignored issues
show
Coding Style introduced by sunnysideup
workoutActualQuantity uses the super-global variable $_GET which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
216
    {
217
        $actualQuantity = 0;
218
        if ($buyable = $this->getBuyable()) {
0 ignored issues
show
Unused Code introduced by sunnysideup
$buyable is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
219
            $query = Order::get()
220
                ->where('
221
                    "OrderItem"."BuyableID" = '.(intval($this->BuyableID) - 0).'
0 ignored issues
show
Documentation introduced by nfrancken@gmail.com
The property BuyableID does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
222
                    AND
223
                    "OrderItem"."BuyableClassName" = \''.$this->BuyableClassName.'\'
0 ignored issues
show
Bug introduced by nfrancken@gmail.com
The property BuyableClassName does not seem to exist. Did you mean ClassName?

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
224
                    AND
225
                    "OrderStep"."CustomerCanEdit" = 0
226
                    AND
227
                    "Order"."ID" <> '.ShoppingCart::current_order()->ID.'
228
                ')
229
                ->innerJoin('OrderAttribute', '"OrderAttribute"."OrderID" = "Order"."ID"')
230
                ->innerJoin('OrderItem', '"OrderAttribute"."ID" = "OrderItem"."ID"')
231
                ->innerJoin('OrderStep', '"OrderStep"."ID" = "Order"."StatusID"');
232
            $amountPerOrder = array();
233
            if($query->count()) {
234
                foreach ($query as $row) {
235
                    if(!isset($amountPerOrder[$row->OrderID])) {
236
                        $amountPerOrder[$row->OrderID] = 0;
237
                    }
238
                    $amountPerOrder[$row->OrderID] += $row->Quantity;
239
                }
240
                foreach($amountPerOrder as $orderID => $sum) {
241
                    if ($orderID && $sum) {
242
                        $buyableStockOrderEntry = BuyableStockOrderEntry::get()
243
                            ->filter(
244
                                array(
245
                                    'OrderID' => $orderID,
246
                                    'ParentID' => $this->ID
247
                                )
248
                            )
249
                            ->First();
250
                        if ($buyableStockOrderEntry) {
0 ignored issues
show
Unused Code introduced by sunnysideup
This if statement is empty and can be removed.

This check looks for the bodies of if statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.

These if bodies can be removed. If you have an empty if but statements in the else branch, consider inverting the condition.

if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}

could be turned into

if (rand(1, 6) <= 3) {
    print "Check succeeded";
}

This is much more concise to read.

Loading history...
251
                            //do nothing
252
                        } else {
253
                            $buyableStockOrderEntry = new BuyableStockOrderEntry();
254
                            $buyableStockOrderEntry->OrderID = $orderID;
0 ignored issues
show
Documentation introduced by Nicolaas
The property OrderID does not exist on object<BuyableStockOrderEntry>. Since you implemented __set, maybe consider adding a @property annotation.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
255
                            $buyableStockOrderEntry->ParentID = $this->ID;
0 ignored issues
show
Documentation introduced by sunnysideup
The property ParentID does not exist on object<BuyableStockOrderEntry>. Since you implemented __set, maybe consider adding a @property annotation.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
256
                            $buyableStockOrderEntry->IncludeInCurrentCalculation = 1;
0 ignored issues
show
Documentation introduced by sunnysideup
The property IncludeInCurrentCalculation does not exist on object<BuyableStockOrderEntry>. Since you implemented __set, maybe consider adding a @property annotation.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
257
                            $buyableStockOrderEntry->Quantity = 0;
0 ignored issues
show
Documentation introduced by sunnysideup
The property Quantity does not exist on object<BuyableStockOrderEntry>. Since you implemented __set, maybe consider adding a @property annotation.

Since your code implements the magic setter _set, this function will be called for any write access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

Since the property has write access only, you can use the @property-write annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
258
                        }
259
                        if ($buyableStockOrderEntry->Quantity != $sum) {
260
                            $buyableStockOrderEntry->Quantity = $sum;
261
                            $buyableStockOrderEntry->write();
262
                        }
263
                    }
264
                }
265
            }
266
            //find last adjustment
267
            $latestManualUpdate = BuyableStockManualUpdate::get()
268
                                                            ->filter(array('ParentID' => $this->ID))
269
                                                            ->sort(array('LastEdited' => 'DESC'))
270
                                                            ->First();
271
            //nullify order quantities that were entered before last adjustment
272
            if ($latestManualUpdate) {
273
                $latestManualUpdateQuantity = $latestManualUpdate->Quantity;
274
                DB::query("
275
                    UPDATE \"BuyableStockOrderEntry\"
276
                    SET \"IncludeInCurrentCalculation\" = 0
277
                    WHERE
278
                    \"LastEdited\" < '".$latestManualUpdate->LastEdited."'
279
                        AND
280
                        \"ParentID\" = ".$this->ID
281
                );
282
            } else {
283
                $latestManualUpdateQuantity = 0;
284
            }
285
            //work out additional purchases
286
            $orderQuantityToDeduct = BuyableStockOrderEntry::get()
287
                                        ->filter(
288
                                            array(
289
                                                'ParentID' => $this->ID,
290
                                                'IncludeInCurrentCalculation' => 1
291
                                            )
292
                                        )->sum('Quantity');
293
            if (!$orderQuantityToDeduct) {
294
                $orderQuantityToDeduct = 0;
295
            }
296
            //work out base total
297
            $actualQuantity = $latestManualUpdateQuantity - $orderQuantityToDeduct;
298
            if (isset($_GET["debug"])) {
299
                echo "<hr />";
300
                echo $this->Name;
0 ignored issues
show
Documentation introduced by sunnysideup
The property Name does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
301
                echo " | Manual SUM: ".$latestManualUpdateQuantity;
302
                echo " | Order SUM: ".$orderQuantityToDeduct;
303
                echo " | Total SUM: ".$this->BaseQuantity;
0 ignored issues
show
Documentation introduced by sunnysideup
The property BaseQuantity does not exist on object<BuyableStockCalculatedQuantity>. Since you implemented __get, maybe consider adding a @property annotation.

Since your code implements the magic getter _get, this function will be called for any read access on an undefined variable. You can add the @property annotation to your class or interface to document the existence of this variable.

<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

If the property has read access only, you can use the @property-read annotation instead.

Of course, you may also just have mistyped another name, in which case you should fix the error.

See also the PhpDoc documentation for @property.

Loading history...
304
                echo "<hr />";
305
            }
306
        }
307
        return $actualQuantity;
308
    }
309
}
310