OrderStatusLog_SecurityCheck::canEdit() - Code Metrics - Inspection of "MINOR: better security canEdit function" - sunnysideup/silverstripe-ecommerce_security - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ef25a3...6ed45b )

by Nicolaas

created 2017-02-09 03:55 UTC

OrderStatusLog_SecurityCheck::canEdit() B

↳ Parent: OrderStatusLog_SecurityCheck

Complexity

Conditions	5
Paths	3

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	3
nop	1

<?php


/**
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: model
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class OrderStatusLog_SecurityCheck extends OrderStatusLog
namespace YourVendor;

class YourClass { }
{
    private static $days_ago_to_check = 14;


    private static $db = array(

        'Bad' => 'Boolean',
        'Risks' => 'HTMLText',
        'SubTotal' => 'Currency',
        'Check1' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check2' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check3' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check4' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check5' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check6' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check7' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check8' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check9' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check10' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check11' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
        'Check12' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
    );

    private static $many_many = array(

        'BlacklistItems' => 'EcommerceSecurityBaseClass'
    );

    /**
     *  this array works as follows
     *      array(
     *          Check1 => array(
     *              "Title" => "Customer Has Paid",
     *              "MinSubTotal" => 10,
     *              "Explanation" => "Check Payment system for $$$ coming in"
     *          ),
     *          Check2 => array(
     *              "Title" => "Address Exists",
     *              "MinSubTotal" => 50,
     *              "Explanation" => "Check Payment system for $$$ coming in"
     *          )
     *
     * @var array
     */
    private static $checks_required = array();


    private static $summary_fields = array(

        'Type' => 'Type',
        'SubTotal' => 'SubTotal',
        'SecurityCleared' => 'Security Cleared'
    );

    private static $casting = array(

        'SecurityCleared' => 'Boolean'
    );

    private static $defaults = array(

        'InternalUseOnly' => true
    );

    private static $field_labels = array(

        'Bad' => 'Fraudulent',
        'Title' => 'Value'
    );

    private static $singular_name = 'Security Check';

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Security Checks';

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($order && $order->exists()) {
            $status = $order->MyStep();
            if($status && $status->Code == 'SECURITY_CHECK') {
                return parent::canEdit($member);
            } else {
                return false;
            }
        } else {
            return parent::canEdit($member);
        }
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($order) {
            $member = $this->orderMember();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            $fields = parent::getCMSFields();
            $fields->addFieldToTab(
                'Root.Main',
                HeaderField::create(
                    'BadHeading',
                    'Mark as Fraud'
                ),
                'Bad'
            );
            $fields->addFieldToTab(
                'Root.MoreDetails',
                HTMLEditorField::create(
                    'Note',
                    'Notes'
                )
            );
            $fields->addFieldToTab(
                'Root.Main',
                HeaderField::create(
                    'BadHeading',
                    'Risks'
                ),
                'Risks'
            );
            $riskField = $fields->dataFieldByName('Risks');
            $riskField->setTitle('');
            if ($member) {
                $previousOrders = Order::get()
                    ->filter(
                        array(
                            'MemberID' => $member->ID
                        )
                    )
                    ->exclude(
                        array('ID' => $order->ID)
                    );
                if ($previousOrders->count()) {
                    $fields->addFieldToTab(
                        "Root.PreviousOrders",
                        new GridField(
                            'PreviousOrdersList',
                            'Previous Orders',
                            $previousOrders
                        )
                    );
                } else {
                    $fields->addFieldToTab(
                        "Root.PreviousOrders",
                        HeaderField::create(
                            'NoPreviousOrders',
                            'This customer does not have any previous orders'
                        )
                    );
                }
            }
        }
        $allFields = array();
        for ($i = 1; $i < 13; $i++) {
            $allFields["Check".$i] = "Check".$i;
        }
        $checks = $this->Config()->get('checks_required');
        $fields->addFieldToTab(
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            "Root.Required",
            HeaderField::create('RequiredChecksHeader', 'Required Checks'),
            'Note'
        );
        $fields->addFieldToTab(
            "Root.NotRequired",
            HeaderField::create('UnrequiredChecksHeader', 'Optional Checks'),
            'Note'
        );
        $hasRequiredChecks = false;
        $hasUnrequiredChecks = false;
        $memberIsWhitelisted = $this->memberIsWhitelisted();
        foreach ($checks as $fieldName => $details) {
            unset($allFields[$fieldName]);
            if (floatval($this->SubTotal) > floatval($details['SubTotalMin'])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $hasRequiredChecks = true;
                $fields->addFieldToTab(
                    'Root.Required',
                    $myField = $fields->dataFieldByName($fieldName)
                );
            } else {
                $hasUnrequiredChecks = true;
                $fields->addFieldToTab(
                    'Root.NotRequired',
                    $myField = $fields->dataFieldByName($fieldName)
                );
            }
            $originalOptions = $myField->getSource();
            if ($memberIsWhitelisted) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //..
            } else {
                unset($originalOptions['Whitelisted Customer']);
            }
            if (! $this->$fieldName) {
                $this->$fieldName = 'To do';
            }
            $fields->replaceField(
                $myField->ID(),

                OptionsetField::create(
                    $myField->ID(),
                    $details['Title'],
                    $originalOptions
                )
            );
            if (! empty($details['Description'])) {
                $myField->setRighTitle($details['Description']);

            }
        }
        foreach ($allFields as $fieldToRemove) {
            $fields->removeByName($fieldToRemove);
        }
        if (! $hasUnrequiredChecks) {
            $fields->addFieldToTab(
                "Root.NotRequired",
                HeaderField::create('UnrequiredChecksHeader', 'There are no optional checks for this order.'),
                'Note'
            );
        }
        if (! $hasRequiredChecks) {
            $fields->addFieldToTab(
                "Root.Required",
                HeaderField::create('RequiredChecksHeader', 'There are no required checks for this order.'),
                'Note'
            );
        }
        $fields->removeFieldFromTab('Root.Main', 'AuthorID');
        $fields->removeFieldFromTab('Root.Main', 'Title');
        $fields->removeFieldFromTab('Root.Main', 'InternalUseOnly');
        $fields->makeFieldReadonly('Risks');
        $fields->makeFieldReadonly('SubTotal');
        return $fields;
    }

    protected $warningMessages = array();

    protected function collateRisks()
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $billingAddress = $order->BillingAddress();
        $shippingAddress = $order->ShippingAddress();
        $member = $this->orderMember();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $payments = $order->Payments();
        $html = '';

        $similarArray = array();

        $daysAgo = $this->Config()->get('days_ago_to_check');
        $timeFilter = array('Created:GreaterThan' => date('Y-m-d', strtotime('-'.$daysAgo.' days')).' 00:00:00');


        //check emails from user
        $emailArray = array();
        if ($member) {
            if ($member->Email) {
                $emailArray[] = $member->Email;
                if(OrderStatusLog_WhitelistCustomer::member_is_security_risk($member)) {
                    $html .= '<p class="message bad">This customer has been marked as a security risk.</p>';
                } else {
                    if (OrderStatusLog_WhitelistCustomer::member_is_whitelisted($member)) {
                        $html .= '<p class="warning good">This customer is whitelisted.</p>';
                    } else {
                        $html .= '<p class="message warning">This customer is NOT whitelisted.</p>';
                    }
                }
            }
        }
        //are there any orders with the same Member.email in the last seven days...
        $otherOrders = Order::get_datalist_of_orders_with_submit_record()
            ->filter(
                array_merge(
                    array('MemberID' => $member->ID),
                    $timeFilter
                )
            )
            ->exclude(array('ID' => $order->ID));
        foreach ($otherOrders as $otherOrder) {

            if (!isset($similarArray[$otherOrder->ID])) {
                $similarArray[$otherOrder->ID] = array();
            }
            $similarArray[$otherOrder->ID]["Email"] = $otherOrder;
        }
        //check emails from billing address
        $emailArray = array();
        if ($billingAddress) {
            if ($billingAddress->Email) {
                $emailArray[] = $billingAddress->Email;
            }
        }
        //are there any orders with the same Billing.Email in the last seven days...
        $otherBillingAddresses = BillingAddress::get()->filter(
            array('Email' => $emailArray) + $timeFilter
        )->exclude(array('OrderID' => $order->ID));
        foreach ($otherBillingAddresses as $address) {

            $otherOrder = $address->Order();
            if (!isset($similarArray[$otherOrder->ID])) {
                $similarArray[$otherOrder->ID] = array();
            }
            $similarArray[$otherOrder->ID]["Email"] = $otherOrder;
        }
        //adding all emails to security checks
        $this->blacklistCheck($emailArray, 'EcommerceSecurityEmail');


        //phones
        $phoneArray = array();
        if ($billingAddress) {
            if ($billingAddress->Phone) {
                $phoneArray[] = $billingAddress->Phone;
            }
        }
        if ($shippingAddress) {
            if ($shippingAddress->ShippingPhone) {
                $phoneArray[] = $shippingAddress->ShippingPhone;
            }
        }
        //are there any orders with the same phone in the last xxx days...
        $otherBillingAddresses = BillingAddress::get()->filter(
            array('Phone' => $phoneArray) + $timeFilter
        )->exclude(array('OrderID' => $order->ID));
        foreach ($otherBillingAddresses as $address) {

            $otherOrder = $address->Order();
            if ($otherOrder && $otherOrder->ID != $order->ID) {
                if (!isset($similarArray[$otherOrder->ID])) {
                    $similarArray[$otherOrder->ID] = array();
                }
                $similarArray[$otherOrder->ID]["Phone"] = $otherOrder;
            }
        }
        $otherShippingAddresses = ShippingAddress::get()->filter(
            array('ShippingPhone' => $phoneArray) + $timeFilter
        )->exclude(array('OrderID' => $order->ID));
        foreach ($otherShippingAddresses as $address) {

            $otherOrder = $address->Order();
            if ($otherOrder && $otherOrder->ID != $order->ID) {
                if (!isset($similarArray[$otherOrder->ID])) {
                    $similarArray[$otherOrder->ID] = array();
                }
                $similarArray[$otherOrder->ID]["Phone"] = $otherOrder;
            }
        }
        //adding all emails to security checks
        $this->blacklistCheck($phoneArray, 'EcommerceSecurityPhone');

        //addresses
        $addressArray = array();
        if ($billingAddress) {
            if ($billingAddress->Address) {
                $addressArray[] = $billingAddress->Address;
            }
        }
        if ($shippingAddress) {
            if ($shippingAddress->ShippingAddress) {
                $addressArray[] = $shippingAddress->ShippingAddress;
            }
        }
        //are there any orders with the same address in the last xxx days...
        $otherBillingAddresses = BillingAddress::get()->filter(
            array('Address' => $addressArray) + $timeFilter
        )->exclude(array('OrderID' => $order->ID));
        foreach ($otherBillingAddresses as $address) {

            $otherOrder = $address->Order();
            if ($otherOrder && $otherOrder->ID != $order->ID) {
                if (!isset($similarArray[$otherOrder->ID])) {
                    $similarArray[$otherOrder->ID] = array();
                }
                $similarArray[$otherOrder->ID]["Address"] = $otherOrder;
            }
        }
        $otherShippingAddresses = ShippingAddress::get()
            ->filter(
                array('ShippingAddress' => $addressArray) + $timeFilter
            )
            ->exclude(array('OrderID' => $order->ID));
        foreach ($otherShippingAddresses as $address) {

            $otherOrder = $address->Order();
            if ($otherOrder && $otherOrder->ID != $order->ID) {
                if (!isset($similarArray[$otherOrder->ID])) {
                    $similarArray[$otherOrder->ID] = array();
                }
                $similarArray[$otherOrder->ID]["Address"] = $otherOrder;
            }
        }
        $this->blacklistCheck($addressArray, 'EcommerceSecurityAddress');


        //IP
        $ipArray = array();
        $ipProxyArray = array();
        if ($payments) {
            foreach ($payments as $payment) {
                if(strlen($payment->IP) > 10) {
                    $ipArray[] = $payment->IP;
                }
                if(strlen($payment->ProxyIP) > 10) {
                    $ipProxyArray[] = $payment->ProxyIP;
                }
            }
        }
        if(count($ipArray)) {

            //are there any orders with the same IP in the xxx seven days...
            $otherPayments = EcommercePayment::get()->filter(
                array('IP' => $ipArray) + $timeFilter
            )->exclude(array('OrderID' => $order->ID));
            foreach ($otherPayments as $payment) {
                $otherOrder = $payment->Order();
                if (!isset($similarArray[$otherOrder->ID])) {
                    $similarArray[$otherOrder->ID] = array();
                }
                $similarArray[$otherOrder->ID]["IP"] = $otherOrder;
            }
            $this->blacklistCheck($ipArray, 'EcommerceSecurityIP');
        }
        if(count($ipProxyArray)) {

            //are there any orders with the same Proxy in the xxx seven days...
            $otherPayments = EcommercePayment::get()->filter(
                array('ProxyIP' => $ipProxyArray) + $timeFilter
            )->exclude(array('OrderID' => $order->ID));
            foreach ($otherPayments as $payment) {
                $otherOrder = $payment->Order();
                if (!isset($similarArray[$otherOrder->ID])) {
                    $similarArray[$otherOrder->ID] = array();
                }
                $similarArray[$otherOrder->ID]["ProxyIP"] = $otherOrder;
            }
            $this->blacklistCheck($ipProxyArray, 'EcommerceSecurityProxyIP');
        }


        if (count($this->warningMessages)) {
            $html .= '<h4 style="color: red;">Blacklisted Details</h4><ul class="SecurityCheckListOfRisks warnings" style="color: red;">';
            foreach ($this->warningMessages as $warningMessage) {
                $html .= $warningMessage;
            }
            $html .= '</ul>';
        } else {
            $html .= '<p class="message good">No Blacklisted Data Present</p>';
        }
        if (count($similarArray)) {
            $days = $this->Config()->get('days_ago_to_check');
            $html .= '<h4>Similar orders in the last '.$days.' days</h4><ul class="SecurityCheckListOfRisks otherRisks">';
            foreach ($similarArray as $orderID => $fields) {
                //we just loop this so we can get the order ...
                foreach ($fields as $tempOrder) {
                    break;
                }
                $html .= '<li><a href="'.$tempOrder->CMSEditLink().'">'.$tempOrder->getTitle().'</a>: with same '.implode(', and with same ', array_keys($fields)).'</li>';
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
            }
            $html .= '</ul>';
        } else {
            $html .= '<p class="message good">No similar orders in the last '.$daysAgo.' days</p>';
        }

        return $html;
    }

    public function getSecurityCleared()
    {
        return  DBField::create_field('Boolean', ($this->pass() ? true : false));
    }

    /**
     *
     *
     *
     * @param  Order $order
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return bool
     */
    public function pass()
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if (! $order) {
            return false;
        }
        $checks = $this->Config()->get('checks_required');
        $fieldsAvailable = $this->stat('db');
        foreach ($checks as $fieldName => $fieldDetails) {
            if (floatval($this->SubTotal) > floatval($fieldDetails['SubTotalMin'])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if (! isset($fieldsAvailable[$fieldName])) {
                    user_error('bad field  ....');
                }
                // there is a check that needs to be TRUE, but is not ...
                if ($this->$fieldName == 'Done' || $this->$fieldName == 'Whitelisted Customer') {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                } else {
                    return false;
                }
            }
        }
        return true;
    }

    private static $_saved_already = 0;

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if (self::$_saved_already < 3) {
            self::$_saved_already++;
            if ($order && $order->exists()) {
                $this->SubTotal = $order->getSubTotal();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Risks = $this->collateRisks();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->write();
            } else {
                $this->SubTotal = 9999;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Risks = "Error";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->write();
            }
            if($this->memberIsWhitelisted()) {
                for ($i = 1; $i < 13; $i++) {
                    $field = "Check".$i;
                    $this->$field = 'Whitelisted Customer';
                }
                $this->write();
            }
        }
        if($this->Bad) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            foreach($this->BlacklistItems() as $blacklistItem) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $blacklistItem->Status = 'Bad';
                $blacklistItem->write();
            }
            if ($order && $order->exists()) {
                $order->Archive(true);
            }
            if($member = $this->orderMember()) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                $member->IsWhitelisted = false;
                $member->IsSecurityRisk = true;
                $member->write();
            }
        }
    }

    /**
     *
     * @param  EcommerceSecurityBaseClass $obj
     * @return bool                             return true if the status of the object is `Bad`
     */
    protected function checkSecurityObject($obj)
    {
        if ($obj->Status == 'Bad') {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return false;
        }
        return true;
    }

    /**
     * caching variable only...
     *
     * @var null | bool
     */
    private $_memberIsWhitelisted = null;

    protected function memberIsWhitelisted()
    {
        if ($this->_memberIsWhitelisted  === null) {
            if($member = $this->orderMember()) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                $this->_memberIsWhitelisted = OrderStatusLog_WhitelistCustomer::member_is_whitelisted($member);

            }
        }
        return $this->_memberIsWhitelisted;
    }

    /**
     *
     * @return null | Member
     */
    protected function orderMember()
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($order && $order->exists()) {
            $member = $order->Member();
            if ($member && $member->exists()) {
                return $member;
            }
        }
    }

    protected function blacklistCheck($arrayOfValues, $securityClass)
    {
        //adding all emails to security checks
        foreach ($arrayOfValues as $value) {
            if ($value) {
                $obj = $securityClass::find_or_create(array("Title" => $value));
                if($obj->exists()) {
                    $this->BlacklistItems()->add($obj);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    if ($obj->hasRisks()) {
                        $title = $obj->i18n_singular_name();
                        $message = '<li><strong>'.$title.':</strong> '.$value.'<li>';
                        $this->warningMessages[$message] = $message;
                    }
                }
            }
        }

    }

}


1			<?php
2
3
4			/**
5			* @authors: Nicolaas [at] Sunny Side Up .co.nz
6			* @package: ecommerce
7			* @sub-package: model
8			* @inspiration: Silverstripe Ltd, Jeremy
9			**/
10			class OrderStatusLog_SecurityCheck extends OrderStatusLog
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			private static $days_ago_to_check = 14;
			0 ignored issues – show Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$days_ago_to_check` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13
14			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15			'Bad' => 'Boolean',
16			'Risks' => 'HTMLText',
17			'SubTotal' => 'Currency',
18			'Check1' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
19			'Check2' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
20			'Check3' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
21			'Check4' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
22			'Check5' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
23			'Check6' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
24			'Check7' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
25			'Check8' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
26			'Check9' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
27			'Check10' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
28			'Check11' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
29			'Check12' => 'Enum("To do, Done, Whitelisted Customer", "To do" )',
30			);
31
32			private static $many_many = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-09 00:17 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-09 00:17 UTC by Report Bug Copy Issue Report The property `$many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33			'BlacklistItems' => 'EcommerceSecurityBaseClass'
34			);
35
36			/**

sunnysideup / silverstripe-ecommerce_security

Push — master ( ef25a3...6ed45b )

OrderStatusLog_SecurityCheck::canEdit() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like