EcommerceSecurityOrderDecoration

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	23	3
A	onBeforeWrite()	0	14	2

<?php

class EcommerceSecurityOrderDecoration extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

The property $db is not used and could be removed.

        'SkipPayment' => 'Boolean'
    );

    public function updateCMSFields(FieldList $fields)
    {
        if ($this->owner->IsSubmitted()) {
            if (! $this->owner->IsPaid()) {
                $fields->addFieldsToTab(
                    'Root.Payments',
                    [
                        HeaderField::create(
                            'SkipToSecurityChecks',
                            'Skip To Security Checks'
                        ),
                        CheckboxField::create(
                            'SkipPayment',
                            'Skip Payment'
                        )->setDescription(
                            'Ticking this checkbox will add a fake "successful" payment to the order,  this allows the order to proceed to the security checks step.
                            <br>Make sure to save the order after ticking this checkbox.'
                        )
                    ]
                );
            }
        }
    }

    /**
     * Event handler called before writing to the database.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->owner->SkipPayment) {

The property SkipPayment does not seem to exist in SS_Object.

            $money = Money::create();
            $money->setAmount($this->owner->TotalOutstanding());
            $payment = EcommercePayment::create();
            $payment->Status = 'Success';
            $payment->Amount = $money;
            $payment->Message = 'This is a fake payment that has been created to allow the order to proceed to the next step, this order has not really been paid for.';
            $payment->write();
            $this->owner->Payments()->add($payment);
        }
    }
}