OrderStatusLog_WhitelistCustomer::assessCustomer() - Code Metrics - Inspection of "MINOR: enhancements in white listing" - sunnysideup/silverstripe-ecommerce_security - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 21af4b...3bae41 )

by Nicolaas

created 2017-02-02 07:30 UTC

OrderStatusLog_WhitelistCustomer::assessCustomer() C

↳ Parent: OrderStatusLog_WhitelistCustomer

Complexity

Conditions	12
Paths	10

Size

Total Lines	74
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	74
rs	5.3992
c	0
b	0
f	0
cc	12
eloc	50
nc	10
nop	0

How to fix Long Method Complexity

<?php


/**
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: model
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class OrderStatusLog_WhitelistCustomer extends OrderStatusLog
namespace YourVendor;

class YourClass { }
{
    /**
     * @var int
     */
    private static $min_number_of_paid_orders_required = 1;


    private static $db = array(

        'Whitelist' => 'Boolean'
    );

    private static $has_one = array(

        'Member' => 'Member',
        'BasedOn' => 'OrderStatusLog_WhitelistCustomer'
    );

    private static $defaults = array(

        'InternalUseOnly' => true
    );

    private static $singular_name = 'Whitelist Customer Record';

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Whitelist Customer Records';

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        return parent::canEdit($member);
    }

    public function canDelete($member = null)
    {
        return false;
    }

    public function getCMSFields() {
        $fields = parent::getCMSFields();
        $fields->replaceField(
            'BasedOnID',
            CMSEditLinkField::create(
                'BasedOnID',
                _t('OrderStatusLog_WhitelistCustomer.BASED_ON', 'Based on'),
                $this->BasedOn()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            )
        );
        $fields->replaceField(
            'MemberID',
            CMSEditLinkField::create(
                'MemberID',
                _t('OrderStatusLog_WhitelistCustomer.CUSTOMER', 'Customer'),
                $this->Member()

            )
        );
        return $fields;
    }

    /**
     *
     *
     * @param  Member  $member  the member to check
     * @return boolean          returns true of the member has been whitelisted before
     */
    public static function member_is_whitelisted(Member $member)
    {
        return OrderStatusLog_WhitelistCustomer::get()
            ->filter(
                array(
                    'MemberID' => $member->ID,
                    'Whitelist' => 1
                )
            )->count() ? true : false;
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->Whitelist) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($member = $this->Member()) {

                if ($member->exists()) {
                    $member->IsWhitelisted = true;
                    $member->write();
                }
            }
        }
    }

    public function assessCustomer()
    {
        //already done ...
        if($this->Whitelist) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return true;
        }
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($order && $order->exists()) {
            if ($order->MemberID) {
                $this->MemberID = $order->MemberID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Whitelist = false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $member = $order->Member();
                if ($member && $member->exists()) {
                    //check if member has previouly been whitelisted
                    $previousOne = OrderStatusLog_WhitelistCustomer::get()
                        ->filter(
                            array(
                                'Whitelist' => 1,
                                'MemberID' => $member->ID
                            )
                        )
                        ->exclude(
                            array('OrderID' => $order->ID)
                        )->first();
                    if ($previousOne) {
                        $this->Whitelist = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $this->BasedOnID = $previousOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    } else {

                        //member is already whitelisted
                        $previousOne = OrderStatusLog_WhitelistCustomer::get()
                            ->filter(
                                array(
                                    'MemberID' => $member->ID
                                )
                            )
                            ->exclude(
                                array('OrderID' => $order->ID)
                            )->first();
                        if ($previousOne) {
                            $this->Whitelist = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $this->BasedOnID = $previousOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        } else {
                            //member has placed orders before
                            $previousOrders = Order::get()
                                ->filter(
                                    array(
                                        'MemberID' => $member->ID,
                                        'CancelledByID' => 0
                                    )
                                )
                                ->exclude(
                                    array(
                                        'ID' => $order->ID
                                    )
                                );
                            $count = 0;
                            $minOrdersRequired = $this->Config()->get('min_number_of_paid_orders_required');
                            foreach($previousOrders as $previousOrder) {
                                if($previousOrder->IsPaid()) {
                                    $count++;
                                    if($count >= $minOrdersRequired) {
                                        $this->Whitelist = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                        break;
                                    }
                                }
                            }
                        }
                    }
                }
                $this->write();
            }
        }
    }
}


1			<?php
2
3
4			/**
5			* @authors: Nicolaas [at] Sunny Side Up .co.nz
6			* @package: ecommerce
7			* @sub-package: model
8			* @inspiration: Silverstripe Ltd, Jeremy
9			**/
10			class OrderStatusLog_WhitelistCustomer extends OrderStatusLog
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			/**
13			* @var int
14			*/
15			private static $min_number_of_paid_orders_required = 1;
			0 ignored issues – show Unused Code introduced 2017-02-02 07:33 UTC by Report Bug Copy Issue Report The property `$min_number_of_paid_orders_required` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16
17			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18			'Whitelist' => 'Boolean'
19			);
20
21			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22			'Member' => 'Member',
23			'BasedOn' => 'OrderStatusLog_WhitelistCustomer'
24			);
25
26			private static $defaults = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
27			'InternalUseOnly' => true
28			);
29
30			private static $singular_name = 'Whitelist Customer Record';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
31			public function i18n_singular_name()
32			{
33			return self::$singular_name;
34			}

sunnysideup / silverstripe-ecommerce_security

Push — master ( 21af4b...3bae41 )

OrderStatusLog_WhitelistCustomer::assessCustomer() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like