Conditions | 12 |
Paths | 9 |
Total Lines | 58 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
117 | public function assessCustomer() |
||
118 | { |
||
119 | //already done ... |
||
120 | if ($this->Whitelist) { |
||
121 | return true; |
||
122 | } |
||
123 | $order = $this->Order(); |
||
124 | if ($order && $order->exists()) { |
||
125 | if ($order->MemberID) { |
||
126 | $this->MemberID = $order->MemberID; |
||
127 | $this->Whitelist = false; |
||
128 | $member = $order->Member(); |
||
129 | if ($member && $member->exists()) { |
||
130 | //check if member has previouly been whitelisted |
||
131 | $previousOne = OrderStatusLog_WhitelistCustomer::get() |
||
132 | ->filter( |
||
133 | array( |
||
134 | 'Whitelist' => 1, |
||
135 | 'MemberID' => $member->ID |
||
136 | ) |
||
137 | ) |
||
138 | ->exclude( |
||
139 | array('OrderID' => $order->ID) |
||
140 | )->first(); |
||
141 | if ($previousOne) { |
||
142 | $this->Whitelist = true; |
||
143 | $this->BasedOnID = $previousOne->ID; |
||
144 | } else { |
||
145 | //member has placed orders before |
||
146 | $previousOrders = Order::get() |
||
147 | ->filter( |
||
148 | array( |
||
149 | 'MemberID' => $member->ID, |
||
150 | 'CancelledByID' => 0 |
||
151 | ) |
||
152 | ) |
||
153 | ->exclude( |
||
154 | array( |
||
155 | 'ID' => $order->ID |
||
156 | ) |
||
157 | ); |
||
158 | $count = 0; |
||
159 | $minOrdersRequired = $this->Config()->get('min_number_of_paid_orders_required'); |
||
160 | foreach ($previousOrders as $previousOrder) { |
||
161 | if ($previousOrder->IsPaid() && $previousOrder->IsArchived()) { |
||
162 | $count++; |
||
163 | if ($count >= $minOrdersRequired) { |
||
164 | $this->Whitelist = true; |
||
165 | break; |
||
166 | } |
||
167 | } |
||
168 | } |
||
169 | } |
||
170 | } |
||
171 | $this->write(); |
||
172 | } |
||
173 | } |
||
174 | } |
||
175 | } |
||
176 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.