EcommerceSecurityMemberDecoration::onBeforeWrite() - Code Metrics - sunnysideup/silverstripe-ecommerce_security - Measure and Improve Code Quality continuously with Scrutinizer

EcommerceSecurityMemberDecoration::onBeforeWrite() A
last analyzed 2018-08-23 00:24 UTC

↳ Parent: EcommerceSecurityMemberDecoration

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php

class EcommerceSecurityMemberDecoration extends DataExtension
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'IsWhitelisted' => 'Boolean',
        'IsSecurityRisk' => 'Boolean'
    );

    /**
     * Event handler called before writing to the database.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->owner->IsSecurityRisk) {

            $this->owner->IsWhitelisted = false;

            $securityCheck = EcommerceSecurityEmail::get()->filter(['Title' => $this->owner->Email])->first();

            if ($securityCheck) {
                $securityCheck->Status = 'Bad';
            } else {
                $securityCheck = EcommerceSecurityEmail::create();
                $securityCheck->Title = $this->owner->Email;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $securityCheck->Status = 'Bad';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            $securityCheck->write();
        }
    }
}


1			<?php
2
3			class EcommerceSecurityMemberDecoration extends DataExtension
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			private static $db = array(
			0 ignored issues – show Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6			'IsWhitelisted' => 'Boolean',
7			'IsSecurityRisk' => 'Boolean'
8			);
9
10			/**
11			* Event handler called before writing to the database.
12			*/
13			public function onBeforeWrite()
14			{
15			parent::onBeforeWrite();
16			if ($this->owner->IsSecurityRisk) {
			0 ignored issues – show Bug introduced 2018-06-20 01:14 UTC by Report Bug Copy Issue Report The property `IsSecurityRisk` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
17			$this->owner->IsWhitelisted = false;
			0 ignored issues – show Bug introduced 2018-06-20 01:14 UTC by Report Bug Copy Issue Report The property `IsWhitelisted` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
18			$securityCheck = EcommerceSecurityEmail::get()->filter(['Title' => $this->owner->Email])->first();
			0 ignored issues – show Bug introduced 2018-06-20 01:14 UTC by Report Bug Copy Issue Report The property `Email` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
19			if ($securityCheck) {
20			$securityCheck->Status = 'Bad';
21			} else {
22			$securityCheck = EcommerceSecurityEmail::create();
23			$securityCheck->Title = $this->owner->Email;
			0 ignored issues – show Documentation introduced 2017-09-29 01:13 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<EcommerceSecurityEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24			$securityCheck->Status = 'Bad';
			0 ignored issues – show Documentation introduced 2017-09-29 01:13 UTC by Report Bug Copy Issue Report The property `Status` does not exist on `object<EcommerceSecurityEmail>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			}
26			$securityCheck->write();
27			}
28			}
29			}
30

sunnysideup / silverstripe-ecommerce_security

EcommerceSecurityMemberDecoration::onBeforeWrite() A last analyzed 2018-08-23 00:24 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EcommerceSecurityMemberDecoration::onBeforeWrite() A
last analyzed 2018-08-23 00:24 UTC