SecondHandProductAdmin

Complexity

Total Complexity

10

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	getEditForm()	0	15	5
A	doCancel()	0	4	1
B	restore()	0	22	4

<?php

/**
 * @description: for the management of Product and Product Groups only
 *
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: cms
 **/

class SecondHandProductAdmin extends ModelAdminEcommerceBaseClass

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $menu_priority = 3.2;

Consider using a different property name as you override a private property of the parent class.

The property $menu_priority is not used and could be removed.

    private static $url_segment = 'secondhandproducts';

Consider using a different property name as you override a private property of the parent class.

The property $url_segment is not used and could be removed.

    private static $menu_title = 'Second Hand';

Consider using a different property name as you override a private property of the parent class.

The property $menu_title is not used and could be removed.

    private static $managed_models = array(

Consider using a different property name as you override a private property of the parent class.

The property $managed_models is not used and could be removed.

        'SecondHandProduct',
        'SecondHandArchive'
    );

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        "editinsitetree",
        "ItemEditForm",
        "restore" => true,
    );

    /**
     * standard SS variable
     * @var String
     */
    private static $menu_icon = "ecommerce/images/icons/product-file.gif";

Consider using a different property name as you override a private property of the parent class.

The property $menu_icon is not used and could be removed.

    public function getEditForm($id = null, $fields = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        foreach (GoogleAddressField::js_requirements() as $jsFile) {
            Requirements::javascript($jsFile);
        }
        $form = parent::getEditForm();
        if (singleton($this->modelClass) instanceof SiteTree) {
            if ($gridField = $form->Fields()->dataFieldByName($this->sanitiseClassName($this->modelClass))) {
                if ($gridField instanceof GridField) {
                    $gridField->setConfig(GridFieldEditOriginalPageConfigSecondHandPage::create());
                }
            }
        }
        return $form;
    }


    public function doCancel($data, $form)

The parameter $data is not used and could be removed.

The parameter $form is not used and could be removed.

    {
        return $this->redirect(singleton('CMSMain')->Link());
    }

    function restore($request){

The parameter $request is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

restore uses the super-global variable $_GET which is generally not recommended.

        if(isset($_GET['productid'])){
            $id = intval($_GET['productid']);
            if($id) {
                $restoredPage = Versioned::get_latest_version("SiteTree", $id);
                if(!$restoredPage) 	return new SS_HTTPResponse("SiteTree #$id not found", 400);
                $restoredPage = $restoredPage->doRestoreToStage();
                $restoredPage->doPublish();
                $this->getResponse()->addHeader(
                    'X-Status',
                    rawurlencode(_t(
                        'CMSMain.RESTORED',
                        "Restored '{title}' successfully",
                        array('title' => $restoredPage->Title)

array('title' => $restoredPage->Title) is of type array<string,?,{"title":"?"}>, but the function expects a string.

                    ))
                );
                $cmsEditLink = '/admin/secondhandproducts/SecondHandProduct/EditForm/field/SecondHandProduct/item/'.$id.'/edit';
                return Controller::curr()->redirect($cmsEditLink);
            }
        }
        return new SS_HTTPResponse("ERROR!", 400);
    }
}