SecondHandProduct::onBeforeWrite() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_second_hand_product - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bee3fd...584b84 )

unknown

created 2017-05-04 23:24 UTC

SecondHandProduct::onBeforeWrite() D

↳ Parent: SecondHandProduct

Complexity

Conditions	10
Paths	36

Size

Total Lines	32
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	17
nc	36
nop	0

How to fix Complexity

<?php


class SecondHandProduct extends Product implements PermissionProvider
namespace YourVendor;

class YourClass { }
{
    private static $can_be_root = false;


    /**
     * halt purchase for ... number of days
     * from the day of creation.
     * @var int
     */
    private static $embargo_number_of_days = 0;


    /**
     * Restrict GoogleAddressField to a specific Country
     * E.g. for New Zealand, $country_code =  'NZ'
     * @var string
     */
    private static $country_code = null;

    /**
     * stadard SS declaration
     * @var Array
     */
    private static $db = array(

        'PurchasePrice' => 'Currency',
        'ProductQuality' => 'ENUM("1, 2, 3, 4, 5, 6, 7, 8, 9, 10","10")',
        'IncludesBoxOrCase' => "ENUM('No, Box, Case, Both','No')",
        'SellingOnBehalf' => 'Boolean',
        'OriginalManual' => 'Boolean',
        'DateItemWasBought' => 'Date',
        'DateItemWasSold' => 'Date',
        'SerialNumber' => 'VarChar(50)',
        'SellersName' =>  'VarChar(50)',
        'SellersPhone' =>  'VarChar(30)',
        'SellersEmail' =>  'VarChar(255)',
        'SellersAddress' =>  'VarChar(255)',
        'SellersAddress2' => 'Varchar(255)',
        'SellersCity' => 'Varchar(100)',
        'SellersPostalCode' => 'Varchar(50)',
        'SellersRegionCode' => 'Varchar(100)',
        'SellersCountry' => 'Varchar(50)',
        'SellersIDType' => 'ENUM(",Drivers Licence, Firearms Licence, Passport","")',
        'SellersIDNumber' => 'Varchar(50)',
        'SellersDateOfBirth' => 'Date',
        'SellersIDExpiryDate' => 'Date',
        'SellersIDPhotocopy' => 'Boolean'
    );

    private static $has_one = array(

        'BasedOn' => 'SecondHandProduct'
    );

    private static $default_sort = array(

        'Created' => 'DESC'
    );

    private static $defaults = array(

        'ShowInMenus' => false
    );

    private static $indexes = array(

        'SerialNumber' => true
    );

    private static $casting = array(

        'SellersSummary' => 'Varchar',
        'CreatedNice' => 'Varchar'
    );

    private static $seller_summary_detail_fields = array(

        'SellersName',
        'SellersPhone',
        'SellersEmail',
        'SellersAddress',
        'SellersAddress2',
        'SellersCity',
        'SellersPostalCode',
        'SellersRegionCode',
        'SellersCountry',
        'SellersIDType',
        'SellersIDNumber',
        'SellersDateOfBirth',
        'SellersIDExpiryDate',
        'SellersIDPhotocopy'
    );

    private static $searchable_fields = array(

        'FullName' => array(
            'title' => 'Keyword',
            'field' => 'TextField',
        ),
        'Price' => array(
            'title' => 'Price',
            'field' => 'NumericField',
        ),
        'InternalItemID' => array(
            'title' => 'Internal Item ID',
            'filter' => 'PartialMatchFilter',
        ),
        'SellersName' => array(
            'title' => 'Sellers Name',
            'filter' => 'PartialMatchFilter',
        ),
        'SellersPhone' => array(
            'title' => 'Sellers Phone',
            'filter' => 'PartialMatchFilter',
        ),
        'SellersEmail' => array(
            'title' => 'Sellers Email',
            'filter' => 'PartialMatchFilter',
        ),
        'AllowPurchase',
        'PurchasePrice' => 'ExactMatchFilter',
        'SerialNumber' => 'PartialMatchFilter'
    );

    public function getSellerSummary()
    {
        $list = Config::inst()->get('SecondHandProduct', 'seller_summary_detail_fields');
        $array = array();
        foreach ($list as $field) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (trim($this->$field)) {
                $array[] = $this->$field;
            }
        }
        return implode('; ', $array);
    }

    private static $second_hand_admin_group_code = 'second-hand-managers';


    private static $second_hand_admin_group_name = 'Second Hand Product Managers';


    private static $second_hand_admin_role_title = 'Second Hand Product Management';


    private static $second_hand_admin_permission_code = 'CMS_ACCESS_SECOND_HAND_PRODUCTS';


    private static $second_hand_admin_permission_title = 'Second Hand Product Manager';


    private static $second_hand_admin_permission_help = 'Manages the second product products';


    private static $second_hand_admin_user_email = '';


    private static $second_hand_admin_user_firstname = '';


    private static $second_hand_admin_user_surname = '';


    private static $second_hand_admin_user_password = "";


    /**
     * standard SS declaration
     * @var String
     */
    private static $icon = "ecommerce_second_hand_product/images/treeicons/SecondHandProduct";


    /**
     * Standard SS variable.
     */
    private static $singular_name = 'SecondHand Product';

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = 'SecondHand Products';

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    /**
     * standard SS declaration
     * @var String
     */
    private static $description = "This page displays a single secondhand product that can only be sold once";


    /**
     * standard SS method
     * @return Boolean

     */
    public function canCreate($member = null)
    {
        return Permission::check(
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_code'),
            'any',
            $member
        );
    }

    /**
     * standard SS method
     * @return Boolean

     */
    public function canPublish($member = null)
    {
        return Permission::check(
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_code'),
            'any',
            $member
        );
    }

    /**
     * standard SS method
     * @return Boolean

     */
    public function canEdit($member = null)
    {
        return Permission::check(
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_code'),
            'any',
            $member
        );
    }

    /**
     * standard SS method
     * @return Boolean

     */
    public function canDelete($member = null)
    {
        return Permission::check(
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_code'),
            'any',
            $member
        );
    }

    public function onBeforeDelete()
    {
        SecondHandArchive::create_from_page($this);
        parent::onBeforeDelete();
    }


    /**
     * stadard SS method
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        //remove all unneccessary fields and tabs
        $fields->removeByName("AlsoShowHere");
        $fields->removeByName("Tax");
        $fields->removeByName("Links");
        $fields->removeByName("Details");
        $fields->removeByName("Images");
        $fields->removeFieldFromTab('Root', 'Title');
        $fields->removeFieldFromTab('Root', 'URLSegment');
        $fields->removeFieldFromTab('Root', 'MenuTitle');
        $fields->removeFieldFromTab('Root', 'ShortDescription');
        $fields->removeFieldFromTab('Root', 'Content');
        $fields->removeFieldFromTab('Root', 'Metadata');
        $fields->removeFieldFromTab('Root', 'AddToCartLink');

        $fields->addFieldsToTab(
            'Root.Main',
            array(
                $allowPurchaseField = CheckboxField::create("AllowPurchase", "<strong>Allow product to be purchased</strong>"),
                $sellinOnBehalf = CheckboxField::create("SellingOnBehalf", "<strong>Selling on behalf</strong>"),
                $featuredProductField = CheckboxField::create('FeaturedProduct', _t('Product.FEATURED', '<strong>Featured Product</strong>')),
                TextField::create('Title', 'Product Title'),
            )
        );
        $secondhandProductCategories = SecondHandProductGroup::get();
        if ($secondhandProductCategories->count()) {
            $fields->addFieldToTab(
                'Root.Main',
                $categoryField = DropdownField::create(
                    'ParentID',
                    'Product Category',
                    $secondhandProductCategories->map()
                )
            );
        }
        $fields->addFieldsToTab(
            'Root.Main',
            array(
                ReadonlyField::create('CanBeSold', "For Sale", DBField::create_field('Boolean', $this->canPurchase())->Nice()),
                ReadonlyField::create('CreatedNice', "First Entered", $this->getCreatedNice()),
                TextField::create('InternalItemID', "Product Code"),
                $salePriceField = NumericField::create('Price', 'Sale Price'),
                $purchasePriceField = NumericField::create('PurchasePrice', 'Purchase Price'),
                $serialNumberField = TextField::create('SerialNumber', 'Serial Number'),
                $productQualityField = DropdownField::create(
                    "ProductQuality",
                    "Product Condition/Quality",
                    $this->dbObject('ProductQuality')->enumValues()
                ),
                $boxOrCaseField = DropdownField::create(
                    "IncludesBoxOrCase",
                    "Includes Box/Case",
                    $this->dbObject('IncludesBoxOrCase')->enumValues()
                ),
                $originalManualField = CheckboxField::create("OriginalManual", "Includes Original Manual"),
                $contentField = TextField::create("ShortDescription", "Description"),
                $boughtDate = DateField::create('DateItemWasBought', 'Date this item was bought'),
                $soldDate = DateField::create('DateItemWasSold', 'Date this item was sold'),
                $mainImageField = UploadField::create("Image", "Main Product Image"),
                $additionalImagesField = UploadField::create("AdditionalImages", "More Images"),
                $metaFieldDesc = TextareaField::create("MetaDescription", 'Meta Description')
            )
        );
        $soldDate->setDisabled(true);

        //set right titles and descriptions
        $featuredProductField->setDescription('If this box is ticked then this product will appear in the "Featured Products" box on the home page');
        $allowPurchaseField->setDescription("This box must be ticked to allow a customer to purchase it");
        $sellinOnBehalf->setDescription('This box must be ticked if this product is being sold on behalf');
        $salePriceField->setRightTitle("Selling price");
        $purchasePriceField->setRightTitle("Price paid for the product");
        $serialNumberField->setRightTitle("Enter the serial number of the product here");
        $originalManualField->setDescription("Tick this box if the product includes the original manual, otherwise leave it empty");
        $boxOrCaseField->setRightTitle("Does this product come with a box, case or both?");
        $contentField->setRightTitle("Optional text only description, the maximum length of this description is 255 characters.");
        $contentField->setMaxLength(255);
        $qualityFieldDescription = "A <strong>Condition Rating Page</strong> has yet to be setup";
        $obj = $this->EcomConfig()->SecondHandExplanationPage();
        if ($obj->exists()) {
            $qualityFieldDescription = 'An explanation of the ratings scale can be found by clicking this <a href="' . $obj->Link() . '">link</a>';
        }
        $productQualityField->setRightTitle($qualityFieldDescription);
        $boughtDate->setRightTitle('Date Format (dd-mm-YYYY). Example: 3rd of May 1992 should be entered as 03-05-1992');
        $mainImageField->setRightTitle(
            "<strong>Upload the main image for the product here.</strong><br>
            Recommended size: 810px wide x 418px high - but you can choose any width up to 810px, height must
            ALWAYS BE 418px. Should be provided to FTP data upload as productcode.jpg - e.g. 1003040.jpg.
            Images should be compressed up to 50%."
        );
        $additionalImagesField->setRightTitle(
            "<strong>Upload additional images here, you can upload as many as you want.</strong><br>
            Recommended size: 810px wide x 418px high - but you can choose any width up to 810px, height must
            ALWAYS BE 418px. Should be provided to FTP data upload as productcode.jpg - e.g. 1003040.jpg.
            Images should be compressed up to 50%."
        );
        //replace InternalItemID field with a read only field
        $fields->replaceField(
            'InternalItemID',
            $fields->dataFieldByName('InternalItemID')->performReadonlyTransformation()
        );

        $lastEditedItems = SecondHandProduct::get()->sort('Created', 'DESC')->limit(100);

        $lastItems = array(
            0 => '--- not based on previous sale ---'
        );

        foreach ($lastEditedItems as $lastEditedItem) {
            $details = $lastEditedItem->getSellerSummary();
            if ($details) {
                $lastItems[$lastEditedItem->ID] = $details;
            }
        }

        $fields->addFieldsToTab(
            'Root.SellersDetails',
            array(
                HeaderField::create('SellersDetails', 'Enter the details of the person who the product was purchased from'),
                DropdownField::create(
                    'BasedOnID',
                    'Autocomplete from saved items',
                    $lastItems),
                TextField::create('SellersName', 'Name'),
                TextField::create('SellersPhone', 'Phone'),
                TextField::create('SellersEmail', 'Email Address'),
                DropdownField::create(
                    'SellersIDType',
                    'ID Type',
                    $this->dbObject('SellersIDType')->enumValues()),
                TextField::create('SellersIDNumber', 'ID Number'),
                DateField::create('SellersDateOfBirth', 'Date of Birth'),
                DateField::create('SellersIDExpiryDate', 'ID Expiry Date'),
                CheckboxField::create('SellersIDPhotocopy', 'ID Photocopy')
            )
        );

        if (class_exists('GoogleAddressField')) {
            $mappingArray = $this->Config()->get('fields_to_google_geocode_conversion');
            if (is_array($mappingArray) && count($mappingArray)) {
                $fields->addFieldToTab(
                    'Root.SellersDetails',
                    $geocodingField = new GoogleAddressField(
                        'SellersAddressGeocodingField',
                        _t('OrderAddress.FIND_ADDRESS', 'Find address'),
                        Session::get('SellersAddressGeocodingFieldValue')
                    )
                );
                $geocodingField->setFieldMap($mappingArray);

                $country_code = Config::inst()->get('SecondHandProduct', 'country_code');
                if ($country_code) {
                    $geocodingField->setRestrictToCountryCode($country_code);
                }
                //$geocodingField->setAlwaysShowFields(true);

            }
        }

        $fields->addFieldsToTab(
            'Root.SellersDetails',
            array(
                TextField::create('SellersAddress', 'Address'),
                TextField::create('SellersAddress2', 'Suburb'),
                TextField::create('SellersCity', 'City/Town'),
                TextField::create('SellersPostalCode', 'Postal Code'),
                TextField::create('SellersRegionCode', 'Region Code'),
                TextField::create('SellersCountry', 'Country'),
            )
        );
        //add all fields to the main tab
        $fields->addFieldToTab(
            'Root.SellersDetails',
            EcommerceCMSButtonField::create(
                'PrintView',
                $this->getPrintLink(),
                'Print Details',
                $newWindow = true
            )
        );
        if ($this->BasedOnID) {
            $list = Config::inst()->get('SecondHandProduct', 'seller_summary_detail_fields');
            $labels = $this->FieldLabels();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            foreach ($list as $listField) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $fields->replaceField(
                    $listField,
                    ReadonlyField::create(
                        $listField,
                        $fields->dataFieldByName($listField)->Title()
                    )
                );
            }
            $fields->removeByName('SellersAddressGeocodingField');
        }
        $fields->addFieldToTab(
            'Root.Categorisation',
            $categoriesTable = $this->getProductGroupsTableField()
        );

        // If the product has been sold all fields should be disabled
        // Only the shop administrator is allowed to undo this.
        if ($this->HasBeenSold()) {
            $fields = $fields->makeReadonly();
            $fields->replaceField($categoriesTable->Name, $categoriesTable);
            $categoriesTable->setConfig(GridFieldConfig_RecordViewer::create());
            $fields->replaceField(
                'EnquiresList',
                GridField::create(
                    'EnquiresList',
                    'Enquiries List',
                    $this->PageEnquiries(),
                    GridFieldConfig_RecordViewer::create()
                )
            );
        }

        if ($this->HasBeenSold() && Permission::check('ADMIN')) {
            $fields->replaceField('AllowPurchase', CheckboxField::create('AllowPurchase', '<strong>Allow product to be purchased</strong>'));
            $fields->replaceField('DateItemWasSold', DateField::create('DateItemWasSold', 'Date this item was sold'));
        }

        return $fields;
    }

    public function getPrintLink()

    {
        return $this->link('printview');
    }

    public function CMSEditLink()
    {
        return Controller::join_links(
            singleton('SecondHandProductAdmin')->Link(),
            $this->ClassName,
            'EditForm',
            'field',
            $this->ClassName,
            'item',
            $this->ID,
            'edit'
        );
    }

    public function getSettingsFields()

    {
        $fields = parent::getSettingsFields();
        $fields->removeByName('ParentID');
        return $fields;
    }

    public function canPurchase(Member $member = null, $checkPrice = true)
    {
        if ($this->HasBeenSold()) {
            return false;
        }
        $embargoDays = Config::inst()->get('SecondHandProduct', 'embargo_number_of_days');
        if (intval($embargoDays) > 0) {
            if ($this->DateItemWasBought) {
                $date = $this->DateItemWasBought;
            } else {
                $date = $this->Created;
            }
            $createdDate = strtotime($date);
            $daysOld = (time() - $createdDate) / (60 * 60 * 24);
            if ($daysOld <= $embargoDays) {
                return false;
            }
        }
        return parent::canPurchase($member, $checkPrice);
    }

    public function HasBeenSold()
    {
        if (parent::HasBeenSold()) {
            return true;
        }
        if ($this->DateItemWasSold) {

            return true;
        }
        return false;
    }

    public function onBeforeWrite()
    {
        if ($this->BasedOnID) {
            $basedOn = $this->BasedOn();
            if ($basedOn && $basedOn->exists()) {
                $list = Config::inst()->get('SecondHandProduct', 'seller_summary_detail_fields');
                foreach ($list as $field) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    $this->$field = $basedOn->$field;
                }
            }
        }
        $list = Config::inst()->get('SecondHandProduct', 'seller_summary_detail_fields');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //set the IternatlItemID if it doesn't already exist
        if (! $this->InternalItemID) {
            //todo - this may need improvement
            $this->InternalItemID = "S-H-".strtoupper(substr(md5(microtime()), rand(0, 26), 5));
        }
        $this->URLSegment = $this->generateURLSegment($this->Title."-".$this->InternalItemID);

        if ($this->Title && strlen($this->MetaDescription) < 30) {
            $this->MetaDescription = "Second Hand Product: " . $this->Title;
        }

        // Save the date when the product was sold.
        if ($this->HasBeenSold()) {
            if (! $this->DateItemWasSold) {
                $this->DateItemWasSold = SS_Datetime::now()->Rfc2822();
            }
        }
        parent::onBeforeWrite();
    }

    public function SecondHandProductQualityPercentage()
    {
        return $this->ProductQuality * 10;
    }

    public function InternalItemIDNice()

    {
        return $this->InternalItemID;
    }

    public function providePermissions()
    {
        $perms[EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_code')] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'name' => EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_title'),
            'category' => 'E-commerce',
            'help' => EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_permission_help'),
            'sort' => 250,
        );
        return $perms;
    }

    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $permissionProviderFactory = Injector::inst()->get('PermissionProviderFactory');
        $member = $permissionProviderFactory->CreateDefaultMember(
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_user_email'),
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_user_firstname'),
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_user_surname'),
            EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_user_password')
        );
        $permissionProviderFactory->CreateGroup(
            $code = EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_group_code'),
            $name = EcommerceConfig::get('SecondHandProduct', 'second_hand_admin_group_name'),
            $parentGroup = null,
            $permissionCode = EcommerceConfig::get(
                'SecondHandProduct',
                'second_hand_admin_permission_code'
            ),
            $roleTitle = EcommerceConfig::get(
                'SecondHandProduct',
                'second_hand_admin_permission_title'
            ),
            $permissionArray = array(
                'SITETREE_VIEW_ALL',
                'CMS_ACCESS_SecondHandProductAdmin',
            ),
            $member
        );
    }

    public function onAferSubmit($order)
    {
        DB::query('Update \"Product\" SET AllowPurchase = 0 WHERE \"Product\".\"ID\" = '.$this->ID);
        DB::query('Update \"Product_Live\" SET AllowPurchase = 0 WHERE \"Product_Live\".\"ID\" = '.$this->ID);
        $this->writeToStage('Stage');
        $this->doPublish();
    }


    /**
     * adds created as a summary field as we are sorting by created
     * @return array
     */
    public function summaryFields()
    {
        $fields = parent::summaryFields();
        $fields['CreatedNice'] = 'Entered';
        return $fields;
    }


    public function populateDefaults()
    {
        parent::populateDefaults();
        if (! $this->DateItemWasBought) {
            $this->DateItemWasBought = SS_Datetime::now()->Rfc2822();
        }
    }


    public function getCreatedNice()
    {
        if ($this->DateItemWasBought) {
            $date = $this->DateItemWasBought;
        } else {
            $date = $this->Created;
        }
        return $date.' = '.DBField::create_field('Date', $date)->Ago();
    }
}

class SecondHandProduct_Controller extends Product_Controller
namespace YourVendor;

class YourClass { }
{
    private static $fields_to_remove_from_print = array(
        'CUS',
        'SPC',
        'MGP',
        'ZOR',
        'FPS',
        'SPE',
        'IOS',
        'PRO',
        'FER',
        'POA',
        'PHT',
        'NotForSaleMessage',
        'KeepRecordEvenThoughItIsNotForSale'
    );

    private static $allowed_actions = array(

        'printview' => true
    );

    public function printview()

    {
        if (!Permission::check('CMS_ACCESS_SECOND_HAND_PRODUCTS')) {
            return Security::permissionFailure($this, 'You do not have access to this feature, please login first.');
        }
        return $this->renderWith('SecondHandProduct_printview');
    }

    public function ListOfFieldsForPrinting()
    {
        $al = ArrayList::create();
        $fieldsWeNeed = $this->dataRecord->stat('db');
        $labels = $this->FieldLabels();
        foreach ($fieldsWeNeed as $fieldKey => $useless) {
            if (in_array($fieldKey, self::$fields_to_remove_from_print)) {
                unset($fieldsWeNeed[$fieldKey]);
            } else {
                $fieldsWeNeed[$fieldKey] = $labels[$fieldKey];
            }
        }
        $fields = $this->dataRecord->db();
        foreach ($fieldsWeNeed as $key => $description) {
            if (isset($fields[$key])) {
                $type = preg_replace('/\(.*\)/', '', $fields[$key]);
                $dbField = DBField::create_field($type, $this->$key);
                if ($dbField->hasMethod('Nice')) {
                    $value = $dbField->Nice();
                } else {
                    $value = $dbField->Raw();
                }
            } else {
                $value = "";
            }
            $al->push(
                ArrayData::create(
                    array(
                        'Key' => $description,
                        'Value' => $value
                    )
                )
            );
        }
        return $al;
    }
}


GitHub Access Token became invalid

Push — master ( bee3fd...584b84 )

SecondHandProduct::onBeforeWrite() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1			<?php
2
3
4			class SecondHandProduct extends Product implements PermissionProvider
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $can_be_root = false;
			0 ignored issues – show Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$can_be_root` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7
8			/**
9			* halt purchase for ... number of days
10			* from the day of creation.
11			* @var int
12			*/
13			private static $embargo_number_of_days = 0;
			0 ignored issues – show Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$embargo_number_of_days` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14
15			/**
16			* Restrict GoogleAddressField to a specific Country
17			* E.g. for New Zealand, $country_code = 'NZ'
18			* @var string
19			*/
20			private static $country_code = null;
			0 ignored issues – show Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$country_code` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21			/**
22			* stadard SS declaration
23			* @var Array
24			*/
25			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:12 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26			'PurchasePrice' => 'Currency',
27			'ProductQuality' => 'ENUM("1, 2, 3, 4, 5, 6, 7, 8, 9, 10","10")',
28			'IncludesBoxOrCase' => "ENUM('No, Box, Case, Both','No')",
29			'SellingOnBehalf' => 'Boolean',
30			'OriginalManual' => 'Boolean',
31			'DateItemWasBought' => 'Date',
32			'DateItemWasSold' => 'Date',
33			'SerialNumber' => 'VarChar(50)',
34			'SellersName' => 'VarChar(50)',
35			'SellersPhone' => 'VarChar(30)',

sunnysideup / silverstripe-ecommerce_second_hand_product

GitHub Access Token became invalid

Push — master ( bee3fd...584b84 )

SecondHandProduct::onBeforeWrite() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like