SecondHandProductGroup

Complexity

Total Complexity

15

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	getCMSFields()	0	11	1
B	onBeforeWrite()	0	20	6
A	hasOtherSecondHandProductGroupsOnThisLevel()	0	11	3
A	BestRootParentPage()	0	12	2
A	getBuyableClassName()	0	4	1

<?php


class SecondHandProductGroup extends ProductGroup

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'RootParent' => 'Boolean'
    );

    private static $allowed_children = array(

The property $allowed_children is not used and could be removed.

        'SecondHandProductGroup',
        'SecondHandProduct'
    );

    private static $icon = 'ecommerce_second_hand_product/images/treeicons/SecondHandProductGroup';

Consider using a different property name as you override a private property of the parent class.

The property $icon is not used and could be removed.

    /**
     * Standard SS variable.
     */
    private static $singular_name = 'Second Hand Product Holder';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = 'Second Hand Product Holders';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $description = 'A product category page specifically for second had products';

Consider using a different property name as you override a private property of the parent class.

The property $description is not used and could be removed.

    public function getCMSFields() {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab(
            'Root.SecondHand',
            CheckboxField::create(
                'RootParent',
                _t('SecondHandProductGroup.LANDING_PAGE', 'Landing Page')
            )
        );
        return $fields;
    }

    /**
     * Event handler called before writing to the database.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if($this->ParentID) {
            $parent = SiteTree::get()->byID($this->ParentID);
            if($parent) {
                if($parent instanceof SecondHandProductGroup) {
                    $this->RootParent = false;
                } else {
                    if(! $this->hasOtherSecondHandProductGroupsOnThisLevel()) {
                        $this->RootParent = true;
                    }
                }
            }
        } else {
            if( ! $this->hasOtherSecondHandProductGroupsOnThisLevel()) {
                $this->RootParent = true;
            }
        }
    }

    /**
     * Level is within SiteTree hierarchy
     * @return boolean
     */
    protected function hasOtherSecondHandProductGroupsOnThisLevel()
    {
        if(!$this->ParentID) {
            $this->ParentID = 0;
        }
        return SecondHandProductGroup::get()
            ->filter(array('ParentID' => $this->ParentID))
            ->exclude(array('ID' => $this->ID))
            ->count() > 0 ? true : false;

    }

    /**
     * @return SecondHandProductGroup
     */
    function BestRootParentPage()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $obj = DataObject::get_one(
            'SecondHandProductGroup',
            array('RootParent' => 1)
        );
        if($obj) {
            return $obj;
        } else {
            return SecondHandProductGroup::get()->first();
        }
    }

    /**
     * Returns the class we are working with.
     *
     * @return string
     */
    protected function getBuyableClassName()
    {
        return 'SecondHandProduct';
    }

}

class SecondHandProductGroup_Controller extends ProductGroup_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'SearchSecondHandProducts',
        'search'
    );

    public function init()
    {
        Config::inst()->update(
            'ProductGroup',
            'base_buyable_class',
            'SecondHandProduct'
        );
        parent::init();
        $this->showFullList = true;
    }

    public function SearchSecondHandProducts()

SearchSecondHandProducts uses the super-global variable $_GET which is generally not recommended.

    {
        $fields = new FieldList(
            new TextField('searchterm', 'Keyword', isset($_GET['searchterm']) ? $_GET['searchterm'] : '')
        );
        $actions = new FieldList(
            new FormAction('doSearchSecondHandProducts', 'Search')
        );
        $validator = new RequiredFields('searchterm');
        $form = Form::create($this, 'SearchSecondHandProducts', $fields, $actions, $validator);
        $form->setFormMethod('GET');
        $form->disableSecurityToken();

        return $form;
    }

    public function doSearchSecondHandProducts($data, $form)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $page = SecondHandProductGroup::get()->first();
        if ($page) {
            return $this->redirect($this->link('search').'?searchterm='.$data['searchterm']);
        }
    }

    public function search($request)
    {
        $term = Convert::raw2sql($request->param('searchterm'));

$term is not used, you could remove the assignment.

    }

    public function HasSearchFilterAndSort()
    {
        return true;
    }
}