UpdateSecondHandProduct

Complexity

Total Complexity

15

Size/Duplication

Total Lines	75
Duplicated Lines	25.33 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	7	2
A	unpublish()	0	11	3
A	archive()	0	14	3
B	MyPermissionCheck()	19	19	7

<?php


class UpdateSecondHandProduct extends Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'unpublish' => '->MyPermissionCheck',
        'archive' => '->MyPermissionCheck'
    );


    /**
     * make the page less easy to access
     * (but still accessible)
     * - code => ip address
     * @var string
     */
    private static $secret_codes = array();

The property $secret_codes is not used and could be removed.

    function init()

It is generally recommended to explicitly declare the visibility for methods.

    {
        parent::init();
        if(! $this->MyPermissionCheck()) {
            die('you do not have access');

The method init() contains an exit expression.

        }
    }

    function unpublish($request)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $otherID = $request->param("OtherID");
        if(isset($otherID)) {
            $internalItemID = Convert::raw2sql($otherID);
            $secondHandProduct = SecondHandProduct::get()->filter(['internalItemID' => $internalItemID])->first();
            if($secondHandProduct){
                $secondHandProduct->deleteFromStage('Live');
            }
        }
    }

    function archive($request)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $otherID = $request->param("OtherID");
        if(isset($otherID)) {
            $internalItemID = Convert::raw2sql($otherID);
            $secondHandProduct = SecondHandProduct::get()->filter(['internalItemID' => $internalItemID])->first();
            if (is_a($secondHandProduct, Object::getCustomClass('SiteTree'))) {
                $secondHandProduct->deleteFromStage('Live');
                $secondHandProduct->deleteFromStage('Stage');
            } else {
                $secondHandProduct->delete();
            }
        }
    }

    /**
     * @return Boolean

Should the return type not be boolean|string|null?

     */
    function MyPermissionCheck()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $codesWithIPs = $this->Config()->get('secret_codes');

        //with a code you do not have to be logged in ...
        if(count($codesWithIPs)) {
            $ip = EcommerceCountry::get_ip();
            $code = $this->request->param('ID');
            if($code) {
                $testIP = isset($codesWithIPs[$code]) ? $codesWithIPs[$code] : false;
                if($testIP) {
                    if($testIP === $ip || $testIP === '*') {
                        return true;
                    }
                }
            }
        }
        return Permission::check('ADMIN');
    }
}