ControllerPermissionChecker

Complexity

Total Complexity

7

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	permissionCheck()	0	15	7

<?php

class ControllerPermissionChecker extends Controller {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * checks that the url is contains the secret code and is coming from the correct IP address (if not set to wildcard)
     * @var array $codesWithIPs
     * @var array $code - ID parameter in URL
     * @return Boolean

Should the return type not be boolean|string|null?

     */
    public static function permissionCheck($codesWithIPs, $code) {
        //with a code you do not have to be logged in ...
        if(count($codesWithIPs)) {
            $ip = EcommerceCountry::get_ip();
            if($code) {

The expression $code of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $testIP = isset($codesWithIPs[$code]) ? $codesWithIPs[$code] : false;
                if($testIP) {
                    if($testIP === $ip || $testIP === '*') {
                        return true;
                    }
                }
            }
        }
        return Permission::check('ADMIN');
    }

}