ControllerPermissionChecker::permissionCheck() - Code Metrics - sunnysideup/silverstripe-ecommerce_second_hand_product - Measure and Improve Code Quality continuously with Scrutinizer

ControllerPermissionChecker::permissionCheck() B
last analyzed 2018-06-20 01:12 UTC

↳ Parent: ControllerPermissionChecker

Complexity

Conditions	7
Paths	7

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	8.2222
c	0
b	0
f	0
cc	7
eloc	9
nc	7
nop	2

<?php

class ControllerPermissionChecker extends Controller
namespace YourVendor;

class YourClass { }
{


    /**
     * checks that the url is contains the secret code and is coming from the correct IP address (if not set to wildcard)
     * @var array $codesWithIPs
     * @var array $code - ID parameter in URL
     * @return Boolean

     */
    public static function permissionCheck($codesWithIPs, $code)
    {
        //with a code you do not have to be logged in ...
        if (count($codesWithIPs)) {
            $ip = EcommerceCountry::get_ip();
            if ($code) {

                $testIP = isset($codesWithIPs[$code]) ? $codesWithIPs[$code] : false;
                if ($testIP) {
                    if ($testIP === $ip || $testIP === '*') {
                        return true;
                    }
                }
            }
        }
        return Permission::check('ADMIN');
    }
}


1			<?php
2
3			class ControllerPermissionChecker extends Controller
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-31 03:15 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6
7			/**
8			* checks that the url is contains the secret code and is coming from the correct IP address (if not set to wildcard)
9			* @var array $codesWithIPs
10			* @var array $code - ID parameter in URL
11			* @return Boolean
			0 ignored issues – show Documentation introduced 2018-01-31 03:15 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
12			*/
13			public static function permissionCheck($codesWithIPs, $code)
14			{
15			//with a code you do not have to be logged in ...
16			if (count($codesWithIPs)) {
17			$ip = EcommerceCountry::get_ip();
18			if ($code) {
			0 ignored issues – show Bug Best Practice introduced 2018-01-31 03:15 UTC by Report Bug Copy Issue Report The expression `$code` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
19			$testIP = isset($codesWithIPs[$code]) ? $codesWithIPs[$code] : false;
20			if ($testIP) {
21			if ($testIP === $ip \|\| $testIP === '*') {
22			return true;
23			}
24			}
25			}
26			}
27			return Permission::check('ADMIN');
28			}
29			}
30

sunnysideup / silverstripe-ecommerce_second_hand_product

GitHub Access Token became invalid

ControllerPermissionChecker::permissionCheck() B last analyzed 2018-06-20 01:12 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ControllerPermissionChecker::permissionCheck() B
last analyzed 2018-06-20 01:12 UTC