View GitHub Repository silverstripe-ecommerce_reports

Schedule Inspection
Subscribe

Code Duplication    Length = 4-4 lines in 4 locations

code/reports/SearchableOrderReport.php 2 locations

@@ 129-132 (lines=4) @@
126 
                            $where[] = implode(" OR ", $subWhere);
127 
                        }
128 
                        break;
129 
                    case "HasMinimumPayment":
130 
                        $having[] = ' RealPayments > '.intval($value);
131 
                        $humanWhere[] = ' Real Payment of at least '.$this->currencyFormat($value);
132 
                        break;
133 
                    case "HasMaximumPayment":
134 
                        $having[] = ' RealPayments < '.intval($value);
135 
                        $humanWhere[] = ' Real Payment of no more than '.$this->currencyFormat($value);
@@ 133-136 (lines=4) @@
130 
                        $having[] = ' RealPayments > '.intval($value);
131 
                        $humanWhere[] = ' Real Payment of at least '.$this->currencyFormat($value);
132 
                        break;
133 
                    case "HasMaximumPayment":
134 
                        $having[] = ' RealPayments < '.intval($value);
135 
                        $humanWhere[] = ' Real Payment of no more than '.$this->currencyFormat($value);
136 
                        break;
137 
                    //this has been included for SearchableProductSalesReport
138 
                    case "Product":
139 
                        $where[] = " IF(ProductVariationsForVariations.Title IS NOT NULL, CONCAT(ProductSiteTreeForVariations.Title,' : ', ProductVariationsForVariations.Title), IF(SiteTreeForProducts.Title IS NOT NULL, SiteTreeForProducts.Title, OrderAttribute.ClassName)) LIKE '%".$value."%'";

code/reports/SearchablePaymentReport.php 2 locations

@@ 119-122 (lines=4) @@
116 
                            $where[] = implode(" OR ", $subWhere);
117 
                        }
118 
                        break;
119 
                    case "HasMinimumPayment":
120 
                        $having[] = ' Amount > '.intval($value);
121 
                        $humanWhere[] = ' Payment of at least '.$this->currencyFormat($value);
122 
                        break;
123 
                    case "HasMaximumPayment":
124 
                        $having[] = ' Amount < '.intval($value);
125 
                        $humanWhere[] = ' Payment of no more than '.$this->currencyFormat($value);
@@ 123-126 (lines=4) @@
120 
                        $having[] = ' Amount > '.intval($value);
121 
                        $humanWhere[] = ' Payment of at least '.$this->currencyFormat($value);
122 
                        break;
123 
                    case "HasMaximumPayment":
124 
                        $having[] = ' Amount < '.intval($value);
125 
                        $humanWhere[] = ' Payment of no more than '.$this->currencyFormat($value);
126 
                        break;
127 
                    default:
128 
                     break;
129 
                }