PaymentsReport::getReportField() - Code Metrics - sunnysideup/silverstripe-ecommerce_reports - Measure and Improve Code Quality continuously with Scrutinizer

PaymentsReport::getReportField() A
last analyzed 2018-03-20 01:10 UTC

↳ Parent: PaymentsReport

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	52
rs	9.4929
c	0
b	0
f	0
cc	1
eloc	26
nc	1
nop	0

How to fix Long Method

<?php
/**
 * @author Nicolaas [at] sunnysideup.co.nz
 * @package ecommercextras
 */
class PaymentsReport extends SS_Report
namespace YourVendor;

class YourClass { }
{
    protected $title = 'All Payments';

    protected static $payment_array = array();

    protected $description = 'Show all payments';

    /**
     * Return a {@link ComplexTableField} that shows
     * all Order instances that are not printed. That is,
     * Order instances with the property "Printed" value
     * set to "0".
     *
     * @return ComplexTableField
     */
    public function getReportField()
    {
        // Get the fields used for the table columns
        $fields = array(
            'Created' => 'Time',
            'Amount' => 'Amount',
            'Currency' => 'Currency',
            'Message' => 'Note',
            'IP' => 'Purchaser IP',
            'ProxyIP' => 'Purchaser Proxy'
        );
        $fields['ChangeStatus'] = '';

        $table = new TableListField(
            'Payments',
            'Payment',
            $fields
        );

        // Customise the SQL query for Order, because we don't want it querying
        // all the fields. Invoice and Printed are dummy fields that just have some
        // text in them, which would be automatically queried if we didn't specify
        // a custom query.

        $table->setCustomQuery($this->getCustomQuery());

        // Set the links to the Invoice and Print fields allowing a user to view
        // another template for viewing an Order instance
        $table->setFieldFormatting(array(
            'ChangeStatus' => '<a href=\"#\" class=\"statusDropdownChange\" rel=\"$ID\">$Status</a><span class=\"outcome\"></span>'
        ));

        $table->setFieldCasting(array(
            'Amount' => 'Currency->Nice'
        ));

        $table->setPermissions(array(
            'edit',
            'show',
            'export',
        ));
        $table->setPageSize(250);


        $table->setFieldListCsv($this->getExportFields());

        $table->setCustomCsvQuery($this->getExportQuery());

        //$tableField->removeCsvHeader();


        return $table;
    }

    public function getCustomQuery()

    {
        if ("PaymentsReport" == $this->class) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //user_error('Please implement getCustomQuery() on ' . $this->class, E_USER_ERROR);

        } else {
            //buildSQL($filter = "", $sort = "", $limit = "", $join = "", $restrictClasses = true, $having = "")

            $query = singleton('Payment')->buildSQL('', 'Payment.Created DESC');
            $query->groupby[] = 'Payment.ID';
            return $query;
        }
    }

    public function getExportFields()
    {
        if ("PaymentsReport" == $this->class) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //user_error('Please implement getExportFields() on ' . $this->class, E_USER_ERROR);

        } else {
            return array("Order.ID" => "Order ID", "Order.Total" => "Order Total");
        }
    }

    public function getExportQuery()

    {
        if ("PaymentsReport" == $this->class) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //user_error('Please implement getExportFields() on ' . $this->class, E_USER_ERROR);

        } else {
            $query = singleton('Payment')->buildSQL('', 'Payment.Created DESC');
            $query->groupby[] = 'Payment.ID';
            return $query;
        }
    }

    protected function statistic($type)

    {
        if (!count(self::$payment_array)) {
            $data = $this->getCustomQuery()->execute();
            if ($data) {
                $array = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                foreach ($data as $row) {
                    if ($row["Amount"] && $row["Status"] == "Success") {
                        self::$payment_array[] = $row["Amount"];
                    }
                }
            }
        }
        if (count(self::$payment_array)) {
            switch ($type) {
                case "count":
                    return count(self::$payment_array);
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                case "sum":
                    return array_sum(self::$payment_array);
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                case "avg":
                    return array_sum(self::$payment_array) / count(self::$payment_array);
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                case "min":
                    asort(self::$payment_array);
                    foreach (self::$payment_array as $item) {
                        return $item;
                    }
                    break;
                case "max":
                    arsort(self::$payment_array);
                    foreach (self::$payment_array as $item) {
                        return $item;
                    }
                    break;
                default:
                    user_error("Wrong statistic type speficied in PaymentsReport::statistic", E_USER_ERROR);
            }
        }
        return -1;
    }

    public function processform()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ("PaymentsReport" == $this->class) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //user_error('Please implement processform() on ' . $this->class, E_USER_ERROR);

        } else {
            die($_REQUEST);

        }
    }


    protected function currencyFormat($v)

    {
        $c = new Currency("currency");

        $c->setValue($v);
        return $c->Nice();
    }
}

class PaymentsReport_Handler extends Controller
namespace YourVendor;

class YourClass { }
{
    public function processform()

    {
        $ClassName = Director::URLParam("ID");

        $object = new $ClassName;
        return $object->processform();
    }


    public function setstatus()

    {
        $id = $this->urlParams['ID'];
        if (!is_numeric($id)) {
            return "could not update payment status";
        }
        $payment = DataObject::get_by_id('Payment', $id);
        if ($payment) {
            $oldStatus = $payment->Status;
            $newStatus = $this->urlParams['OtherID'];
            if ($oldStatus != $newStatus) {
                $payment->Status = $newStatus;
                $payment->write();
                $orderLog = new OrderStatusLog();
                $orderLog->OrderID = $orderLog->OrderID;
                $orderLog->Status = "Payment status changed from ".$oldStatus." to ".$newStatus.".";
                $orderLog->Note = "Payment changed from ".$oldStatus." to ".$newStatus.".";
                $orderLog->write();
            } else {
                return "no change";
            }
        } else {
            return "payment not found";
        }
        return "updated to ".$newStatus;
    }
}


1			<?php
2			/**
3			* @author Nicolaas [at] sunnysideup.co.nz
4			* @package ecommercextras
5			*/
6			class PaymentsReport extends SS_Report
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:11 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			protected $title = 'All Payments';
9
10			protected static $payment_array = array();
11
12			protected $description = 'Show all payments';
13
14			/**
15			* Return a {@link ComplexTableField} that shows
16			* all Order instances that are not printed. That is,
17			* Order instances with the property "Printed" value
18			* set to "0".
19			*
20			* @return ComplexTableField
21			*/
22			public function getReportField()
23			{
24			// Get the fields used for the table columns
25			$fields = array(
26			'Created' => 'Time',
27			'Amount' => 'Amount',
28			'Currency' => 'Currency',
29			'Message' => 'Note',
30			'IP' => 'Purchaser IP',
31			'ProxyIP' => 'Purchaser Proxy'
32			);
33			$fields['ChangeStatus'] = '';
34
35			$table = new TableListField(
36			'Payments',
37			'Payment',
38			$fields
39			);

sunnysideup / silverstripe-ecommerce_reports

PaymentsReport::getReportField() A last analyzed 2018-03-20 01:10 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

PaymentsReport::getReportField() A
last analyzed 2018-03-20 01:10 UTC