RepeatOrder - Code Metrics - Inspection of "FIXES" - sunnysideup/silverstripe-ecommerce_repeatorders - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( c22f60...21d98e )

by Nicolaas
created 2019-04-12 22:37 UTC
RepeatOrder F

↳ Parent: Project
Complexity

Total Complexity
121
Size/Duplication

Total Lines	905
Duplicated Lines	6.74 %
Coupling/Cohesion

Components	3
Dependencies	20
Importance

Changes
Metric	Value
wmc	121
lcom	3
cbo	20
dl	61
loc	905
rs	1.695
c	0
b	0
f	0
43 Methods

Rating	Name	Duplication	Size	Complexity
A	default_period_key()	0	8	3
A	set_payment_methods()	0	4	1
A	default_payment_method_key()	0	7	2
A	CanModify()	0	4	1
A	Link()	0	4	1
A	ModifyLink()	0	4	1
A	CancelLink()	0	4	1
A	DoneLink()	0	11	3
A	AutomaticallyCreatedOrders()	0	13	5
A	create_automatically_created_orders()	0	11	3
B	addAutomaticallyCreatedOrders()	0	34	10
B	createOrderFromRepeatOrder()	0	56	6
A	create_repeat_order_from_order()	0	22	5
A	TableDeliveryDay()	0	4	1
A	TablePaymentMethod()	0	7	2
A	TableStatus()	0	4	1
A	getCMSFields()	0	9	2
A	getCMSFields_add()	0	27	1
B	getCMSFields_edit()	0	87	7
A	getCMSFields_forPopup()	0	31	1
A	getCMSPreviousOrders()	0	27	1
A	getCMSProductsTable()	0	18	1
A	onBeforeWrite()	0	5	1
A	OrderItemList()	0	4	1
A	getOrderItemList()	0	16	5
A	FirstOrderDate()	0	4	1
A	getFirstOrderDate()	9	9	3
A	LastOrderDate()	0	4	1
A	getLastOrderDate()	0	15	6
A	TodaysOrderDate()	0	4	1
A	getTodaysOrderDate()	12	12	4
A	NextOrderDate()	0	4	1
A	getNextOrderDate()	12	12	4
A	FinalOrderDate()	0	4	1
A	getFinalOrderDate()	12	12	4
A	DeliverySchedule()	0	4	1
A	getDeliverySchedule()	0	7	2
C	workOutSchedule()	0	30	14
A	HasFutureOrders()	0	6	2
A	HasAnOrderToday()	0	6	2
A	canView()	0	13	4
A	canEdit()	8	8	2
A	canDelete()	8	8	2
How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class
Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.
Complex classes like RepeatOrder often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RepeatOrder, and based on these observations, apply Extract Interface, too.
<?php

/**
 * @author michael@ sunnysideup . co . nz
 */

class RepeatOrder extends DataObject
{


    /**
     * Minimum of days in the future that the order is lodged.
     * @var int
     */
    private static $minimum_days_in_the_future = 1;

    /**
     * Standard SS variable
     */
    private static $db = [

        'Status' => "Enum('Pending, Active, MemberCancelled, AdminCancelled, Finished', 'Pending')",
        //dates
        'Start' => 'Date',
        'End' => 'Date',
        'Period' => 'Varchar',
        'DeliveryDay' => 'Text',
        //payment
        'PaymentMethod' => 'Varchar',
        "CreditCardOnFile" => "Boolean",
        "PaymentNote" => "Text",
        //computed values and notes
        'ItemsForSearchPurposes' => 'Text', //FOR SEARCH PURPOSES ONLY!
        'Notes' => 'Text'
    ];

    /**
     * Standard SS variable
     */
    private static $has_one = [

        'Member' => 'Member',
        'OriginatingOrder' => 'Order'
    ];


    /**
     * Standard SS variable
     */
    private static $has_many = [

        'OrderItems' => 'RepeatOrder_OrderItem', //products & quanitites
        'Orders' => 'Order'
    ];

    /**
     * Standard SS variable.
     */
    private static $indexes = [

        "Status" => true
    ];

    /**
     * Standard SS variable
     */
    private static $casting = [

        "OrderItemList" => "Text",
        "FirstOrderDate" => "Date",
        "LastOrderDate" => "Date",
        "TodaysOrderDate" => "Date",
        "NextOrderDate" => "Date",
        "FinalOrderDate" => "Date",
        "DeliverySchedule" => "Text"
    ];


    /**
     * Standard SS variable
     */
    private static $searchable_fields = [

        "ItemsForSearchPurposes" => "PartialMatchFilter",
        "Period" => "ExactMatchFilter",
        "DeliveryDay" => "ExactMatchFilter",
        "Status" => "ExactMatchFilter"
    ];

    /**
     * Standard SS variable
     */
    private static $summary_fields = [

        'ID' => 'Repeat Order ID',
        'Member.Surname' => 'Surname',
        'Member.Email' => 'Email',
        'OrderItemList' => 'Order Item List',
        'Start' => 'Start',
        'End' => 'End',
        'Period' => 'Period',
        'DeliveryDay' => 'Delivery Day',
        'Status' => 'Status'
    ];

    /**
     * Standard SS variable
     */
    private static $default_sort = 'Created DESC';



    /**
     * Dropdown options for Period
     * @var array 'strtotime period' > 'nice name'
     */
    private static $period_fields = [
        '1 day' => 'Daily',
        '1 week' => 'Weekly',
        '2 weeks' => 'Fornightly',
        '1 month' => 'Monthly'
    ];

    public static function default_period_key()
    {
        if ($a = Config::inst()->get('RepeatOrder', 'period_fields')) {
            foreach ($a as $k => $v) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                return $k;
            }
        }
    }

    /**
     * @var Array
     */
    private static $schedule = [];


    /**
     * @array
     */
    private static $status_nice = array(
        'Pending' => 'Pending',
        'Active' => 'Active',
        'MemberCancelled' => 'Pending Cancellation',
        'AdminCancelled' => 'Cancelled',
        'Finished' => 'Finished',
    );


    /**
     * @var array
     */
    protected static $payment_methods = array(
        'DirectCreditPayment' => 'Direct Credit (payment into bank account)'
    );
    public static function set_payment_methods($a)
    {
        self::$payment_methods = $a;
    }

    public static function default_payment_method_key()
    {
        $a = Config::inst()->get('RepeatOrder', 'payment_methods');
        foreach ($a as $k => $v) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            return $k;
        }
    }

    /**
     * Can it be edited, alias for canEdit
     * @return Boolean
     */
    public function CanModify($member = null)

    {
        return $this->canEdit();
    }

    /**
     * Link for viewing
     * @return String
     */
    public function Link()
    {
        return RepeatOrdersPage::get_repeat_order_link('view', $this->ID);
    }

    /**
     * Link for editing
     * @return String
     */
    public function ModifyLink()
    {
        return RepeatOrdersPage::get_repeat_order_link('modify', $this->ID);
    }


    /**
     * Link for cancelling
     * @return String
     */
    public function CancelLink()
    {
        return RepeatOrdersPage::get_repeat_order_link('cancel', $this->ID);
    }

    /**
     * Link for end of view / edit / cancel session
     * @return String
     */
    public function DoneLink()
    {
        $page = DataObject::get_one("RepeatOrdersPage");
        if (!$page) {
            $page = DataObject::get_one("CheckoutPage");
            if (!$page) {
                $page = DataObject::get_one("Page");
            }
        }
        return $page->Link();
    }

    /**
     * returns a list of actual orders that have been created from this repeat order.
     * @return DOS | Null

     */
    public function AutomaticallyCreatedOrders()
    {
        $orders = Order::get()->filter(["RepeatOrderID" => $this->ID])->sort(["OrderDate" => "ASC"]);
        $dos = ArrayList::create();
        if ($orders) {
            foreach ($orders as $order) {
                $dos->push($order);
            }
        }
        if ($dos && $dos->count()) {
            return $dos;
        }
    }

//====================================================================================================================================================================================

    /**
     * Create due draft orders
     */
    public static function create_automatically_created_orders()
    {
        set_time_limit(0); //might take a while with lots of orders
        //get all Repeat orders
        $repeatOrders = RepeatOrder::get()->filter(['Status' => 'Active']);
        if ($repeatOrders) {
            foreach ($repeatOrders as $repeatOrder) {
                $repeatOrder->addAutomaticallyCreatedOrders();
            }
        }
    }


    /**
     * adds the orders that
     */
    public function addAutomaticallyCreatedOrders()
    {
        //current time + period is less than LastCreated and less then end
        $today = (strtotime(date('Y-m-d')));
        $firstOrderDate = $this->FirstOrderDate();
        if ($firstOrderDate) {
            $startTime = strtotime($firstOrderDate->format("Y-m-d"));
        }
        if (!$firstOrderDate) {
            $this->Status = 'Pending';

            $this->write();
            return;
        } else {
            $endTime = strtotime($this->dbObject("End")->format("Y-m-d"));
            if ($today > $endTime) {
                $this->Status = 'Finished';

                $this->write();
                return;
            } elseif ($startTime < $today) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $a = $this->workOutSchedule();
                if (count($a)) {
                    foreach ($a as $orderDateInteger => $orderDateLong) {
                        if (!$this->MemberID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            USER_ERROR("Can not create Order without member linked in RepeatOrder #".$this->ID, E_USER_ERROR);
                        } elseif (!$orderDateInteger) {
                            USER_ERROR("Can not create Order without date for in RepeatOrder #".$this->ID, E_USER_ERROR);
                        } elseif ($orderDateInteger <= $today) {
                            $this->createOrderFromRepeatOrder($orderDateInteger);
                        }
                    }
                }
            }
        }
    }


    /**
     * creates order from repeatorder for a specific day.
     * IF it does not already exists.
     *
     */
    protected function createOrderFromRepeatOrder($orderDateInteger)
    {
        $order = Order::get()
            ->filter(["OrderDateInteger" => $orderDateInteger, "RepeatOrderID" => $this->ID])
            ->first();
        if ($order) {
            //do nothing
        } else {
            $order = Order::create();
            $order->OrderDate = date("Y-m-d", $orderDateInteger);
            $order->OrderDateInteger = $orderDateInteger;
            $order->RepeatOrderID = $this->ID;
            $order->MemberID = $this->MemberID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $order->CustomerOrderNote = "Created as part of a repeating order.";
            $order->write();
            if ($this->OrderItems()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                foreach ($this->OrderItems() as $repeatOrderOrderItem) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    $product = Product::get()->byID($repeatOrderOrderItem->ProductID);
                    if ($product) {
                        //START CHECK AVAILABILITY
                        // if (class_exists("ProductStockCalculatedQuantity")) {
                        //     $numberAvailable = ProductStockCalculatedQuantity::get_quantity_by_product_id($product->ID);
                        //     if ($numberAvailable < $repeatOrderOrderItem->Quantity) {
                        //         $alternatives = $repeatOrderOrderItem->AlternativesPerProduct();
                        //         $product = null;
                        //         if ($dos) {
                        //             foreach ($alternatives as $alternative) {
                        //                 $stillLookingForAlternative = true;
                        //                 $numberAvailable = ProductStockCalculatedQuantity::get_quantity_by_product_id($alternative->ID);
                        //                 if ($numberAvailable > $repeatOrderOrderItem->Quantity && $stillLookingForAlternative) {
                        //                     $stillLookingForAlternative = false;
                        //                     $product = $alternative;
                        //                 }
                        //             }
                        //         }
                        //     }
                        // }
                        //END CHECK AVAILABILITY
                        if ($product) {
                            $newProductOrderItem = Product_OrderItem::create();
                            $newProductOrderItem->addBuyableToOrderItem($product, $repeatOrderOrderItem->Quantity);
                            $newProductOrderItem->OrderID = $order->ID;
                            $newProductOrderItem->write();
                        }
                    } else {
                        USER_ERROR("Product does not exist", E_USER_WARNING);
                    }
                }
            } else {
                USER_ERROR("There are no order items", E_USER_WARNING);
            }
            //FINALISE!!!
            $order->write();
            $order->tryToFinaliseOrder();
        }
    }


/**
     * Create a RepeatOrder from a regular Order and its Order Items
     * @param Order $Order
     * @return RepeatOrder
     */
    public static function create_repeat_order_from_order(Order $Order)
    {
        $repeatOrder = RepeatOrder();
        $repeatOrder->Status = 'Pending';
        $repeatOrder->MemberID = $Order->MemberID;
        $repeatOrder->write();
        $orderItems = $Order->Items();
        if ($orderItems) {
            foreach ($orderItems as $orderItem) {
                $buyable = $orderItem->Buyable();
                if ($buyable && $buyable instanceof Product) {
                    $repeatOrder_orderItem = RepeatOrder_OrderItem();
                    $repeatOrder_orderItem->OrderID = $repeatOrder->ID;
                    $repeatOrder_orderItem->ProductID = $orderItem->BuyableID;
                    $repeatOrder_orderItem->Quantity = $orderItem->Quantity;
                    $repeatOrder_orderItem->write();
                }
            }
        }
        $repeatOrder->write();
        return $repeatOrder;
    }





//================================================================================================================================================================================

    /**
     * @return string
     */
    public function TableDeliveryDay()
    {
        return $this->DeliveryDay;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @return string
     */
    public function TablePaymentMethod()
    {
        if (isset(self::$payment_methods[$this->PaymentMethod])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return self::$payment_methods[$this->PaymentMethod];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return "";
    }

    /**
     * @return string
     */
    public function TableStatus()
    {
        return self::$status_nice[$this->Status];

    }


//==========================================================================================================================================================



    /**
     * CMS Fields for ModelAdmin, use different fields for adding/editing
     * @see sapphire/core/model/DataObject#getCMSFields($params)
     */
    public function getCMSFields()
    {
        if ($this->exists()) {
            $this->addAutomaticallyCreatedOrders();
            return $this->getCMSFields_edit();
        } else {
            return $this->getCMSFields_add();
        }
    }

    /**
     * CMS Fields to adding via ModelAdmin
     * @return FieldList
     */
    public function getCMSFields_add()
    {
        $fields = FieldList::create(
            TabSet::create('Root',
                Tab::create('Main',
                    ListboxField::create(
                        'PaymentMethod',
                        'Payment Method',
                        Config::inst()->get('RepeatOrder', 'payment_methods'),
                        null,
                        count(Config::inst()->get('RepeatOrder', 'payment_methods'))
                     ),
                    DateField::create('Start', 'Start'),
                    DateField::create('End', 'End (Optional)'),
                    ListboxField::create(
                        'Period',
                        'Period',
                        Config::inst()->get('RepeatOrder', 'period_fields'),
                        null,
                        count(Config::inst()->get('RepeatOrder', 'period_fields'))
                    ),
                    TextareaField::create('Notes', 'Notes')
                )
            )
        );
        return $fields;
    }

    /**
     * CMS Fields to adding via ModelAdmin
     * @return FieldList
     */
    public function getCMSFields_edit()
    {
        $firstCreated = "can not be computed";
        if ($firstCreatedObj = $this->FirstOrderDate()) {
            $firstCreated = $firstCreatedObj->Long();
        }
        $lastCreated = "no orders have been placed yet";
        if ($lastCreatedObj = $this->LastOrderDate()) {
            $lastCreated = $lastCreatedObj->Long();
        }
        $finalCreated = "can not be computed";
        if ($finalCreatedObj = $this->FinalOrderDate()) {
            $finalCreated = $finalCreatedObj->Long();
        }
        if ($this->Status == "Active") {

            $nextCreated = "can not be computed";
            if ($nextCreatedObj = $this->NextOrderDate()) {
                $nextCreated = $nextCreatedObj->Long();
            }
        } else {
            $nextCreated = "Repeat Order not active - no next date is available if the Repeat Order is not active.";
        }
        if (!$this->DeliveryDay) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $firstCreated = $finalCreated = $lastCreated = $nextCreated = "Please select a delivery day first.";
        }
        $fields = FieldList::create(
            TabSet::create(
                'Root',
                Tab::create(
                    'Main',
                    LiteralField::create(
                        'Readonly[ID]',
                        '<p>Repeat Order Number: '.$this->ID.'</p>'
                    ),
                    LiteralField::create(
                        'Readonly[Member]',
<<<HTML
    <div class="field readonly " id="Readonly[Member]">
        <label for="Form_EditForm_Readonly-Member" class="left">Member</label>
        <div class="middleColumn">
            <span class="readonly" id="Form_EditForm_Readonly-Member">{$this->Member()->getTitle()} ({$this->Member()->Email}) </span>
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            <input type="hidden" value="{$this->Member()->getTitle()} ({$this->Member()->Email})" name="Readonly[Member]"/>
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        </div>
    </div>
HTML
                    ),
                    DropdownField::create('Status', 'Status', self::$status_nice),
                    DateField::create('Start', 'Start'),
                    DateField::create('End', 'End (Optional)'),
                    ListboxField::create(
                        'Period',
                        'Period',
                        Config::inst()->get('RepeatOrder', 'period_fields'),
                        null,
                        count(Config::inst()->get('RepeatOrder', 'period_fields'))
                    ),
                    TextareaField::create('Notes', 'Notes')
                ),
                Tab::create(
                    'Products',
                    $this->getCMSProductsTable()
                ),
                Tab::create(
                    'Orders',
                    $this->getCMSPreviousOrders(),
                    ReadonlyField::create("DeliveryScheduleFormatted", "Delivery Schedule", $this->DeliverySchedule()),
                    ReadonlyField::create("FirstCreatedFormatted", "First Order", $firstCreated),
                    ReadonlyField::create("LastCreatedFormatted", "Last Order", $lastCreated),
                    ReadonlyField::create("NextCreatedFormatted", "Next Order", $nextCreated),
                    ReadonlyField::create("FinalCreatedFormatted", "Final Order", $finalCreated)
                ),
                Tab::create(
                    'Payment',
                    CheckboxField::create("CreditCardOnFile", "Credit Card on File"),
                    ListboxField::create(
                        'PaymentMethod',
                        'Payment Method',
                        Config::inst()->get('RepeatOrder', 'payment_methods'),
                        null,
                        count(Config::inst()->get('RepeatOrder', 'payment_methods'))
                    ),
                    TextareaField::create('PaymentNote', 'Payment Note')
                )
            )
        );
        return $fields;
    }

    /**
     * CMS Fields for Popup
     * @return FieldList
     */
    public function getCMSFields_forPopup()
    {
        $fields = FieldList::create(
            TabSet::create('Root',
                Tab::create('Main',
                    ReadonlyField::create('Readonly[Member]', 'Member', $this->Member()->getTitle().' ('.$this->Member()->Email.')'),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    DropdownField::create('Status', 'Status', self::$status_nice),
                    ListboxField::create(
                        'PaymentMethod',
                        'Payment Method',
                        Config::inst()->get('RepeatOrder', 'payment_methods'),
                        null,
                        count(Config::inst()->get('RepeatOrder', 'payment_methods'))
                    ),
                    DateField::create('Start', 'Start'),
                    DateField::create('End', 'End (Optional)'),
                    DropdownField::create(
                        'Period',
                        'Period',
                        Config::inst()->get('RepeatOrder', 'period_fields')
                    ),
                    TextField::create('DeliveryDay', 'Delivery Day'),
                    TextareaField::create('Notes', 'Notes')
                ),
                Tab::create('Products',
                    $this->getCMSProductsTable()
                )
            )
        );
        return $fields;
    }



    /**
     * Get previous actual order table
     * @return ComplexTableField
     */
    public function getCMSPreviousOrders()
    {
        $table = ComplexTableField::create(
            $controller = $this,
            $name = "PreviousOrders",
            $sourceClass = "Order",
            $fieldList = array(
                "Title" => "Summary",
                "Total" => "Total",
                "CustomerStatus" => "Status",
                "OrderDate" => "Planned Date",
                "RetrieveLink" => "RetrieveLink"
            ),
            $detailFormFields = null,
            $sourceFilter = "RepeatOrderID = ".$this->ID,
            $sourceSort = "OrderDateInteger DESC",
            $sourceJoin = ""
        );
        $table->setFieldCasting(array(
            'OrderDate' => 'Date->Long',
            'Total' => 'Currency->Nice'
        ));
        $table->setShowPagination(false);
        $table->setAddTitle('Previous Orders');
        $table->setPermissions(array("export", "show"));
        return $table;
    }

    /**
     * Get products table
     * @return ComplexTableField
     */
    public function getCMSProductsTable()
    {
        $table = ComplexTableField::create(
            $this,
            'OrderItems',
            'RepeatOrder_OrderItem',
            array(
                'Product.Title' => 'Title',
                'Quantity' => 'Qty',
            )
        );

        $table->setShowPagination(false);
        $table->setAddTitle('Product');
        $table->setPermissions(array('add', 'edit', 'delete'));

        return $table;
    }




//========================================================================================================================================================================================================================================================================

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->ItemsForSearchPurposes = $this->OrderItemList();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

//===========================================================================================================================================================================================

    /**
     * List of products
     *
     * @return String
     */
    public function OrderItemList()
    {
        return $this->getOrderItemList();
    }
    public function getOrderItemList()
    {
        $a = [];
        if ($list = $this->OrderItems()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            foreach ($list as $item) {
                $a[] = $item->Quantity . " x " . $item->Title();
            }
        }
        if (!count($a)) {
            return "No products listed";
        }
        if (count($a) == 1) {
            return "Product: ".implode(", ", $a).".";
        }
        return "Products: ".implode(", ", $a).".";
    }

//===========================================================================================================================================================================================

    /**
     * The first order date
     *
     * @return Date | Null

     */
    public function FirstOrderDate()
    {
        return $this->getFirstOrderDate();
    }
    public function getFirstOrderDate()

    {
        $a = $this->workOutSchedule();
        if (count($a)) {
            foreach ($a as $orderDateInteger => $orderDateLong) {
                return Date::create($className = "Date", $value = Date("Y-m-d", $orderDateInteger));
            }
        }
    }

    /**
     * Last date that an order was placed
     *
     * @return Date | Null

     */
    public function LastOrderDate()
    {
        return $this->getLastOrderDate();
    }
    public function getLastOrderDate()
    {
        $a = $this->workOutSchedule();
        $today = strtotime(Date("Y-m-d"));
        $i = 0;
        if (count($a)) {
            foreach ($a as $orderDateInteger => $orderDateLong) {
                if ($orderDateInteger > $today && $i > 0 && $previousoOrderDateInteger < $today) {
                    return Date::create($className = "Date", $value = Date("Y-m-d", $previousoOrderDateInteger));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                }
                $previousoOrderDateInteger = $orderDateInteger;
                $i++;
            }
        }
    }

    /**
     * today's' date for the order - if ANY!
     *
     * @return Date | Null

     */
    public function TodaysOrderDate()
    {
        return $this->getTodaysOrderDate();
    }
    public function getTodaysOrderDate()

    {
        $a = $this->workOutSchedule();
        $today = strtotime(Date("Y-m-d"));
        if (count($a)) {
            foreach ($a as $orderDateInteger => $orderDateLong) {
                if ($orderDateInteger == $today) {
                    return Date::create($className = "Date", $value = Date("Y-m-d", $orderDateInteger));
                }
            }
        }
    }

    /**
     * Next date (from the viewpoint of today)
     *
     * @return Date | Null

     */
    public function NextOrderDate()
    {
        return $this->getNextOrderDate();
    }
    public function getNextOrderDate()

    {
        $a = $this->workOutSchedule();
        $today = strtotime(Date("Y-m-d"));
        if (count($a)) {
            foreach ($a as $orderDateInteger => $orderDateLong) {
                if ($orderDateInteger > $today) {
                    return Date::create($className = "Date", $value = Date("Y-m-d", $orderDateInteger));
                }
            }
        }
    }


    /**
     * Last Delivery Date
     *
     * @return Date | Null

     */
    public function FinalOrderDate()
    {
        return $this->getFinalOrderDate();
    }
    public function getFinalOrderDate()

    {
        $a = $this->workOutSchedule();
        if (count($a)) {
            foreach ($a as $orderDateInteger => $orderDateLong) {
                //do nothing wait for last one...
            }
            if ($orderDateInteger) {
                return Date::create($className = "Date", $value = Date("Y-m-d", $orderDateInteger));
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
            }
        }
    }

    /**
     * List of delivery dates
     *
     * @return String

     */
    public function DeliverySchedule()
    {
        return $this->getDeliverySchedule();
    }
    public function getDeliverySchedule()
    {
        $a = $this->workOutSchedule();
        if (count($a)) {
            return implode("; ", $a);
        }
    }


    /**
     * Work out the delivery schedule
     * @return Array
     */
    protected function workOutSchedule()
    {
        //caching value for quicker response
        if (!isset(self::$schedule[$this->ID])) {
            $a = [];
            if ($this->Period && $this->End && $this->Start && $this->DeliveryDay && $this->Status == "Active") {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $startTime = strtotime($this->Start);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if (Date("l", $startTime) == $this->DeliveryDay) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    $firstTime = $startTime;
                } else {
                    $phrase = "Next ".$this->DeliveryDay;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    $firstTime = strtotime($phrase, $startTime);
                }
                $endTime = strtotime($this->End);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $nextTime = $firstTime;
                if ($firstTime && $nextTime && $endTime) {
                    if ($firstTime < $endTime) {
                        $i = 0;
                        while ($nextTime <= $endTime && $i < 999) {
                            $a[$nextTime] = Date("j F Y", $nextTime);
                            $nextTime = strtotime("+ ".$this->Period, $nextTime);

                            $i++;
                        }
                    }
                }
            }
            self::$schedule[$this->ID] = $a;
        }
        return self::$schedule[$this->ID];
    }


    /**
     * Are there any orders scheduled for the future
     * @return Boolean

     */
    public function HasFutureOrders()
    {
        if ($this->NextOrderDate()) {
            return true;
        }
    }

    /**
     * Are there any orders scheduled for today
     * @return Boolean

     */
    public function HasAnOrderToday()
    {
        if ($this->TodaysOrderDate()) {
            return true;
        }
    }

//===========================================================================================================================================================================================

    public function canView($member = null)
    {
        $member = Member::currentUser();
        if ($member) {
            if ($member->IsShopAdmin()) {
                return true;
            }
            if ($this->MemberID == $member->ID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                return true;
            }
        }
        return false;
    }

    public function canEdit($member = null)

    {
        if (in_array($this->Status, array('Pending', 'Active'))) {

            return $this->canView($member);
        } else {
            return false;
        }
    }

    public function canDelete($member = null)

    {
        if (in_array($this->Status, array('Pending'))) {

            return $this->canView($member);
        } else {
            return false;
        }
    }
}

Push — master ( c22f60...21d98e )

RepeatOrder F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

43 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

sunnysideup / silverstripe-ecommerce_repeatorders

Push — master ( c22f60...21d98e )

RepeatOrder F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

43 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
