sunnysideup /
silverstripe-ecommerce_repeatorders
| Conditions | 23 |
| Paths | 651 |
| Total Lines | 112 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 238 | public function doSave($data, $form, $request) |
||
| 239 | { |
||
| 240 | $data = Convert::raw2sql($data); |
||
| 241 | $member = Member::currentUser(); |
||
| 242 | $allowNonMembers = Config::inst()->get('RepeatOrder', 'allow_non_members'); |
||
| 243 | if (!$member && !$allowNonMembers) { |
||
| 244 | $form->sessionMessage('Could not find customer details.', 'bad'); |
||
| 245 | $this->controller->redirectBack(); |
||
| 246 | |||
| 247 | return false; |
||
| 248 | } |
||
| 249 | if ($member && $member->IsShopAdmin()) { |
||
| 250 | $form->sessionMessage('Repeat orders can not be created by Shop Administrators. Only customers can create repeat orders.', 'bad'); |
||
| 251 | $this->controller->redirectBack(); |
||
| 252 | |||
| 253 | return false; |
||
| 254 | } |
||
| 255 | if (isset($data['OrderID'])) { |
||
| 256 | |||
| 257 | $orderID = intval($data['OrderID']); |
||
| 258 | if($orderID) { |
||
| 259 | |||
| 260 | if ($member) { |
||
| 261 | $order = DataObject::get_one('Order', 'Order.ID = \''.$orderID.'\' AND MemberID = \''.$member->ID.'\''); |
||
| 262 | } |
||
| 263 | else { |
||
| 264 | $order = DataObject::get_one('Order', 'Order.ID = \''.$orderID.'\''); |
||
| 265 | } |
||
| 266 | |||
| 267 | if ($order) { |
||
| 268 | $repeatOrder = RepeatOrder::create_repeat_order_from_order($order); |
||
| 269 | if($repeatOrder) { |
||
| 270 | $repeatOrder->OriginatingOrderID = $order->ID; |
||
| 271 | $repeatOrder->write(); |
||
| 272 | |||
| 273 | $order->RepeatOrderID = $repeatOrder->ID; |
||
| 274 | $order->write(); |
||
| 275 | } else { |
||
| 276 | $form->sessionMessage('Sorry, an error occured - we could not create your subscribtion order. Please try again.', 'bad'); |
||
| 277 | $this->controller->redirectBack(); |
||
| 278 | |||
| 279 | return false; |
||
| 280 | } |
||
| 281 | } else { |
||
| 282 | $form->sessionMessage('Could not find originating order.', 'bad'); |
||
| 283 | $this->controller->redirectBack(); |
||
| 284 | |||
| 285 | return false; |
||
| 286 | } |
||
| 287 | } |
||
| 288 | } else { |
||
| 289 | $repeatOrderID = intval($data['RepeatOrderID']); |
||
| 290 | if ($member) { |
||
| 291 | $repeatOrder = DataObject::get_one('RepeatOrder', 'RepeatOrder.ID = \''.$repeatOrderID.'\' AND MemberID = \''.$member->ID.'\''); |
||
| 292 | } |
||
| 293 | else { |
||
| 294 | $repeatOrder = DataObject::get_one('RepeatOrder', 'RepeatOrder.ID = \''.$repeatOrderID.'\''); |
||
| 295 | } |
||
| 296 | |||
| 297 | } |
||
| 298 | if ($repeatOrder) { |
||
| 299 | if ($repeatOrderItems = $repeatOrder->OrderItems()) { |
||
| 300 | foreach ($repeatOrderItems as $repeatOrderItem) { |
||
| 301 | $repeatOrderItem->ProductID = $data["Product"]["ID"][$repeatOrderItem->ProductID]; |
||
| 302 | $repeatOrderItem->Quantity = $data["Product"]["Quantity"][$repeatOrderItem->ProductID]; |
||
| 303 | $altCount = Config::inst()->get('RepeatOrderForm', 'number_of_product_alternatives'); |
||
| 304 | for ($i = 1; $i <= $altCount; $i++) { |
||
| 305 | $alternativeField = "Alternative".$i."ID"; |
||
| 306 | $repeatOrderItem->$alternativeField = $data["Product"][$alternativeField][$repeatOrderItem->ProductID]; |
||
| 307 | } |
||
| 308 | $repeatOrderItem->write(); |
||
| 309 | } |
||
| 310 | } |
||
| 311 | $params = []; |
||
| 312 | if (isset($data['Start']) && strtotime($data['Start']) > strtotime(Date("Y-m-d"))) { |
||
| 313 | $params['Start'] = $data['Start']; |
||
| 314 | } else { |
||
| 315 | $params["Start"] = Date("Y-m-d"); |
||
| 316 | } |
||
| 317 | if (isset($data['End']) && strtotime($data['End']) > strtotime($params["Start"])) { |
||
| 318 | $params['End'] = $data['End']; |
||
| 319 | } |
||
| 320 | if (isset($data['Period'])) { |
||
| 321 | $params['Period'] = $data['Period']; |
||
| 322 | } else { |
||
| 323 | $data['Period'] = RepeatOrder::default_period_key(); |
||
| 324 | } |
||
| 325 | if (isset($data['PaymentMethod'])) { |
||
| 326 | $params['PaymentMethod'] = $data['PaymentMethod']; |
||
| 327 | } else { |
||
| 328 | $params['PaymentMethod'] = RepeatOrder::default_payment_method_key(); |
||
| 329 | } |
||
| 330 | if (isset($data['Notes'])) { |
||
| 331 | $params['Notes'] = $data['Notes']; |
||
| 332 | } |
||
| 333 | $repeatOrder->update($params); |
||
| 334 | $repeatOrder->Status = 'Pending'; |
||
| 335 | $repeatOrder->write(); |
||
| 336 | } else { |
||
| 337 | $form->sessionMessage('Could not find repeat order.', 'bad'); |
||
| 338 | $this->controller->redirectBack(); |
||
| 339 | |||
| 340 | return false; |
||
| 341 | } |
||
| 342 | |||
| 343 | if(!$request->isAjax()){ |
||
| 344 | $this->controller->redirect( |
||
| 345 | RepeatOrdersPage::get_repeat_order_link('view', $repeatOrder->ID) |
||
| 346 | ); |
||
| 347 | } |
||
| 348 | return true; |
||
| 349 | } |
||
| 350 | } |
||
| 351 |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.