sunnysideup / silverstripe-ecommerce_quick_add

code/AddToCartPage.php

<?php

/**
 *
 *@author nicolaas [at] sunnysideup.co.nz
 *
 **/

class AddToCartPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "ecommerce_quick_add/images/treeicons/AddToCartPage";

The property $icon is not used and could be removed.

    public function canCreate($member = null)
    {
        return AddToCartPage::get()->count() ? false : true;
    }

    private static $many_many = array(

The property $many_many is not used and could be removed.

        "ExcludedProductsAndGroups" => "SiteTree",
    );
}

class AddToCartPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        "AddMemberToCartForm" => true,
        "addmembertocartform_add" => true,
        "QuickAddToCartForm" => true,
        "quickaddtocartform_add" => true
    );

    public function init()
    {
        parent::init();
        Requirements::themedCSS('Products', 'ecommerce');
        Requirements::themedCSS('AddToCartPage', 'ecommerce_quick_add');
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

56% of this comment could be valid code. Did you maybe forget this after debugging?

        //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

62% of this comment could be valid code. Did you maybe forget this after debugging?

        Requirements::javascript(THIRDPARTY_DIR."/jquery-form/jquery.form.js");
        Requirements::javascript("ecommerce_quick_add/javascript/AddToCartPage.js");
    }

    public function AddMemberToCartForm()
    {
        $member = Member::currentUser();
        $order = ShoppingCart::current_order();
        $currentCustomer = $order->CreateOrReturnExistingMember(false);
        if ($member && $member->IsShopAdmin()) {
            $fields = new FieldList(
                new HeaderField("SelectCustomer", _t("AddToCartPage.SELECTCUSTOMER", "Select Customer")),
                new ReadonlyField("CurrentMember", _t("AddToCartPage.CURRENTCUSTOMER", "Current"), $currentCustomer->getTitle()),
                new DropdownField("MemberID", _t("AddToCartPage.CUSTOMER", "Change to"), EcommerceRole::list_of_customers(), $currentCustomer->ID)
            );
            $actions = new FieldList(
                new FormAction("addmembertocartform_add", _t("AddToCartPage.ADDMEMBERTOORDER", "Update customer"))
            );
            $validator = new RequiredFields(array("MemberID"));
            return new Form($this, "AddMemberToCartForm", $fields, $actions, $validator);
        }
    }

    public function addmembertocartform_add($data, $form)
    {
        $member = Member::currentUser();
        if ($member && $member->IsShopAdmin()) {
            $order = ShoppingCart::current_order();
            $member = Member::get()->byID(intval($data["MemberID"]));
            if ($member) {
                if ($member->ID != $order->MemberID) {
                    $order->MemberID = $member->ID;
                    $order->BillingAddressID = 0;
                    $order->ShippingAddressID = 0;
                    $order->write();
                    $response = $member->getTitle()." "._t("AddToCartPage.ADDED", "customer has been added to order.");
                    $status = "good";
                } else {
                    $response = _t("AddToCartPage.NOCHANGE", "The order has not been changed.");
                    $status = "good";
                }
            } else {
                $response = _t("AddToCartPage.CUSTOMERNOTADDED", "Customer could not be added.");
                $status = "bad";
            }
            if (Director::is_ajax()) {
                return $response;
            } else {
                $form->setMessage($response, $status);
                $this->redirectBack();
            }
        }
    }

    public function QuickAddToCartForm()
    {
        $fields = new FieldList(
            new HeaderField("SelectCustomer", _t("AddToCartPage.ADDPRODUCTS", "Add Products to your order")),
            new HiddenField("BuyableID"),
            new HiddenField("BuyableClassName"),
            new HiddenField("Version"),
            new BuyableSelectField("FindBuyable", _t("AddToCartPage.PRODUCT", "Product")),
            new NumericField("Quantity", _t("AddToCartPage.QUANTITY", "Quantity"), 1)
        );
        $actions = new FieldList(
            new FormAction("quickaddtocartform_add", _t("AddToCartPage.ADD", "Add"))
        );
        $validator = new RequiredFields(array("Quantity"));
        return new Form($this, "QuickAddToCartForm", $fields, $actions, $validator);
    }

    public function quickaddtocartform_add($data, $form)

The return type could not be reliably inferred; please add a @return annotation.

    {
        $shoppingCart = ShoppingCart::singleton();
        $buyableID = intval($data["BuyableID"]);
        $buyableClassName = Convert::raw2sql($data["BuyableClassName"]);
        $version = Intval($data["Version"]);

$version is not used, you could remove the assignment.

        $quantity = floatval($data["Quantity"]);
        $status = "bad";
        $message = _t("AddToCartPage.ERRORPRODUCTNOTADDED", "ERROR: Product Not Added - make sure to find a product first.");
        if (class_exists($buyableClassName) && EcommerceDBConfig::is_buyable($buyableClassName)) {

It seems like $buyableClassName defined by \Convert::raw2sql($data['BuyableClassName']) on line 115 can also be of type array; however, EcommerceDBConfig::is_buyable() does only seem to accept string, maybe add an additional type check?

            $buyable = $buyableClassName::get()->byID($buyableID);
            if ($buyable) {
                $shoppingCart->addBuyable($buyable, $quantity);
                $status = "good";
                $message = _t("AddToCartPage.ADDED", "Added");
            }
        }
        if (Director::is_ajax()) {
            return $shoppingCart->setMessageAndReturn($message, $status, $form);
        } else {
            $form->setMessage($message, $status);
            $this->redirectBack();
        }
    }
}