ProductAttributeType - Code Metrics - Inspection of "PATCH: various fixes to DataObject::get_one" - sunnysideup/silverstripe-ecommerce_product_variation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02e059...1bc464 )

by Nicolaas

created 2017-05-04 02:47 UTC

ProductAttributeType D

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	434
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes

Metric	Value
wmc	58
lcom	1
cbo	16
dl	0
loc	434
rs	4.5205
c	0
b	0
f	0

16 Methods

Rating	Name	Size	Complexity
A	i18n_singular_name()	4	1
A	i18n_plural_name()	4	1
A	get_plural_name()	5	1
A	find_or_make()	19	3
B	getCMSFields()	33	2
A	CMSEditLink()	8	1
A	addValues()	5	1
A	convertArrayToValues()	14	3
B	getDropDownField()	16	6
B	getValuesForDropdown()	19	5
A	canDelete()	14	4
B	onBeforeWrite()	16	5
C	onAfterWrite()	61	14
A	onBeforeDelete()	12	3
C	cleanup()	25	7
A	getFullName()	11	1

How to fix Complexity

<?php

/**
 * This class contains list items such as "size", "colour"
 * Not XL, Red, etc..., but the lists that contain the
 * ProductAttributeValues.
 * For a clothing store you will have two entries:
 * - Size
 * - Colour
 *
 *
 */

class ProductAttributeType extends DataObject implements EditableEcommerceObject
namespace YourVendor;

class YourClass { }
{

    /**
     * Standard SS variable.
     */
    private static $api_access = array(

        'view' => array(
            "Name",
            "Label",
            "Values"
        )
    );

    /**
     * Standard SS variable.
     */
    private static $db = array(

        'Name' => 'Varchar', //for back-end use
        'Label' => 'Varchar', //for front-end use
        'Sort' => 'Int', //for front-end use
        'MergeIntoNote' => 'Varchar(255)'
        //'Unit' => 'Varchar' //TODO: for future use

    );

    /**
     * Standard SS variable.
     */
    private static $has_one = array(

        'MoreInfoLink' => 'SiteTree',
        'MergeInto' => 'ProductAttributeType'
    );

    /**
     * Standard SS variable.
     */
    private static $has_many = array(

        'Values' => 'ProductAttributeValue'
    );

    /**
     * Standard SS variable.
     */
    private static $summary_fields = array(

        'FullName' => 'Type'
    );

    /**
     * Standard SS variable.
     */
    private static $searchable_fields = array(

        'Name' => 'PartialMatchFilter',
        'Label' => 'PartialMatchFilter'
    );

    /**
     * Standard SS variable.
     */
    private static $belongs_many_many = array(

        'Products' => 'Product'
    );

    /**
     * Standard SS variable.
     */
    private static $casting = array(

        'FullName' => 'Varchar'
    );

    /**
     * Standard SS variable.
     */
    private static $indexes = array(

        "Sort" => true
    );

    /**
     * Standard SS variable.
     */
    private static $default_sort = "\"Sort\" ASC, \"Name\"";


    private static $dropdown_field_for_orderform = 'DropdownField';


    /**
     * Standard SS variable.
     */
    private static $singular_name = "Variation Attribute Type";

    public function i18n_singular_name()
    {
        return _t("ProductAttributeType.ATTRIBUTETYPE", "Variation Attribute Type");
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = "Variation Attribute Types";

    public function i18n_plural_name()
    {
        return _t("ProductAttributeType.ATTRIBUTETYPES", "Variation Attribute Types");
    }
    public static function get_plural_name()

    {
        $obj = Singleton("ProductAttributeType");
        return $obj->i18n_plural_name();
    }

    /**
     * finds or makes a ProductAttributeType, based on the lower case Name.
     *
     * @param String $name
     * @param Boolean $create
     *
     * @return ProductAttributeType
     */
    public static function find_or_make($name, $create = true)
    {
        $name = strtolower($name);
        $type = DataObject::get_one(
            'ProductAttributeType',
            'LOWER("Name") = \''.$name.'\'',
            $cacheDataObjectGetOne = false
        );
        if ($type) {
            return $type;
        }
        $type = ProductAttributeType::create();
        $type->Name = $name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $type->Label = $name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($create) {
            $type->write();
        }
        return $type;
    }

    /**
     * Standard SS Methodd.
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $nameField = $fields->dataFieldByName("Name");
        $nameField->SetRightTitle(_t("ProductAttributeType.NAME_RIGHT_TITLE", "Mainly used for easy recognition in the CMS"));
        $valueField = $fields->dataFieldByName("Label");
        $valueField->SetRightTitle(_t("ProductAttributeType.VALUE_RIGHT_TITLE", "Mainly used for site users"));
        $variationField = $fields->dataFieldByName('Values');
        if($variationField) {
            $variationField->setConfig(new GridFieldConfigForOrderItems());

        }
        $fields->addFieldToTab(
            "Root.Main",
            new OptionalTreeDropdownField(
                "MoreInfoLinkID",
                _t("ProductAttributeType.MORE_INFO_LINK", "More info page"),
                "SiteTree"
            )
        );
        //TODO: make this a really fast editing interface. Table list field??
        //$fields->removeFieldFromTab('Root.Values','Values');

        $fields->AddFieldToTab(
            "Root.Advanced",
            DropdownField::create(
                'MergeIntoID',
                _t('ProductAttributeType.MERGE_INTO', 'Merge into ...'),
                array(0 => _t('ProductAttributeType.DO_NOT_MERGE', '-- do not merge --')) +
                    ProductAttributeType::get()->exclude(array("ID" => $this->ID))->map()->toArray()
            )
        );
        $fields->AddFieldToTab("Root.Advanced", new ReadOnlyField("MergeIntoNote", "Merge Results Notes"));
        return $fields;
    }

    /**
     * link to edit the record
     * @param String | Null $action - e.g. edit
     * @return String
     */
    public function CMSEditLink($action = null)
    {
        return Controller::join_links(
            Director::baseURL(),
            "/admin/product-config/".$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/",
            $action
        );
    }

    /**
     * add more values to a type
     * array should be an something like red, blue, orange (strings NOT objects)
     * @param Array
     */
    public function addValues(array $values)
    {
        $avalues = $this->convertArrayToValues($values);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $this->Values()->addMany($values);

    }

    /**
     * takes an array of values
     * and finds them or creates them.
     *
     * @param Array $values
     * @return ArrayList
     */
    public function convertArrayToValues(array $values)
    {
        $set = new ArrayList();
        foreach ($values as $value) {
            $val = $this->Values()->find('Value', $value);

            if (!$val) {  //TODO: ignore case, if possible
                $val = new ProductAttributeValue();
                $val->Value = $value;
                $val->write();
            }
            $set->push($val);
        }
        return $set;
    }

    /**
     *
     * @param String $emptyString
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param DataList $values

     *
     * @return DropdownField | HiddenField
     */
    public function getDropDownField($emptystring = null, $values = null)
    {
        //to do, why do switch to "all" the options if there are no values?
        $values = $this->getValuesForDropdown($values);
        if ($values && is_array($values) && count($values)) {

            $fieldType = $this->Config()->get('dropdown_field_for_orderform');
            $field = $fieldType::create('ProductAttributes['.$this->ID.']', $this->Label, $values);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($emptystring && count($values) > 1) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $field->setEmptyString($emptystring);
            }
        } else {
            $field = new HiddenField('ProductAttributes['.$this->ID.']', 0);
        }
        $this->extend("updateDropDownField", $field);
        return $field;
    }

    private static $_drop_down_values = array();

    /**
     *
     * @param DataList $values

     *
     * @return array
     */
    public function getValuesForDropdown($values = null)
    {
        if(! isset(self::$_drop_down_values[$this->ID])) {
            $values = ($values) ? $values : $this->Values();

            $count = $values->count();
            if ($count > 0) {
                if($count > 100) {
                    $values = $values->limit(1000);
                    self::$_drop_down_values[$this->ID] = $values->map('ID', 'Value')->toArray();
                } else {
                    self::$_drop_down_values[$this->ID] = $values->map('ID', 'ValueForDropdown')->toArray();
                }
            } else {
                self::$_drop_down_values[$this->ID] = array();
            }
        }

        return self::$_drop_down_values[$this->ID];
    }

    /**
     * It can be deleted if all its Values can be deleted only...
     *
     * @return Boolean

     */
    public function canDelete($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        $values = $this->Values()->limit(10);

        foreach ($values as $value) {
            if (! $value->canDelete()) {
                return false;
            }
        }
        return parent::canDelete($member);
    }

    /**
     * standard SS method
     * Adds a name if there is no name.
     * Adds a label is there is no label.
     *
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $i = 0;
        $className = $this->ClassName;
        while (!$this->Name || DataObject::get_one($className, 'Name = \''.$this->Name.'\' AND ID != \''.$this->ID.'\'', $cacheDataObjectGetOne = false)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Name = $this->i18n_singular_name();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($i) {
                $this->Name .= "_".$i;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            $i++;
        }
        if (!$this->Label) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Label = $this->Name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->MergeIntoID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $newAttributeType = $this->MergeInto();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $canDoMerge = true;
            if ($this->Values()->count() != $newAttributeType->Values()->count()) {

                $canDoMerge = false;
                $this->MergeIntoNote = "NON-MATCHING VALUE COUNTS";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            } else {
                $mergeMapArray_OLD = array();
                $mergeMapArray_NEW = array();
                $mergeMapArrayGO = array();
                foreach ($this->Values() as $value) {

                    $mergeMapArray_OLD[] = $value->ID;
                }
                foreach ($newAttributeType->Values() as $value) {
                    $mergeMapArray_NEW[] = $value->ID;
                }
                foreach ($mergeMapArray_OLD as $key => $id_OLD) {
                    $id_NEW = $mergeMapArray_NEW[$key];
                    $obj_OLD = ProductAttributeValue::get()->byID($id_OLD);
                    $obj_NEW = ProductAttributeValue::get()->byID($id_NEW);
                    if ($obj_OLD && $obj_NEW) {
                        if ($obj_OLD->Code == $obj_NEW->Code || $obj_OLD->Value == $obj_NEW->Value || 1 == 1) {
                            $mergeMapArrayGO[$obj_OLD->ID] = $obj_NEW->ID;
                        } else {
                            $this->MergeIntoNote = "NON-MATCHINGE VALUES: ".$obj_OLD->Code."!=".$obj_NEW->Code." AND ".$obj_OLD->Value."!=".$obj_NEW->Value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $canDoMerge = false;
                        }
                    } else {
                        $this->MergeIntoNote = "MISSING OLD OR NEW OBJECT";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $canDoMerge = false;
                    }
                }
            }
            if ($canDoMerge) {
                foreach ($mergeMapArrayGO as $id_OLD => $id_NEW) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    DB::query("
                        UPDATE \"ProductVariation_AttributeValues\"
                        SET \"ProductAttributeValueID\" = ".$id_NEW."
                        WHERE \"ProductAttributeValueID\" = ".$id_OLD.";
                    ");
                }
                DB::query("
                    UPDATE \"Product_VariationAttributes\"
                    SET \"ProductAttributeTypeID\" = ".$this->MergeIntoID."
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    WHERE \"ProductAttributeTypeID\" = ".$this->ID.";
                ");
                $values = ProductAttributeValue::get()->filter(array("TypeID" => $this->ID));
                foreach ($values as $value) {
                    $value->delete();
                }
                $this->MergeIntoNote = "Merged successfully into ".$this->MergeInto()->Name." ...";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Name = "TO BE DELETED ".$this->Name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Label = "TO BE DELETED ".$this->Label;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            $this->MergeIntoID = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->write();
        }
    }

    /**
     * Delete all the values
     * that are related to this type.
     */
    public function onBeforeDelete()
    {
        parent::onBeforeDelete();
        $values = $this->Values();

        foreach ($values as $value) {
            if ($value->canDelete()) {
                $value->delete();
                $value->destroy();
            }
        }
        DB::query("DELETE FROM \"Product_VariationAttributes\" WHERE \"ProductAttributeTypeID\" = ".$this->ID);
    }

    public function cleanup()
    {
        $sql = "
            Select \"ProductAttributeTypeID\"
            FROM \"Product_VariationAttributes\"
            WHERE \"ProductID\" = ".$this->owner->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $data = DB::query($sql);
        $array = $data->keyedColumn();
        if (is_array($array) && count($array)) {
            foreach ($array as $key => $productAttributeTypeID) {
                //attribute type does not exist.
                if (! ProductAttributeType::get()->byID($productAttributeTypeID)) {
                    //delete non-existing combinations of Product_VariationAttributes (where the attribute does not exist)
                    //DB::query("DELETE FROM \"Product_VariationAttributes\" WHERE \"ProductAttributeTypeID\" = $productAttributeTypeID");

                    //non-existing product attribute values.
                    $productAttributeValues = ProductAttributeValue::get()->filter(array("TypeID" => $productAttributeTypeID));
                    if ($productAttributeValues->count()) {
                        foreach ($productAttributeValues as $productAttributeValue) {
                            $productAttributeValue->delete();
                        }
                    }
                }
            }
        }
    }

    /**
     * useful for GridField
     * @return String
     */
    public function getFullName()
    {
        $fieldLabels = $this->FieldLabels();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return
            $this->Name.', '.
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Label.
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ' ('.
                $this->Values()->count().' '.Injector::inst()->get('ProductAttributeValue')->i18n_plural_name().', '.

                $this->Products()->count().' '.Injector::inst()->get('Product')->i18n_plural_name().
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ')';
    }
}


Push — master ( 02e059...1bc464 )

ProductAttributeType D

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Complexity

Complex Class

Available Fixes

1			<?php
2
3			/**
4			* This class contains list items such as "size", "colour"
5			* Not XL, Red, etc..., but the lists that contain the
6			* ProductAttributeValues.
7			* For a clothing store you will have two entries:
8			* - Size
9			* - Colour
10			*
11			*
12			*/
13
14			class ProductAttributeType extends DataObject implements EditableEcommerceObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
15			{
16
17			/**
18			* Standard SS variable.
19			*/
20			private static $api_access = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$api_access` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21			'view' => array(
22			"Name",
23			"Label",
24			"Values"
25			)
26			);
27
28			/**
29			* Standard SS variable.
30			*/
31			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
32			'Name' => 'Varchar', //for back-end use
33			'Label' => 'Varchar', //for front-end use
34			'Sort' => 'Int', //for front-end use
35			'MergeIntoNote' => 'Varchar(255)'
36			//'Unit' => 'Varchar' //TODO: for future use
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...

sunnysideup / silverstripe-ecommerce_product_variation

Push — master ( 02e059...1bc464 )

ProductAttributeType D

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

How to fix Complexity

Complex Class

Available Fixes

Duplication Side-by-Side

Filter issues like