ProductAttributeValue - Code Metrics - Inspection of "PATCH: fixing unexpected );" - sunnysideup/silverstripe-ecommerce_product_variation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1bc464...db56f8 )

unknown

created 2017-05-04 03:12 UTC

ProductAttributeValue B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	292
Duplicated Lines	8.9 %

Coupling/Cohesion

Components	2
Dependencies	12

Importance

Changes

Metric	Value
wmc	36
lcom	2
cbo	12
dl	26
loc	292
rs	8.8
c	0
b	0
f	0

17 Methods

Rating	Name	Duplication	Size	Complexity
B	find_or_make()	0	32	5
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	canDelete()	0	17	3
A	getCMSFields()	0	22	2
A	CMSEditLink()	8	8	1
A	ValueForDropdown()	0	4	1
A	getValueForDropdown()	9	9	4
A	ValueForTable()	0	4	1
A	getValueForTable()	9	9	4
A	Title()	0	4	1
A	getTitle()	0	4	1
A	FullTitle()	0	4	1
A	getFullTitle()	0	9	2
A	onBeforeDelete()	0	6	1
A	onBeforeWrite()	0	16	3
B	onAfterWrite()	0	29	4

How to fix Duplicated Code

<?php

class ProductAttributeValue extends DataObject implements EditableEcommerceObject
namespace YourVendor;

class YourClass { }
{

    /**
     * Standard SS variable.
     */
    private static $api_access = array(

        'view' => array(
            "Value",
            "Type"
        )
    );

    private static $db = array(

        'Code' => 'Varchar(255)',
        'Value' => 'Varchar(255)',
        'Sort' => 'Int',
        'MergeIntoNote' => 'Varchar(255)'
    );

    private static $has_one = array(

        'Type' => 'ProductAttributeType',
        'MergeInto' => 'ProductAttributeValue'
    );

    private static $belongs_many_many = array(

        'ProductVariation' => 'ProductVariation'
    );

    private static $summary_fields = array(

        'Type.FullName' => 'Type',
        'Value' => 'Value'
    );

    private static $searchable_fields = array(

        'Value' => 'PartialMatchFilter'
    );

    private static $casting = array(

        'Title' => 'HTMLText',
        'FullTitle' => 'Varchar',
        'ValueForDropdown' => "HTMLText",
        'ValueForTable' => "HTMLText"
    );

    private static $indexes = array(

        'Sort' => true,
        'Code' => true
    );

    /**
     * finds or makes a ProductAttributeType, based on the lower case Name.
     *
     * @param productAttributeType | int $type
     * @param string $value
     * @param boolean $create
     * @param boolean $findByID
     *
     * @return ProductAttributeType
     */
    public static function find_or_make($type, $value, $create = true, $findByID = false)
    {
        if ($type instanceof ProductAttributeType) {
            $type = $type->ID;
        }
        $cleanedValue = strtolower($value);
        if ($findByID) {
            $intValue = intval($value);
            $valueObj = ProductAttributeValue::get()
                ->filter(array("ID" => $intValue, "TypeID" => intval($type)))
                ->first();
                //debug::log("INT VALUE:" .$intValue."-".$type);

        } else {
            $valueObj = DataObject::get_one(
                'ProductAttributeValue',
                "(LOWER(\"Code\") = '$cleanedValue' OR LOWER(\"Value\") = '$cleanedValue') AND TypeID = ".intval($type),
                $cacheDataObjectGetOne = false
            );
        }
        if ($valueObj) {

            return $valueObj;
        }
        $valueObj = ProductAttributeValue::create();
        $valueObj->Code = $cleanedValue;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $valueObj->Value = $value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $valueObj->TypeID = $type;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($create) {
            $valueObj->write();
        }
        return $valueObj;
    }

    private static $default_sort = "\"TypeID\" ASC, \"Sort\" ASC";


    private static $singular_name = "Variation Attribute Value";

    public function i18n_singular_name()
    {
        return _t("ProductAttributeValue.ATTRIBUTEVALUE", "Variation Attribute Value");
    }

    private static $plural_name = "Variation Attribute Values";

    public function i18n_plural_name()
    {
        return _t("ProductAttributeValue.ATTRIBUTEVALUES", "Variation Attribute Values");
    }

    public function canDelete($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if (DB::query("
            SELECT COUNT(*)
            FROM \"ProductVariation_AttributeValues\"
                INNER JOIN \"ProductVariation\"
                    ON  \"ProductVariation_AttributeValues\".\"ProductVariationID\" = \"ProductVariation\".\"ID\"
            WHERE \"ProductAttributeValueID\" = ".$this->ID
        )->value() == 0) {
            return parent::canDelete($member);
        }
        return false;
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $variationField = $fields->dataFieldByName('ProductVariation');
        if($variationField) {
            $variationField->setConfig(new GridFieldConfigForOrderItems());

        }
        $fields->AddFieldToTab(
            "Root.Advanced",
            DropdownField::create(
                'MergeIntoID',
                _t('ProductAttributeType.MERGE_INTO', 'Merge into ...'),
                array(0 => _t('ProductAttributeType.DO_NOT_MERGE', '-- do not merge --')) +
                    ProductAttributeValue::get()
                        ->filter(array('TypeID' => $this->TypeID))
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        ->exclude(array("ID" => $this->ID))
                        ->map('ID', 'FullTitle')->toArray()
            )
        );
        $fields->AddFieldToTab("Root.Advanced", new ReadOnlyField("MergeIntoNote", "Merge Results Notes"));
        return $fields;
    }

    /**
     * link to edit the record
     * @param String | Null $action - e.g. edit
     * @return String
     */
    public function CMSEditLink($action = null)

    {
        return Controller::join_links(
            Director::baseURL(),
            "/admin/product-config/".$this->ClassName."/EditForm/field/".$this->ClassName."/item/".$this->ID."/",
            $action
        );
    }

    /**
     * casted variable
     * returns the value for the option in the select dropdown box.
     * @return String (HTML)
     **/
    public function ValueForDropdown()
    {
        return $this->getValueForDropdown();
    }
    public function getValueForDropdown()

    {
        $value = $this->Value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $extensionValue = $this->extend("updateValueForDropdown");
        if ($extensionValue !== null && is_array($extensionValue) && count($extensionValue)) {
            $value = implode("", $extensionValue);
        }
        return $value;
    }

    /**
     * casted variable
     * returns the value for the variations table
     * @return String (HTML)
     **/
    public function ValueForTable()
    {
        return $this->getValueForTable();
    }
    public function getValueForTable()

    {
        $value = $this->Value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $extensionValue = $this->extend("updateValueForTable");
        if ($extensionValue !== null && is_array($extensionValue) && count($extensionValue)) {
            $value = implode("", $extensionValue);
        }
        return $value;
    }

    /**
     * casted variable
     * returns the value for the variations table
     * @return String
     **/
    public function Title()
    {
        return $this->getTitle();
    }
    public function getTitle()

    {
        return $this->getValueForTable();
    }

    /**
     * casted variable
     * returns the value for the variations table
     * @return String
     **/
    public function FullTitle()
    {
        return $this->getFullTitle();
    }
    public function getFullTitle()
    {
        if($type = $this->Type()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $typeName = $type->Name;
        } else {
            $typeName = _t('ProductAttributeValue.NO_TYPE_NAME', 'NO TYPE');
        }
        return $typeName.': '.$this->Value.' ('.$this->Code.')';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function onBeforeDelete()
    {
        parent::onBeforeDelete();
        //delete ProductVariation_AttributeValues were the Attribute Value does not exist.
        DB::query("DELETE FROM \"ProductVariation_AttributeValues\" WHERE \"ProductVariation_AttributeValues\".\"ProductAttributeValueID\" = ".$this->ID);
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if (!$this->Value) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Value = $this->i18n_singular_name();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $i = 0;
            $className = $this->ClassName;
            while( DataObject::get_one($className, array("Value" => $this->Value), $cacheDataObjectGetOne = false) ) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Value = $this->i18n_singular_name()."_".$i;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $i++;
            }
        }
        // No Need To Remove Variations because of onBeforeDelete
        /*$variations = $this->ProductVariation();

        foreach($variations as $variation) $variation->delete();*/
    }


    /**
     * Event handler called after writing to the database.
     */
    public function onAfterWrite()
    {
        parent::onAfterWrite();
        if ($this->MergeIntoID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $newAttributeValue = $this->MergeInto();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if($newAttributeValue && $newAttributeValue->exists()) {
                $newID = $this->MergeIntoID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $oldID = $this->ID;
                $oldTypeID = $this->TypeID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $newTypeID = $newAttributeValue->TypeID;
                DB::query("
                    UPDATE \"ProductVariation_AttributeValues\"
                    SET \"ProductAttributeValueID\" = ".$newID."
                    WHERE \"ProductAttributeValueID\" = ".$oldID.";
                ");
                DB::query("
                    UPDATE \"Product_VariationAttributes\"
                    SET \"ProductAttributeTypeID\" = ".$newTypeID."
                    WHERE \"ProductAttributeTypeID\" = ".$oldTypeID.";
                ");
                $mergedInto = _t('ProductAttributeValue.MERGED_INTO', 'Merged successfully into');
                $this->MergeIntoNote = $mergedInto.' '.$newAttributeValue->FullTitle();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $toBeDeleted = _t('ProductAttributeValue.TO_BE_DELETED', 'To be deleted');
                $this->Value = $toBeDeleted.' '.$this->Value;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->MergeIntoID = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->write();
            }
        }
    }

}


1			<?php
2
3			class ProductAttributeValue extends DataObject implements EditableEcommerceObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6			/**
7			* Standard SS variable.
8			*/
9			private static $api_access = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$api_access` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
10			'view' => array(
11			"Value",
12			"Type"
13			)
14			);
15
16			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17			'Code' => 'Varchar(255)',
18			'Value' => 'Varchar(255)',
19			'Sort' => 'Int',
20			'MergeIntoNote' => 'Varchar(255)'
21			);
22
23			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24			'Type' => 'ProductAttributeType',
25			'MergeInto' => 'ProductAttributeValue'
26			);
27
28			private static $belongs_many_many = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$belongs_many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
29			'ProductVariation' => 'ProductVariation'
30			);
31
32			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 01:10 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33			'Type.FullName' => 'Type',
34			'Value' => 'Value'

sunnysideup / silverstripe-ecommerce_product_variation

Push — master ( 1bc464...db56f8 )

ProductAttributeValue B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

17 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like