ProductQuestionImageSelectorField

Complexity

Total Complexity

20

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	setOptions()	0	4	1
A	setFolderID()	0	4	1
A	setWidth()	0	4	1
A	setHeight()	0	4	1
B	Field()	0	39	9
A	createObjects()	0	19	6

<?php

/**
 * form field to select answer for question.
 *
 *
 */


class ProductQuestionImageSelectorField extends OptionsetField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $folderID = 0;

    protected $options = array();

    protected $objects = null;

    protected $width = 50;

    protected $height = 50;

    public function __construct($name, $title = '', $options = array(), $value = '', $folderID)

Parameters which have default values should be placed at the end.

    {
        $this->setOptions($options);
        $this->setFolderID($folderID);
        $this->createObjects();
        parent::__construct($name, $title, $options, $value);
    }

    public function setOptions($options)
    {
        $this->options = $options;
    }

    public function setFolderID($folderID)
    {
        $this->folderID = $folderID;
    }

    public function setWidth($width)
    {
        $this->width = $width;
    }

    public function setHeight($height)
    {
        $this->height = $height;
    }

    public function Field($properties = array())

The return type could not be reliably inferred; please add a @return annotation.

    {
        $options = '';
        $source = $this->getSource();

$source is not used, you could remove the assignment.

        $count = 0;
        if ($this->objects && $this->objects->count()) {
            foreach ($this->objects as $image) {
                $key = $image->Key;
                $itemID = $this->id() . "_" . $image->ID;
                $value = $image->Value;
                $labelHTML = $value;
                $resizedImageObject = $image->getFormattedImage("CroppedImage", $this->width, $this->height);
                if ($resizedImageObject) {
                    $labelHTML = '<img src="'.$resizedImageObject->Link().'" alt="'.$value.'" />';
                }
                if ($key == $this->value/* || $useValue */) {
                    $useValue = false;

$useValue is not used, you could remove the assignment.

                    $checked = " checked=\"checked\"";
                } else {
                    $checked="";
                }
                $odd = ($count + 1) % 2;
                $oddEven = $odd ? "odd" : "even";
                $extraClass = " val" . preg_replace('/[^a-zA-Z0-9\-\_]/', '_', $key);
                $position = " pos".$count;
                $disabled = $this->disabled ? 'disabled="disabled"' : '';
                $options .= "<li class=\"".$oddEven.$extraClass.$position."\"><input id=\"$itemID\" name=\"$this->name\" type=\"radio\" value=\"$key\"$checked $disabled class=\"radio\" /> <label for=\"$itemID\">$labelHTML</label></li>\n";
                $count++;
            }
            $id = $this->id();
        }
        if (empty($id)) {
            $id = 0;
        }
        return "
            <ul id=\"$id\" class=\"optionset {$this->extraClass()}\">
            \n$options
            </ul>\n";
    }

    protected function createObjects()
    {
        $this->objects = new ArrayList();
        if ($this->options && is_array($this->options) && count($this->options)) {

The expression $this->options of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->options as $option) {
                $imageOptions = ProductQuestion::create_file_array_from_option($option);
                $image = DataObject::get_one(
                    'Image',
                    array("ParentID" => $this->folderID, "Name" => $imageOptions),
                    $cacheDataObjectGetOne = false
                );
                if ($image) {
                    $image->Key = $option;
                    $image->Value = $option;
                    $this->objects->push($image);
                }
            }
        }
    }
}