OrderStatusLog_FeefoLog::canEdit() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_orderstep_feefo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 626e87...f67c15 )

unknown

created 2018-05-04 00:03 UTC

OrderStatusLog_FeefoLog::canEdit() B

↳ Parent: OrderStatusLog_FeefoLog

Complexity

Conditions	5
Paths	3

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	3
nop	1

<?php


/**
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: model
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class OrderStatusLog_FeefoLog extends OrderStatusLog
namespace YourVendor;

class YourClass { }
{

    private static $db = array(

        'DetailedInfo' => 'HTMLText'
    );

    public function canCreate($member = null)
    {
        return false;
    }

    public function canEdit($member = null)
    {
        $order = $this->Order();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($order && $order->exists()) {
            $status = $order->MyStep();
            if($status && $status->Code == 'FEEFO') {
                return parent::canEdit($member);
            } else {
                return false;
            }
        } else {
            return parent::canEdit($member);
        }
    }
}


1			<?php
2
3
4			/**
5			* @authors: Nicolaas [at] Sunny Side Up .co.nz
6			* @package: ecommerce
7			* @sub-package: model
8			* @inspiration: Silverstripe Ltd, Jeremy
9			**/
10			class OrderStatusLog_FeefoLog extends OrderStatusLog
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-04 00:05 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12
13			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2018-05-04 00:05 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-05-04 00:05 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14			'DetailedInfo' => 'HTMLText'
15			);
16
17			public function canCreate($member = null)
18			{
19			return false;
20			}
21
22			public function canEdit($member = null)
23			{
24			$order = $this->Order();
			0 ignored issues – show Documentation Bug introduced 2018-05-04 00:05 UTC by Report Bug Copy Issue Report The method `Order` does not exist on `object<OrderStatusLog_FeefoLog>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
25			if ($order && $order->exists()) {
26			$status = $order->MyStep();
27			if($status && $status->Code == 'FEEFO') {
28			return parent::canEdit($member);
29			} else {
30			return false;
31			}
32			} else {
33			return parent::canEdit($member);
34			}
35			}
36			}
37

sunnysideup / silverstripe-ecommerce_orderstep_feefo

Push — master ( 626e87...f67c15 )

OrderStatusLog_FeefoLog::canEdit() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like