EntersaleremotelyAPIConnector::sendOrderDataToFeefo() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_orderstep_feefo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 626e87...f67c15 )

unknown

created 2018-05-04 00:03 UTC

sendOrderDataToFeefo() A

↳ Parent: EntersaleremotelyAPIConnector

Complexity

Conditions	3
Paths	4

Size

Total Lines	57
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	57
rs	9.6818
c	0
b	0
f	0
cc	3
eloc	40
nc	4
nop	2

How to fix Long Method

<?php

/**
 * Class used to connecto the the Entersaleremotely API
 *@author nicolaas [at] sunnysideup.co.nz
 */


class EntersaleremotelyAPIConnector extends Object
namespace YourVendor;

class YourClass { }
{

    /**
     * REQUIRED!
     * @var String
     */
    private static $api_key = "";



    /**
     * REQUIRED!
     * @var String
     */
    private static $merchant_identifier = "";



    /**
     * sends the order data from the website to feefo using the Entersaleremotely API
     *
     * @param  Order $order - the order to be assessed
     * @param  int $delay - number of days to wait before feefo will send the feedback email
     *
     * @return array $messages - an array of message regarding the success of each curl request - one for each Order Item
     */
    public function sendOrderDataToFeefo($order, $delay = 0)
    {
        $messages = [];
        //api details
        $apiKey = Config::inst()->get('EntersaleremotelyAPIConnector', 'api_key');
        $merchant = Config::inst()->get('EntersaleremotelyAPIConnector', 'merchant_identifier');

        //member specific details
        $member = $order->Member();

        $email = $member->Email;
        $name = $member->FirstName;
        $locale = $member->Locale;
        $customerRef = $member->ID;

        //order specific details
        $orderRef = $order->ID;
        $currency = $order->CurrencyUsed()->Code;
        $dateAsString = strtotime($order->Created);
        $date = date('Y-m-d', $dateAsString);

        $feedbackDate = '';
        if($delay){
            $feedbackDate = date( 'Y-m-d', strtotime('+' . $delay . ' days', $dateAsString) );
        }

        foreach ($order->Items() as $orderItem) {
            $amount = $orderItem->CalculatedTotal;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $product = $orderItem->Product();
            $productTitle = $product->Title;
            $link = Director::absoluteURL($product->Link());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $params = [
                'apikey' => $apiKey,
                'merchantidentifier' => $merchant,
                'feedbackdate' => $feedbackDate,
                'email' =>$email,
                'name' => $name,
                'locale' => $locale,
                'customerref' => $customerRef,
                'orderref' => $orderRef,
                'date' => $date,
                'currency' => $currency,
                'amount ' => $orderItem->CalculatedTotal,
                'description' => $productTitle,
                'productsearchcode'=> $productTitle,
                'productlink' => 'https://www.picspeanutbutter.com/buy/buy-online/380g-smooth-no-salt/'
            ];

            $result = $this->sendCurlRequest($params);

            $result .= ' Order ID: ' . $orderRef . '; Product: ' . $productTitle . ';';

            array_push($messages, $result);
        }

        return $messages;
    }

    /**
     * performs the curl request
     *
     * @param  array $params - the data to send to FEEFO
     *
     * @return string $reply
     */
    public function sendCurlRequest($params)
    {
        $reply = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $url = 'https://api.feefo.com/api/entersaleremotely';

        $data = http_build_query($params, '', '&');

        $ch=curl_init();

        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_POST, 1);
        curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

        $reply = curl_exec($ch);

        curl_close($ch);
        return $reply;
    }


}


1			<?php
2
3			/**
4			* Class used to connecto the the Entersaleremotely API
5			*@author nicolaas [at] sunnysideup.co.nz
6			*/
7
8
9			class EntersaleremotelyAPIConnector extends Object
			0 ignored issues – show Coding Style Compatibility introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11
12			/**
13			* REQUIRED!
14			* @var String
15			*/
16			private static $api_key = "";
			0 ignored issues – show Unused Code introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report The property `$api_key` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17
18
19			/**
20			* REQUIRED!
21			* @var String
22			*/
23			private static $merchant_identifier = "";
			0 ignored issues – show Unused Code introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report The property `$merchant_identifier` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24
25
26			/**
27			* sends the order data from the website to feefo using the Entersaleremotely API
28			*
29			* @param Order $order - the order to be assessed
30			* @param int $delay - number of days to wait before feefo will send the feedback email
31			*
32			* @return array $messages - an array of message regarding the success of each curl request - one for each Order Item
33			*/
34			public function sendOrderDataToFeefo($order, $delay = 0)
35			{
36			$messages = [];
37			//api details
38			$apiKey = Config::inst()->get('EntersaleremotelyAPIConnector', 'api_key');
39			$merchant = Config::inst()->get('EntersaleremotelyAPIConnector', 'merchant_identifier');
40
41			//member specific details
42			$member = $order->Member();
			0 ignored issues – show Bug introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report The method `Member()` does not exist on `Order`. Did you maybe mean `CreateOrReturnExistingMember()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
43			$email = $member->Email;
44			$name = $member->FirstName;
45			$locale = $member->Locale;
46			$customerRef = $member->ID;
47
48			//order specific details
49			$orderRef = $order->ID;
50			$currency = $order->CurrencyUsed()->Code;
51			$dateAsString = strtotime($order->Created);
52			$date = date('Y-m-d', $dateAsString);
53
54			$feedbackDate = '';
55			if($delay){
56			$feedbackDate = date( 'Y-m-d', strtotime('+' . $delay . ' days', $dateAsString) );
57			}
58
59			foreach ($order->Items() as $orderItem) {
60			$amount = $orderItem->CalculatedTotal;
			0 ignored issues – show Unused Code introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report `$amount` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
61			$product = $orderItem->Product();
62			$productTitle = $product->Title;
63			$link = Director::absoluteURL($product->Link());
			0 ignored issues – show Unused Code introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report `$link` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64
65			$params = [
66			'apikey' => $apiKey,
67			'merchantidentifier' => $merchant,
68			'feedbackdate' => $feedbackDate,
69			'email' =>$email,
70			'name' => $name,
71			'locale' => $locale,
72			'customerref' => $customerRef,
73			'orderref' => $orderRef,
74			'date' => $date,
75			'currency' => $currency,
76			'amount ' => $orderItem->CalculatedTotal,
77			'description' => $productTitle,
78			'productsearchcode'=> $productTitle,
79			'productlink' => 'https://www.picspeanutbutter.com/buy/buy-online/380g-smooth-no-salt/'
80			];
81
82			$result = $this->sendCurlRequest($params);
83
84			$result .= ' Order ID: ' . $orderRef . '; Product: ' . $productTitle . ';';
85
86			array_push($messages, $result);
87			}
88
89			return $messages;
90			}
91
92			/**
93			* performs the curl request
94			*
95			* @param array $params - the data to send to FEEFO
96			*
97			* @return string $reply
98			*/
99			public function sendCurlRequest($params)
100			{
101			$reply = '';
			0 ignored issues – show Unused Code introduced 2018-05-02 06:42 UTC by Report Bug Copy Issue Report `$reply` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
102			$url = 'https://api.feefo.com/api/entersaleremotely';
103
104			$data = http_build_query($params, '', '&');
105
106			$ch=curl_init();
107
108			curl_setopt($ch, CURLOPT_URL, $url);
109			curl_setopt($ch, CURLOPT_POST, 1);
110			curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
111			curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
112
113			$reply = curl_exec($ch);
114
115			curl_close($ch);
116			return $reply;
117			}
118
119
120			}
121

sunnysideup / silverstripe-ecommerce_orderstep_feefo

Push — master ( 626e87...f67c15 )

sendOrderDataToFeefo() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like