OrderStepFeefo

Complexity

Total Complexity

11

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	15	1
A	initStep()	0	4	1
B	doStep()	0	27	4
A	nextStep()	0	4	1
A	hasCustomerMessage()	0	4	1
A	myDescription()	0	4	1
A	convertArrayToHTMLList()	0	8	2

<?php



class OrderStepFeefo extends OrderStep

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'FeedbackDelay' => 'Int'
    );


    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        'CustomerCanEdit' => 0,
        'CustomerCanCancel' => 0,
        'CustomerCanPay' => 0,
        'Name' => 'Send Order To Feefo',
        'Code' => 'FEEFO',
        "ShowAsInProcessOrder" => true,
        "HideStepFromCustomer" => true
    );


    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName('FeedbackDelay');

        $fields->addFieldToTab(
            'Root.Feefo',
            NumericField::create(
                'FeedbackDelay',
                'Feedback Delay'
            )
        );

        return $fields;
    }

    public function initStep(Order $order)
    {
        return true;
    }

    public function doStep(Order $order)
    {

        $api = Injector::inst()->get('EntersaleremotelyAPIConnector');
        try {
            $result = $api->sendOrderDataToFeefo($order, $this->FeedbackDelay);

The property FeedbackDelay does not exist on object<OrderStepFeefo>. Since you implemented __get, maybe consider adding a @property annotation.

            $result = $this->convertArrayToHTMLList($result);

            $className = $this->getRelevantLogEntryClassName();

            if (class_exists($className)) {
                $obj = $className::create();
                if (is_a($obj, Object::getCustomClass('OrderStatusLog'))) {
                    $obj->OrderID = $order->ID;
                    $obj->Title = $this->Name;

The property Name does not exist on object<OrderStepFeefo>. Since you implemented __set, maybe consider adding a @property annotation.

                    $obj->DetailedInfo = $result;
                    $obj->write();
                }
            }

        }
        catch (Exception $e) {
            $e->getMessage();
        }

        return true;
    }

    /**
     * can continue if emails has been sent or if there is no need to send a receipt.
     * @param DataObject $order Order
     * @return DataObject | Null - DataObject = next OrderStep

Should the return type not be OrderStep|null?

     **/
    public function nextStep(Order $order)
    {
        return parent::nextStep($order);
    }

    /**
     * For some ordersteps this returns true...
     * @return Boolean
     **/
    protected function hasCustomerMessage()
    {
        return false;
    }

    /**
     * Explains the current order step.
     * @return String
     */
    protected function myDescription()
    {
        return "The customer and order data is sent to Feefo via the Entersaleremotely API.";
    }

    public function convertArrayToHTMLList($array){
        $html = '<ul>';
        foreach($array as $arrayItem){
            $html .= '<li>' . $arrayItem . '</li>';
        }
        $html .= '</ul>';
        return $html;
    }
}