EntersaleremotelyAPIConnector

Complexity

Total Complexity

4

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	sendOrderDataToFeefo()	0	57	3
A	sendCurlRequest()	0	19	1

<?php

/**
 * Class used to connecto the the Entersaleremotely API
 *@author nicolaas [at] sunnysideup.co.nz
 */


class EntersaleremotelyAPIConnector extends Object

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * REQUIRED!
     * @var String
     */
    private static $api_key = "";

The property $api_key is not used and could be removed.

    /**
     * REQUIRED!
     * @var String
     */
    private static $merchant_identifier = "";

The property $merchant_identifier is not used and could be removed.

    /**
     * sends the order data from the website to feefo using the Entersaleremotely API
     *
     * @param  Order $order - the order to be assessed
     * @param  int $delay - number of days to wait before feefo will send the feedback email
     *
     * @return array $messages - an array of message regarding the success of each curl request - one for each Order Item
     */
    public function sendOrderDataToFeefo($order, $delay = 0)
    {
        $messages = [];
        //api details
        $apiKey = Config::inst()->get('EntersaleremotelyAPIConnector', 'api_key');
        $merchant = Config::inst()->get('EntersaleremotelyAPIConnector', 'merchant_identifier');

        //member specific details
        $member = $order->Member();

The method Member() does not exist on Order. Did you maybe mean CreateOrReturnExistingMember()?

        $email = $member->Email;
        $name = $member->FirstName;
        $locale = $member->Locale;
        $customerRef = $member->ID;

        //order specific details
        $orderRef = $order->ID;
        $currency = $order->CurrencyUsed()->Code;
        $dateAsString = strtotime($order->Created);
        $date = date('Y-m-d', $dateAsString);

        $feedbackDate = '';
        if ($delay) {
            $feedbackDate = date('Y-m-d', strtotime('+' . $delay . ' days', $dateAsString));
        }

        foreach ($order->Items() as $orderItem) {
            $amount = $orderItem->CalculatedTotal;

$amount is not used, you could remove the assignment.

            $product = $orderItem->Product();
            $productTitle = $product->Title;
            $link = Director::absoluteURL($product->Link());

            $params = [
                'apikey' => $apiKey,
                'merchantidentifier' => $merchant,
                'feedbackdate' => $feedbackDate,
                'email' =>$email,
                'name' => $name,
                'locale' => $locale,
                'customerref' => $customerRef,
                'orderref' => $orderRef,
                'date' => $date,
                'currency' => $currency,
                'amount ' => $orderItem->CalculatedTotal,
                'description' => $productTitle,
                'productsearchcode'=> $productTitle,
                'productlink' => $link
            ];

            $result = $this->sendCurlRequest($params);

            $result .= ' Order ID: ' . $orderRef . '; Product: ' . $productTitle . ';';

            array_push($messages, $result);
        }

        return $messages;
    }

    /**
     * performs the curl request
     *
     * @param  array $params - the data to send to FEEFO
     *
     * @return string $reply
     */
    public function sendCurlRequest($params)
    {
        $reply = '';

$reply is not used, you could remove the assignment.

        $url = 'https://api.feefo.com/api/entersaleremotely';

        $data = http_build_query($params, '', '&');

        $ch=curl_init();

        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_POST, 1);
        curl_setopt($ch, CURLOPT_POSTFIELDS, $data);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

        $reply = curl_exec($ch);

        curl_close($ch);
        return $reply;
    }
}