sunnysideup / silverstripe-ecommerce_nutritional_products

code/model/NutriRow.php

<?php

class NutriRow extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $default_rows = array();

The property $default_rows is not used and could be removed.

    private static $singular_name = 'Nutritional Information Item';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Nutritional Information Items';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title' => 'Varchar(30)',
        'PerServe' => 'Varchar(20)',
        'Per100' => 'Varchar(20)',
        'DVPercentage' => 'Varchar(20)',
        'Hide' => 'Boolean',
        'SortOrder' => 'Int',
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'NutriHolder' => 'NutriHolder',
    );

    private static $default_sort = array(

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

        'Hide' => 'ASC',
        'SortOrder' => 'ASC'
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'Title' => 'Title',
        'PerServe' => 'Per Serve',
        'Per100' => 'Per 100',
        'Hide.Nice' => 'Hidden'
    );

    private static $indexes = array(

Consider using a different property name as you override a private property of the parent class.

The property $indexes is not used and could be removed.

        'SortOrder' => true
    );

    public function Shown()
    {
        return !$this->Hide;

The property Hide does not exist on object<NutriRow>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     *
     *
     * @inherited
     */
    public function canDelete($member = null)
    {
        $defaultRows = Config::inst()->get("NutriRow", "default_rows");
        $defaultRows = array_map('strtolower', $defaultRows);

        if (in_array(strtolower($this->Title), $defaultRows)) {

The property Title does not exist on object<NutriRow>. Since you implemented __get, maybe consider adding a @property annotation.

            return false;
        }
        return parent::canDelete($member);
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->addFieldsToTab(
            'Root.Main',
            array(
                CheckboxField::create('Hide', 'Hide entry')
                    ->setRightTitle('Hide this entry - not relevant ... '),
                TextField::create('Title', 'Nutritional information item')
                    ->setRightTitle('E.g. salt, carbohydrates, ebergy'),
                TextField::create('PerServe', 'The amount of the item per serve')
                    ->setRightTitle('For example, 1g or 2,000KJ'),
                TextField::create('Per100', 'The amount of the item per 100g')
                    ->setRightTitle('For example, 1g or 2,000KJ'),
                TextField::create(
                    'DVPercentage',
                    '% Daily Value'
                )->setRightTitle(
                    'Eg, 20%. <br>
                    The % Daily Value(DV) tells you how much a nutrient in a serving of food contributes to a daily diet. <br>
                    2,000 calories a day is used for general nutrition advice.'
                )
            )
        );

        $fields->removeFieldFromTab('Root.Main', 'SortOrder');
        $fields->removeFieldFromTab('Root.Main', 'NutriHolder');
        $fields->removeFieldFromTab('Root.Main', 'NutriHolderID');

        return $fields;
    }


    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $defaultRows = Config::inst()->get("NutriRow", "default_rows");


        $holders = NutriHolder::get();
        foreach ($holders as $holder) {
            $sortOrder = 0;
            foreach ($defaultRows as $itemName) {

The expression $defaultRows of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

                $sortOrder++;
                $filter = array(
                    "NutriHolderID" => $holder->ID,
                    "Title" => $itemName
                );
                $obj = NutriRow::get()->filter($filter)->first();
                if (! $obj) {
                    DB::alteration_message("Creating $itemName", "created");
                    $obj = NutriRow::create($filter);
                    $obj->SortOrder = $sortOrder;

The property SortOrder does not exist on object<NutriRow>. Since you implemented __set, maybe consider adding a @property annotation.

                }
                $obj->write();
            }
        }
    }
}