NutriHolderProductDataExtension

Complexity

Total Complexity

2

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	15	2

<?php

class NutriHolderProductDataExtension extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $has_one = array(

The property $has_one is not used and could be removed.

        'NutriHolder' => 'NutriHolder'
    );

    /**
     * Update Fields
     * @return FieldList

Should the return type not be FieldList|null?

     */
    public function updateCMSFields(FieldList $fields)
    {
        $fields->removeByName('NutriHolderID');
        if ($this->owner->NutriHolder()->exists()) {
            $fields->addFieldsToTab(
                'Root.Nutrition',
                array(
                    HasOneButtonField::create('NutriHolder', 'Nutritional Info', $this->owner),
                    HeaderField::create('SelectNutriHolderHeader', 'Select existing Nutritional Information Profile'),
                    DropDownField::create('NutriHolderID', 'Nutritional Info', array("" => "-- please select --") + NutriHolder::get()->map()->toArray())
                        ->setRightTitle('Select an existing Nutritional Information Profile'),
                )
            );
        }
    }
}