NutriHolder

Complexity

Total Complexity

17

Size/Duplication

Total Lines	188
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	Per100Unit()	0	4	1
A	getPer100Unit()	0	10	2
A	Title()	0	4	1
A	getTitle()	0	12	2
B	getCMSFields()	0	66	4
A	ShownNutriRows()	0	5	1
A	NumberOfTableColums()	0	14	4

<?php

class NutriHolder extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $singular_name = 'Nutritional Information Profile';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    private static $plural_name = 'Nutritional Information Profiles';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'ProfileName' => 'Varchar(50)',
        'ServingCount' => 'Int',
        'Container' => 'Varchar(10)',
        'ServingSize' => 'Varchar(15)',
        'AdditionalInfo' => 'Varchar(100)',
        'HidePerServeColumn' => 'Boolean',
        'HidePer100gColumn' => 'Boolean',
        'HidePerDVColumn' => 'Boolean'
    );


    private static $has_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'NutriRows' => 'NutriRow',
        'Products' => 'ProductGroup',
        'ProductVariations' => 'ProductVariation'
    );

    /**
     * @inherited
     */
    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        'Title' => "Varchar",
        'Per100Unit' => "Varchar"
    );

    /**
     * Returns the unit for the 'Per 100' column of nutritional information. It tries
     * to get the unit from the ServingSize field, and if no match returns 'g'
     * @return String
     */
    public function Per100Unit()
    {
        return $this->getPer100Unit();
    }

    public function getPer100Unit()
    {
        $string = trim($this->ServingSize);

The property ServingSize does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

        $matches = array();
        $matchResult = preg_match('/ ?([A-Z]|[a-z]){1,7}/', $string, $matches);
        if (!$matchResult) {
            return "g";
        }
        return trim($matches[0]);
    }

    /**
     * @return String
     */
    public function Title()
    {
        return $this->getTitle();
    }
    public function getTitle()
    {
        $string = $this->ProfileName;

The property ProfileName does not exist on object<NutriHolder>. Since you implemented __set, maybe consider adding a @property annotation.

        if (!$string) {
            $string = 'Profile #'.$this->ID.' (please customise) ';
        }
        $string .= ': ';
        $string .= "serving: ".$this->ServingCount."; ";

The property ServingCount does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

        $string .= "size: ".$this->ServingSize."; ";

The property ServingSize does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

        $string .= "container: ".$this->Container."; ";

The property Container does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

        return $string;
    }

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'Title' => 'Title',
    );

    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        'ProfileName' => 'PartialMatchFilter',
        'ServingCount' => 'ExactMatchFilter',
        'Container' => 'PartialMatchFilter',
        'ServingSize' => 'ExactMatchFilter',
        'AdditionalInfo' => 'PartialMatchFilter',
        'AdditionalInfo' => 'PartialMatchFilter'
    );

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $config = GridFieldConfig_RelationEditor::create();
        $config->addComponent(new GridFieldSortableRows('SortOrder'));

        $fields->addFieldsToTab(
            'Root.Main',
            array(
                NumericField::create('ServingCount', 'Servings per package')
                    ->setRightTitle('The number of servings in the jar/bucket/bottle/conatiner'),
                TextField::create('Container', 'The product container')
                    ->setRightTitle('The conatiner for the product e.g. Jar, Bottle, Bucket'),
                TextField::create('ServingSize', 'The size of each serving')
                    ->setRightTitle('The size of each serving e.g., 3g, 30ml'),
                TextField::create('AdditionalInfo', 'Additional information')
                    ->setRightTitle('For example "Remove label with care."'),
            )
        );

        $productsGrid = $fields->dataFieldByName('Products');
        if ($productsGrid) {
            $productsFieldConfig = GridFieldConfig_RecordViewer::create();
            $productsGrid -> setConfig($productsFieldConfig);

The method setConfig() does not exist on FormField. Did you maybe mean config()?

        }

        $productVariationsGrid = $fields->dataFieldByName('ProductVariations');
        if ($productVariationsGrid) {
            $productVariationsConfig = GridFieldConfig_RecordViewer::create();
            $productVariationsGrid -> setConfig($productVariationsConfig);

The method setConfig() does not exist on FormField. Did you maybe mean config()?

        }

        $nutriRowsGridField = $fields->dataFieldByName('NutriRows');

        if ($nutriRowsGridField) {
            $nutriRowsFieldConfig = $nutriRowsGridField ->getConfig();

The method getConfig() does not exist on FormField. Did you maybe mean config()?

            $nutriRowsFieldConfig
                ->addComponent(new GridFieldEditableColumns())
                ->addComponent(new GridFieldDeleteAction())
                ->addComponent(new GridFieldSortableRows('SortOrder'))
                ->getComponentByType('GridFieldEditableColumns')

                ->setDisplayFields(
                    array(
                        'Title' => array(
                            'title' => 'Item',
                            'field' => 'ReadonlyField'
                        ),
                        'PerServe'  => array(
                            "title" => "Per Serve",
                            "callback" => function ($record, $column, $grid) {

The parameter $grid is not used and could be removed.

                                return new TextField($column, "Serve");
                            }),

                        'Per100' => function ($record, $column, $grid) {

The parameter $grid is not used and could be removed.

                            return new TextField($column, "Per 100");
                        }

                    )
                );
        }
        $fields->removeFieldFromTab('Root.Main', 'SortOrder');

        return $fields;
    }

    /**
     * @return DataList
     */
    public function ShownNutriRows()
    {
        return $this->NutriRows()

The method NutriRows() does not exist on NutriHolder. Did you maybe mean ShownNutriRows()?

            ->exclude(array("Hide" => 1));
    }

    /**
     * @return DataList

Should the return type not be integer?

     */
    public function NumberOfTableColums()
    {
        $tablesCols = 4;
        if ($this->HidePerServeColumn) {

The property HidePerServeColumn does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

            $tablesCols--;
        }
        if ($this->HidePer100gColumn) {

The property HidePer100gColumn does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

            $tablesCols--;
        }
        if ($this->HidePerDVColumn) {

The property HidePerDVColumn does not exist on object<NutriHolder>. Since you implemented __get, maybe consider adding a @property annotation.

            $tablesCols--;
        }
        return $tablesCols;
    }
}