EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes::campaignMonitorPage() - Code Metrics - sunnysideup/silverstripe-ecommerce_newsletter_campaign_monitor - Measure and Improve Code Quality continuously with Scrutinizer

campaignMonitorPage() A
last analyzed 2018-06-20 01:16 UTC

↳ Parent: EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0

<?php


class EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes extends Extension
namespace YourVendor;

class YourClass { }
{
    private static $fields_to_hide = array(

        "FirstName",
        "Surname",
        "SubscribeChoice"
    );
    /**
     *
     * @var CampaignMonitorAPIConnector
     */
    private static $_api = null;

    /**
     *
     * @return CampaignMonitorAPIConnector
     */
    public function getAPI()
    {
        if (!self::$_api) {
            self::$_api = CampaignMonitorAPIConnector::create();
            self::$_api->init();
        }
        return self::$_api;
    }

    public function updateFields(FieldList $fields)
    {
        if ($this->hasCampaignMonitorPage()) {
            $page = $this->CampaignMonitorPage();
            if ($page->ReadyToReceiveSubscribtions()) {
                // Create fields
                $member = Member::currentUser();
                $api = $this->getAPI();
                $currentValues = $api->getSubscriber($page->ListID, $member);
                if (!$currentValues) {
                    $emailField = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    $emailRequired = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                }
                if (!$member) {
                    $member = new Member();
                }
                $signupField = $member->getCampaignMonitorSignupField($page->ListID, "SubscribeChoice");
                $fieldsToHide = Config::inst()->get("EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes", "fields_to_hide");
                foreach ($fieldsToHide as $field) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    Requirements::customCSS("#CMCustomField".$field." {display: none;}");
                }
                $config = EcommerceDBConfig::current_ecommerce_db_config();
                if ($config->CampaignMonitorSignupHeader) {
                    $fields->push(new HeaderField("CampaignMonitorNewsletterSignupHeader", $config->CampaignMonitorSignupHeader, 3));
                }
                if ($config->CampaignMonitorSignupIntro) {
                    $fields->push(new LiteralField("CampaignMonitorNewsletterSignupContent", "<p class=\"campaignMonitorNewsletterSignupContent\">".$config->CampaignMonitorSignupIntro."</p>"));
                }
                $label = $config->CampaignMonitorSignupLabel;
                if (!$label) {
                    $label = _t("EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes.JOIN", "Join");
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                }
                $fields->push(new CheckboxField("CampaignMonitorNewsletterSubscribeCheckBox", $config->CampaignMonitorSignupLabel));
                $fields->push($signupField);
                Requirements::customCSS("
                    #SubscribeChoice {display: none!important;}
                    .CMFieldsCustomFieldsHolder {display: none!important;}
                ");
                Requirements::customScript("jQuery(\"#CampaignMonitorNewsletterSubscribeCheckBox\").on(\"change\", function(){jQuery(\".CMFieldsCustomFieldsHolder\").slideToggle();});");
            }
        }
    }


    /**
     * adds the user to the list ...
     * @param Array $data
     * @param Form $form
     * @param Order $order

     * @param Member $member

     */
    public function saveAddressExtension($data, $form, $order = null, $member = null)

    {
        if (isset($data["CampaignMonitorNewsletterSubscribeCheckBox"]) && $data["CampaignMonitorNewsletterSubscribeCheckBox"]) {
            if ($this->hasCampaignMonitorPage()) {
                $page = $this->CampaignMonitorPage();
                if ($page->ReadyToReceiveSubscribtions()) {

                    //true until proven otherwise.
                    $newlyCreatedMember = false;
                    $api = $this->getAPI();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    $isSubscribe = isset($data["SubscribeChoice"]) && $data["SubscribeChoice"] == "Subscribe";
                    $member = Member::currentUser();
                    if (!$member) {
                        $memberAlreadyLoggedIn = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        $existingMember = Member::get()->filter(array("Email" => Convert::raw2sql($data["Email"])))->First();
                        //if($isSubscribe && $existingMember){

                        //$form->addErrorMessage('Email', _t("CAMPAIGNMONITORSIGNUPPAGE.EMAIL_EXISTS", "This email is already in use. Please log in for this email or try another email address."), 'warning');

                        //$this->redirectBack();

                        //return;
                        //}
                        $member = $existingMember;
                        if (!$member) {
                            $newlyCreatedMember = true;
                            $member = new Member();
                        }
                    }

                    //logged in: if the member already as someone else then you can't sign up.
                    else {
                        $memberAlreadyLoggedIn = true;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        //$existingMember = Member::get()

                        //	->filter(array("Email" => Convert::raw2sql($data["CampaignMonitorEmail"])))

                        //	->exclude(array("ID" => $member->ID))

                        //	->First();

                        //if($isSubscribe && $existingMember) {

                            //$form->addErrorMessage('CampaignMonitorEmail', _t("CAMPAIGNMONITORSIGNUPPAGE.EMAIL_EXISTS", "This email is already in use by someone else. Please log in for this email or try another email address."), 'warning');

                            //$this->redirectBack();

                            //return;
                        //}
                    }

                    //if this is a new member then we save the member
                    if ($isSubscribe) {
                        if ($newlyCreatedMember) {
                            $form->saveInto($member);
                            $member->Email = Convert::raw2sql($data["CampaignMonitorEmail"]);
                            $member->SetPassword = true;
                            $member->Password = Member::create_new_password();

                            $member->write();
                        }
                    }
                    $outcome = $member->processCampaignMonitorSignupField($page, $data, $form);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                }
            }
        }
    }

    /**
     * returns ID of Mailing List that people are subscribing to.
     * @return CampaignMonitorPage

     */
    protected function hasCampaignMonitorPage()
    {
        $config = EcommerceDBConfig::current_ecommerce_db_config();
        return $config->CampaignMonitorSignupPageID ? true : false;
    }

    /**
     * returns ID of Mailing List that people are subscribing to.
     * @return CampaignMonitorPage
     */
    protected function campaignMonitorPage()
    {
        $config = EcommerceDBConfig::current_ecommerce_db_config();
        return $config->CampaignMonitorSignupPage();
    }
}


1			<?php
2
3
4			class EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes extends Extension
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $fields_to_hide = array(
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report The property `$fields_to_hide` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7			"FirstName",
8			"Surname",
9			"SubscribeChoice"
10			);
11			/**
12			*
13			* @var CampaignMonitorAPIConnector
14			*/
15			private static $_api = null;
16
17			/**
18			*
19			* @return CampaignMonitorAPIConnector
20			*/
21			public function getAPI()
22			{
23			if (!self::$_api) {
24			self::$_api = CampaignMonitorAPIConnector::create();
25			self::$_api->init();
26			}
27			return self::$_api;
28			}
29
30			public function updateFields(FieldList $fields)
31			{
32			if ($this->hasCampaignMonitorPage()) {
33			$page = $this->CampaignMonitorPage();
34			if ($page->ReadyToReceiveSubscribtions()) {
35			// Create fields
36			$member = Member::currentUser();
37			$api = $this->getAPI();
38			$currentValues = $api->getSubscriber($page->ListID, $member);
39			if (!$currentValues) {
40			$emailField = null;
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$emailField` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
41			$emailRequired = true;
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$emailRequired` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42			}
43			if (!$member) {
44			$member = new Member();
45			}
46			$signupField = $member->getCampaignMonitorSignupField($page->ListID, "SubscribeChoice");
47			$fieldsToHide = Config::inst()->get("EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes", "fields_to_hide");
48			foreach ($fieldsToHide as $field) {
			0 ignored issues – show Bug introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report The expression `$fieldsToHide` of type `array\|integer\|double\|string\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
49			Requirements::customCSS("#CMCustomField".$field." {display: none;}");
50			}
51			$config = EcommerceDBConfig::current_ecommerce_db_config();
52			if ($config->CampaignMonitorSignupHeader) {
53			$fields->push(new HeaderField("CampaignMonitorNewsletterSignupHeader", $config->CampaignMonitorSignupHeader, 3));
54			}
55			if ($config->CampaignMonitorSignupIntro) {
56			$fields->push(new LiteralField("CampaignMonitorNewsletterSignupContent", "<p class=\"campaignMonitorNewsletterSignupContent\">".$config->CampaignMonitorSignupIntro."</p>"));
57			}
58			$label = $config->CampaignMonitorSignupLabel;
59			if (!$label) {
60			$label = _t("EcommerceNewsletterCampaignMonitorSignupDecoratorFormFixes.JOIN", "Join");
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$label` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
61			}
62			$fields->push(new CheckboxField("CampaignMonitorNewsletterSubscribeCheckBox", $config->CampaignMonitorSignupLabel));
63			$fields->push($signupField);
64			Requirements::customCSS("
65			#SubscribeChoice {display: none!important;}
66			.CMFieldsCustomFieldsHolder {display: none!important;}
67			");
68			Requirements::customScript("jQuery(\"#CampaignMonitorNewsletterSubscribeCheckBox\").on(\"change\", function(){jQuery(\".CMFieldsCustomFieldsHolder\").slideToggle();});");
69			}
70			}
71			}
72
73
74			/**
75			* adds the user to the list ...
76			* @param Array $data
77			* @param Form $form
78			* @param Order $order
			0 ignored issues – show Documentation introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report Should the type for parameter `$order` not be `Order\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
79			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
80			*/
81			public function saveAddressExtension($data, $form, $order = null, $member = null)
			0 ignored issues – show Unused Code introduced 2017-09-21 00:00 UTC by Report Bug Copy Issue Report The parameter `$order` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-09-21 00:00 UTC by Report Bug Copy Issue Report The parameter `$member` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
82			{
83			if (isset($data["CampaignMonitorNewsletterSubscribeCheckBox"]) && $data["CampaignMonitorNewsletterSubscribeCheckBox"]) {
84			if ($this->hasCampaignMonitorPage()) {
85			$page = $this->CampaignMonitorPage();
86			if ($page->ReadyToReceiveSubscribtions()) {
87
88			//true until proven otherwise.
89			$newlyCreatedMember = false;
90			$api = $this->getAPI();
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$api` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
91			$isSubscribe = isset($data["SubscribeChoice"]) && $data["SubscribeChoice"] == "Subscribe";
92			$member = Member::currentUser();
93			if (!$member) {
94			$memberAlreadyLoggedIn = false;
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$memberAlreadyLoggedIn` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
95			$existingMember = Member::get()->filter(array("Email" => Convert::raw2sql($data["Email"])))->First();
96			//if($isSubscribe && $existingMember){
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `78%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97			//$form->addErrorMessage('Email', _t("CAMPAIGNMONITORSIGNUPPAGE.EMAIL_EXISTS", "This email is already in use. Please log in for this email or try another email address."), 'warning');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `74%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
98			//$this->redirectBack();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
99			//return;
100			//}
101			$member = $existingMember;
102			if (!$member) {
103			$newlyCreatedMember = true;
104			$member = new Member();
105			}
106			}
107
108			//logged in: if the member already as someone else then you can't sign up.
109			else {
110			$memberAlreadyLoggedIn = true;
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$memberAlreadyLoggedIn` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
111			//$existingMember = Member::get()
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
112			// ->filter(array("Email" => Convert::raw2sql($data["CampaignMonitorEmail"])))
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
113			// ->exclude(array("ID" => $member->ID))
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
114			// ->First();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
115			//if($isSubscribe && $existingMember) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
116			//$form->addErrorMessage('CampaignMonitorEmail', _t("CAMPAIGNMONITORSIGNUPPAGE.EMAIL_EXISTS", "This email is already in use by someone else. Please log in for this email or try another email address."), 'warning');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `74%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
117			//$this->redirectBack();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
118			//return;
119			//}
120			}
121
122			//if this is a new member then we save the member
123			if ($isSubscribe) {
124			if ($newlyCreatedMember) {
125			$form->saveInto($member);
126			$member->Email = Convert::raw2sql($data["CampaignMonitorEmail"]);
127			$member->SetPassword = true;
128			$member->Password = Member::create_new_password();
			0 ignored issues – show Deprecated Code introduced 2018-06-20 01:16 UTC by Report Bug Copy Issue Report The method `Member::create_new_password()` has been deprecated with message: 3.6.0..4.0.0 This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
129			$member->write();
130			}
131			}
132			$outcome = $member->processCampaignMonitorSignupField($page, $data, $form);
			0 ignored issues – show Unused Code introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report `$outcome` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
133			}
134			}
135			}
136			}
137
138			/**
139			* returns ID of Mailing List that people are subscribing to.
140			* @return CampaignMonitorPage
			0 ignored issues – show Documentation introduced 2017-01-03 00:45 UTC by Report Bug Copy Issue Report Should the return type not be `boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
141			*/
142			protected function hasCampaignMonitorPage()
143			{
144			$config = EcommerceDBConfig::current_ecommerce_db_config();
145			return $config->CampaignMonitorSignupPageID ? true : false;
146			}
147
148			/**
149			* returns ID of Mailing List that people are subscribing to.
150			* @return CampaignMonitorPage
151			*/
152			protected function campaignMonitorPage()
153			{
154			$config = EcommerceDBConfig::current_ecommerce_db_config();
155			return $config->CampaignMonitorSignupPage();
156			}
157			}
158

sunnysideup / silverstripe-ecommerce_newsletter_campaign_monitor

campaignMonitorPage() A last analyzed 2018-06-20 01:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

campaignMonitorPage() A
last analyzed 2018-06-20 01:16 UTC