OrderStep_RecordDeviceDetails

Complexity

Total Complexity

7

Size/Duplication

Total Lines	82
Duplicated Lines	9.76 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	HideFromEveryone()	0	4	1
A	initStep()	0	4	1
A	doStep()	8	13	3
A	nextStep()	0	4	1
A	myDescription()	0	4	1

<?php

class OrderStep_RecordDeviceDetails extends OrderStep implements OrderStepInterface
{
    public function HideFromEveryone()
    {
        return true;
    }

    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

        'CustomerCanEdit' => 0,
        'CustomerCanPay' => 0,
        'CustomerCanCancel' => 0,
        'Name' => 'Record Device Details',
        'Code' => 'RECORD_DEVICE_DETAILS',
        'ShowAsInProcessOrder' => 1,
    );

    /**
     * The OrderStatusLog that is relevant to the particular step.
     *
     * @var string
     */
    protected $relevantLogEntryClassName = 'OrderStatusLog_DeviceDetails';

    /**
     * Can run this step once any items have been submitted.
     * makes sure the step is ready to run.... (e.g. check if the order is ready to be emailed as receipt).
     * should be able to run this function many times to check if the step is ready.
     *
     * @see Order::doNextStatus
     *
     * @param Order object
     *
     * @return bool - true if the current step is ready to be run...
     **/
    public function initStep(Order $order)
    {
        return true;
    }

    /**
    *
    * @param Order object
    *
    * @return bool - true if run correctly.
    **/
    public function doStep(Order $order)
    {
        $className = $this->getRelevantLogEntryClassName();
        if (class_exists($className)) {

This code seems to be duplicated across your project.

            $obj = $className::create();
            if (is_a($obj, Object::getCustomClass('OrderStatusLog'))) {
                $obj->OrderID = $order->ID;
                $obj->Title = $this->Name;

The property Name does not exist on object<OrderStep_RecordDeviceDetails>. Since you implemented __set, maybe consider adding a @property annotation.

                $obj->write();
            }
        }
        return true;
    }

    /**
     * go to next step if order has been submitted.
     *
     * @param Order $order
     *
     * @return OrderStep | Null	(next step OrderStep)

Should the return type not be OrderStep|null?

     **/
    public function nextStep(Order $order)
    {
        return parent::nextStep($order);
    }


    /**
     * Explains the current order step.
     *
     * @return string
     */
    protected function myDescription()
    {
        return _t('OrderStep.RECORDDEVICEDETAILS_DESCRIPTION', 'Records the device details of the customer placing the order.');
    }
}