DiscountCouponSiteTreeDOD

Complexity

Total Complexity

10

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	17	1
D	canBeDiscounted()	0	37	9

<?php

/**
 *
 */

class DiscountCouponSiteTreeDOD extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

The property $db is not used and could be removed.

        'PageIDs' => 'Text(700)'
    );

    /**
     * update the CMS Fields
     *
     * @param FieldList $fields
     *
     */
    public function updateCMSFields(FieldList $fields)
    {
        $label = _t(
            "DiscountCouponSiteTreeDOD.SELECT_PRODUCTS_AND_SERVICES",
            'Select Product Categories and/or Products (if nothing is selected, the discount coupon will apply to all buyables).'
        );
        $field = new DiscountCouponSiteTreeDOD_Field(
            $name = "PageIDs",
            $title = $label,
            $sourceObject = "SiteTree",
            $keyField = "ID",
            $labelField = "MenuTitle"
        );
        $filter = create_function('$obj', 'return ( ( $obj InstanceOf ProductGroup || $obj InstanceOf Product) && ($obj->ParentID != '.$this->owner->ID.'));');

The use of create_function is highly discouraged, better use a closure.

        $field->setFilterFunction($filter);
        $fields->addFieldToTab('Root.AppliesTo', $field);
    }

    /**
     * normally returns TRUE, but returns FALSE when it, or its parent is in the list.
     * todo: add products in other product categories
     *
     * @param SiteTree $page
     *
     * @return boolean
     */
    public function canBeDiscounted(SiteTree $page)
    {
        if ($this->owner->PageIDs) {
            $allowedPageIDs = explode(',', $this->owner->PageIDs);
            $checkPages = ArrayList::create([$page]);
            $alreadyCheckedPageIDs = array();
            while ($checkPages->Count()) {
                $page = $checkPages->First();
                if (array_search($page->ID, $allowedPageIDs) !== false) {
                    return true;
                }
                $alreadyCheckedPageIDs[] = $page->ID;
                $checkPages->remove($page);

                // Parents list update
                if ($page->hasMethod('AllParentGroups')) {
                    $parents = ArrayList::create($page->AllParentGroups()->toArray());
                } else {
                    $parents = ArrayList::create();
                }

                $parent = $page->Parent();
                if ($parent && $parent->exists()) {
                    $parents->unshift($parent);
                }

                foreach ($parents as $parent) {
                    if (array_search($parent->ID, $alreadyCheckedPageIDs) === false) {
                        $checkPages->push($parent);
                    }
                }
                $checkPages->removeDuplicates();
            }
            return false;
        }
        return true;
    }
}