PickUpOrDeliveryModifier_Form

Complexity

Total Complexity

6

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	processOrderModifier()	0	20	6

<?php


class PickUpOrDeliveryModifier_Form extends OrderModifierForm

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function processOrderModifier($data, $form = null)

The return type could not be reliably inferred; please add a @return annotation.

The parameter $form is not used and could be removed.

    {
        if (isset($data['PickupOrDeliveryType'])) {
            $newOption = intval($data['PickupOrDeliveryType']);
            $newOptionObj = PickUpOrDeliveryModifierOptions::get()->byID($newOption);
            if ($newOptionObj) {
                $order = ShoppingCart::current_order();
                if ($order) {
                    if ($modifiers = $order->Modifiers("PickUpOrDeliveryModifier")) {
                        foreach ($modifiers as $modifier) {
                            $modifier->setOption($newOption);
                            $modifier->runUpdate();
                        }
                        return ShoppingCart::singleton()->setMessageAndReturn(_t("PickUpOrDeliveryModifier.UPDATED", "Delivery option updated"), "good");
                    }
                }
            }
        }
        return ShoppingCart::singleton()->setMessageAndReturn(_t("PickUpOrDeliveryModifier.UPDATED", "Delivery option could NOT be updated"), "bad");
    }
}