EcommerceDashboardPanel_IncompletePayments

Complexity

Total Complexity

9

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getLabelPrefix()	0	4	1
A	getConfiguration()	0	6	1
A	Content()	0	14	1
A	calculateOnDaysback()	0	21	3
A	formatContentSection()	0	17	3

<?php


class EcommerceDashboardPanel_IncompletePayments extends EcommerceDashboardPanel

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "ecommerce_dashboard/images/icons/EcommerceDashboardPanel_IncompletePayments.png";

Consider using a different property name as you override a private property of the parent class.

The property $icon is not used and could be removed.

    public function getLabelPrefix()
    {
        return 'Incomplete payments';
    }

    public function getConfiguration()
    {
        $fields = parent::getConfiguration();

        return $fields;
    }

    public function Content()
    {
        $html = '';
        $daysBack = $this->calculatedDaysBack();

The method calculatedDaysBack does not exist on object<EcommerceDashboardPanel_IncompletePayments>? Since you implemented __call, maybe consider adding a @method annotation.

        $data = $this->calculateOnDaysback($daysBack);
        $html .= $this->formatContentSection($daysBack, $data);

        $daysBack = 9999;
        $data = $this->calculateOnDaysback($daysBack);
        $html .= $this->formatContentSection($daysBack, $data);

        return $html;

    }

    protected function calculateOnDaysback($daysBack)
    {
        $allPayments = EcommercePayment::get()
            ->where('"EcommercePayment"."LastEdited" > ( NOW() - INTERVAL '.($daysBack).' DAY )');
        $list = $allPayments->column('Status');
        $total = count($list);
        $totals = [];
        foreach($list as $status) {
            if(!isset($totals[$status])) {
                $totals[$status] = 0;
            }
            $totals[$status]++;
        }
        $data = [
            'Total' => $total,
            'Totals' => $totals
        ];

        return $data;

    }

    protected function formatContentSection($daysBack, $data)
    {
        if($daysBack > 1000) {
            $html = '<h4 style="padding-top: 30px; clear: both;">From the beginning of time:</h4>';
        } else {
            $html = '<h4>Last '.$daysBack.' days:</h4>';
        }
        $html .= '<dl>';
        foreach($data['Totals'] as $name => $count) {
            $percentage = round($count / $data['Total'], 2) * 100;
            $html .= '
            <dt>'.$name.'</dt>
            <dd>'.$count.' × = '.$percentage.'%</dd>';
        }

        return $html;
    }

}