EcommerceDashboardPanel_OrderStep

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getLabelPrefix()	0	4	1
A	getConfiguration()	0	6	1
A	Content()	0	21	4
A	onBeforeWrite()	0	5	1

<?php

class EcommerceDashboardPanel_OrderStep extends EcommerceDashboardPanel

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "ecommerce_dashboard/images/icons/EcommerceDashboardPanel_OrderStep.png";

Consider using a different property name as you override a private property of the parent class.

The property $icon is not used and could be removed.

    public function getLabelPrefix()
    {
        return 'Order Journey';
    }

    public function getConfiguration()
    {
        $fields = parent::getConfiguration();
        $fields->replaceField('DaysBack', HiddenField::create('DaysBack', 'DaysBack'));
        return $fields;
    }

    public function Content()
    {
        $html = '';

$html is not used, you could remove the assignment.

        $orderSteps = OrderStep::get()->limit(OrderStep::get()->count()-1);
        $html = '<ul>';
        $done = false;
        foreach ($orderSteps as $orderStep) {
            $count = Order::get()
                ->filter(array('StatusID' => $orderStep->ID, 'CancelledByID' => 0))
                ->count();
            if ($count > 0) {
                $done = true;
                $html .= '<li><strong>'.$orderStep->Title.'</strong>: <span>'.$count.'</span><em>'.$orderStep->Description.'</em></li>';
            }
        }
        if ($done === false) {
            $html .= '<li>All orders have been archived</li>';
        }
        $html .= '<ul>';
        return $html;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->DaysBack = 0;

The property DaysBack does not exist on object<EcommerceDashboardPanel_OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

    }
}