EcommerceDashboardPanel_FavouriteProducts

Complexity

Total Complexity

13

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getLabelPrefix()	0	4	1
A	getTitle()	0	4	1
A	getConfiguration()	0	6	1
B	Content()	0	44	10

<?php

class EcommerceDashboardPanel_FavouriteProducts extends EcommerceDashboardPanel

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "ecommerce_dashboard/images/icons/EcommerceDashboardPanel_FavouriteProducts.png";

Consider using a different property name as you override a private property of the parent class.

The property $icon is not used and could be removed.

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'NumberOfProducts' => 'Int'
    );

    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        'NumberOfProducts' => 7
    );

    public function getLabelPrefix()
    {
        return 'Favourite sellers';
    }

    public function getTitle()
    {
        return parent::getTitle();
    }

    public function getConfiguration()
    {
        $fields = parent::getConfiguration();
        $fields->push(NumericField::create('NumberOfProducts', 'Number of products to show'));
        return $fields;
    }

    public function Content()
    {
        $submittedOrders = $this->submittedOrders();
        $html = '
            <ul>';
        $buyableArray = array();
        $count = $submittedOrders->count();
        if ($count < $this->maxOrdersForLoop() && $count > 0) {
            foreach ($submittedOrders as $order) {
                foreach ($order->Items() as $item) {
                    $key = $item->BuyableClassName.".".$item->BuyableID;
                    if (! isset($buyableArray[$key])) {
                        $buyableArray[$key] = 0;
                    }
                    $buyableArray[$key]++;
                }
            }
            arsort($buyableArray, SORT_NUMERIC);
            for ($i = 0; $i < $this->NumberOfProducts; $i++) {

The property NumberOfProducts does not exist on object<EcommerceDashboardPanel_FavouriteProducts>. Since you implemented __get, maybe consider adding a @property annotation.

                $oneRow = array_slice($buyableArray, $i, 1);
                foreach ($oneRow as $key => $count) {
                    list($className, $id) = explode('.', $key);
                    $buyable = $className::get()->byID($id);
                    if ($buyable) {
                        $html .= '<li class="pos'.$i.'"><span><strong>'.$count.'</strong> × </span><a href="'.$buyable->Link().'">'.$buyable->FullName.'</a></li>';
                    } else {
                        $html .= '<li class="pos'.$i.'">Error with '.$key.'</li>';
                    }
                }
            }
        } elseif ($count >= $this->maxOrdersForLoop()) {
            $html .= '
                    <li>There are too many orders to work out the favourite products, please reduce the time period.</li>';
        } else {
            $html .= '
                    <li>There are no favourite sellers.</li>';
        }


        $html .= '
            </ul>';

        return $html;
    }
}