Issues in CountryPrice.php (master) - Issues in master - sunnysideup/silverstripe-ecommerce_countries - Measure and Improve Code Quality continuously with Scrutinizer

Issues (304)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/CountryPrice.php (39 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Holds prices for individual countries for
 * Buyables.
 *
 *
 */

class CountryPrice extends DataObject
{

    // CURRENCY LIST AND STATIC FUNCTIONS

    private static $db = array(

        'Price' => 'Currency',
        'Country' => 'Varchar(2)',
        'Currency' => 'Varchar(3)',
        'ObjectClass' => 'Varchar',
        'ObjectID' => 'Int'
    );

    private static $field_labels = array(

        'Currency' => 'Currency Code',
        'Country' => 'Country Code',
        'ObjectClass' => 'Buyable Name',
        'ObjectID' => 'Buyable ID'
    );
    private static $summary_fields = array(

        'BuyableName' => 'Buyable',
        'CountryName' => 'Country',
        'FullPrice' => 'Price'
    );

    private static $casting = array(

        'BuyableName' => 'Varchar',
        'Title' => 'Varchar',
        'CountryName' => 'Varchar',
        'FullPrice' => 'Varchar'
    );

    private static $indexes = array(

        'Unique' => array(
            'type' => 'unique',
            'value' => 'Country,ObjectClass,ObjectID'
        ),
        'Currency' => true
    );

    private static $searchable_fields = array(

        'Price' => 'PartialMatchFilter',
        'Country' => 'PartialMatchFilter',
        'Currency' => 'PartialMatchFilter'
    );

    /**
     * caching only variable
     * @var EcommerceCountry | null
     */
    private $_myBuyable = null;

    /**
     * the buyable we relate to
     * return DataObject | null
     */
    public function Buyable()

    {
        if (! $this->_myBuyable) {
            $className = $this->ObjectClass;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (class_exists($this->ObjectClass)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->_myBuyable = $className::get()->byID($this->ObjectID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }

        return $this->_myBuyable;
    }

    /**
     * caching only variable
     * @var EcommerceCountry | null
     */
    private $_myCountryObject = null;

    /**
     *
     * return EcommerceCountry | null
     */
    public function CountryObject()
    {
        if (! $this->_myCountryObject) {
            if ($this->Country) {

                $this->_myCountryObject =  EcommerceCountry::get()
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                    ->filter(array("Code" => $this->Country))

                    ->First();
            }
        }

        return $this->_myCountryObject;
    }

    /**
     *
     * return EcommerceCountry | null
     */
    public function CurrencyObject()
    {
        if ($this->Country) {

            return EcommerceCurrency::get()->filter(array("Code" => $this->Currency))->First();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * casted variable
     * @return String
     */
    public function getBuyableName()
    {
        if ($obj = $this->Buyable()) {
            return $obj->Title;
        }
        return "ERROR: Object not found";
    }

    /**
     * casted variable
     * @return String
     */
    public function getTitle()
    {
        return $this->getBuyableName()." // ".$this->getCountryName()."// ".$this->getFullPrice();
    }

    /**
     * casted variable
     * @return String
     */
    public function getCountryName()
    {
        return EcommerceCountry::find_title($this->Country);

    }

    /**
     * casted variable
     * returns nicely formatted price..
     * @return String
     */
    public function getFullPrice()
    {
        return "$this->Price $this->Currency" . ($this->isObsolete() ? ' (obsolete!)' : '');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        // This works only because only NZ uses NZD
        $countries = CountryPrice_EcommerceCountry::get_real_countries_list()->map('Code', 'Name')->toArray();
        unset($countries[EcommerceConfig::get('EcommerceCountry', 'default_country_code')]);
        $field = DropdownField::create('Country', 'Country', $countries);
        $fields->replaceField('Country', $field);

        if ($this->ID) {
            $fields->makeFieldReadonly('Country');
            $list = EcommerceCurrency::ecommerce_currency_list()->exclude(array("Code" => $this->Currency));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($list->count()) {
                $listArray = array($this->Currency => $this->Currency) + $list->map("Code", "Name")->toArray();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            } else {
                $listArray = array($this->Currency => $this->Currency);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            $fields->replaceField(
                'Currency',
                DropdownField::create(
                    'Currency',
                    'Currency',
                    $listArray
                )
            );
        } else {
            $fields->removeByName('Currency');
        }
        $fields->removeByName('ObjectClass');
        $fields->removeByName('ObjectID');
        if (self::$cms_object) {
            $fields->addFieldToTab("Root.Main", new HiddenField('MyObjectClass', '', self::$cms_object->ClassName));
            $fields->addFieldToTab("Root.Main", new HiddenField('MyObjectID', '', self::$cms_object->ID));
        } else {
            //to do BuyableSelectField
        }
        $buyable = $this->Buyable();
        if ($buyable && $buyable->exists()) {
            $fields->addFieldToTab(
                'Root.Main',
                $buyableLink = ReadonlyField::create(
                    'ProductOrService',
                    'Product or Service',
                    '<a href="'.$buyable->CMSEditLink().'">'.$this->getBuyableName().'</a>'
                )
            );
            $buyableLink->dontEscape = true;
        }
        $fields->addFieldsToTab(
            'Root.Debug',
            array(
                ReadonlyField::create('ObjectClass', 'ObjectClass'),
                ReadonlyField::create('ObjectID', 'ObjectID')
            )
        );
        return $fields;
    }

    private static $cms_object = null;

    //MUST KEEP
    public static function set_cms_object($o)
    {
        self::$cms_object = $o;
    }

    public function canEdit($member = null)
    {
        $canEdit = parent::canEdit();
        if (! $canEdit) {
            $member = Member::currentUser();
            $distributor = $member->Distributor();
            if ($distributor->exists()) {
                return $distributor->getComponents('Countries', "\"Code\" = '$this->Country'")->Count() > 0;

            }
        }
        return $canEdit;
    }

    /**
     * We use validate as an onBeforeWrite as well because in this case it makes sense
     * as in the validation process we add stuff...
     * @return ValidationResult
     */
    protected function validate()
    {
        $result = parent::validate();
        if (! $this->ObjectClass && isset($_REQUEST["MyObjectClass"])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (class_exists($_REQUEST["MyObjectClass"])) {
                $this->ObjectClass = Convert::raw2sql($_REQUEST["MyObjectClass"]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }
        if (! $this->ObjectID && isset($_REQUEST["MyObjectID"])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->ObjectID = intval($_REQUEST["MyObjectID"]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        //check for duplicates in case it has not been created yet...
        if (! $this->ObjectClass || ! $this->ObjectID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $result->error('Object could not be created. Please contact your developer.');
            return $result;
        }
        $currencyPerCountry = CountryPrice_EcommerceCurrency::get_currency_per_country();
        if (!isset($currencyPerCountry[$this->Country])) {

            $result->error("Can not find currency for this country '".$this->Country."'");

        }
        $this->Currency = $currencyPerCountry[$this->Country];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $duplicates = CountryPrice::get()
            ->exclude(array("ID" => $this->ID - 0))
            ->filter(array("ObjectClass" => $this->ObjectClass, "ObjectID" => $this->ObjectID, "Country" => $this->Country));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($duplicates->count()) {
            $result->error('You can not add this price for this country because a price for this country already exists.');
        }
        return $result;
    }

    /**
     * Returns if the currency is an old currency not used anymore.
     * @return Boolean

     */
    public function isObsolete()
    {
        $currencyPerCountry = CountryPrice_EcommerceCurrency::get_currency_per_country();
        if (isset($currencyPerCountry[$this->Country])) {

            return $currencyPerCountry[$this->Country] != $this->Currency;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }

    /**
     * name of session variable used to set Country
     * @var String
     */
    private static $location_param = 'Location';


    /**
     * country for user
     * @var String
     */
    private static $location_country;

    /**
     * returns Country code
     * @return string
     */
    public static function get_location_country()
    {
        return self::$location_country;
    }
}


1			<?php
2
3			/**
4			* Holds prices for individual countries for
5			* Buyables.
6			*
7			*
8			*/
9
10			class CountryPrice extends DataObject
11			{
12
13			// CURRENCY LIST AND STATIC FUNCTIONS
14
15			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
16			'Price' => 'Currency',
17			'Country' => 'Varchar(2)',
18			'Currency' => 'Varchar(3)',
19			'ObjectClass' => 'Varchar',
20			'ObjectID' => 'Int'
21			);
22
23			private static $field_labels = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
24			'Currency' => 'Currency Code',
25			'Country' => 'Country Code',
26			'ObjectClass' => 'Buyable Name',
27			'ObjectID' => 'Buyable ID'
28			);
29			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
30			'BuyableName' => 'Buyable',
31			'CountryName' => 'Country',
32			'FullPrice' => 'Price'
33			);
34
35			private static $casting = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
36			'BuyableName' => 'Varchar',

sunnysideup / silverstripe-ecommerce_countries

Issues (304)

Security Analysis not enabled

code/model/CountryPrice.php (39 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like