Issues (304)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/DistributorFAQPage.php (3 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
/**
4
 * Page where distributors can put specific information about their country.
5
 *
6
 *
7
 *
8
 */
9
10
class DistributorFAQPage extends Page
11
{
12
    private static $icon = 'mysite/images/treeicons/DistributorFAQPage';
13
14
    private static $description = 'Frequently asked questions related local distributor. You can enter country specific content that will show up here. ';
15
16
    private static $can_be_root = true;
17
18
    private static $allow_children = 'none';
19
20
    public function canCreate($member = null)
21
    {
22
        return DistributorFAQPage::get()->count() ? true : false;
23
    }
24
25
    public function getCMSFields()
0 ignored issues
show
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
26
    {
27
        $fields = parent::getCMSFields();
28
        $fields->findOrMakeTab('Root.Main')->removeByName('Content');
29
        $fields->addFieldToTab('Root.Main', HtmlEditorField::create("Content", "Default Content"));
30
        $ecommerceCountry = Injector::inst()->get("EcommerceCountry");
31
        $fields->addFieldToTab(
32
            'Root.Main',
33
            new LiteralField(
34
                "MyContent",
35
                "<p>You can edit the content for this page on <a href=\"".$ecommerceCountry->CMSEditLink()."\">each country</a>.</p>"
36
            ),
37
            "Content"
38
        );
39
        $ecommerceCountriesEntered = EcommerceCountry::get()->where("\"FAQContent\" IS NOT NULL AND \"FAQContent\" <> ''");
40
        $list = array();
41
        if ($ecommerceCountriesEntered && $ecommerceCountriesEntered->count()) {
42
            $list = $ecommerceCountriesEntered->map("ID", "Name")->toArray();
43
        }
44
        if ($list && count($list)) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $list of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
45
            $enteredForContent = implode(", ", $list);
46
        } else {
47
            $enteredForContent = "You have not entered any country specific Content yet";
48
        }
49
        $fields->addFieldToTab(
50
            'Root.Main',
51
            new ReadonlyField("CountrySpecificDetailsEnteredFor", "Country specific content has been entered for", $enteredForContent),
52
            "Content"
53
        );
54
        return $fields;
55
    }
56
}
57
58
class DistributorFAQPage_Controller extends Page_Controller
59
{
60
61
    /**
62
     * finds the country specific content
63
     *
64
     */
65
    public function getContent()
0 ignored issues
show
The return type could not be reliably inferred; please add a @return annotation.

Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a @return annotation as described here.

Loading history...
66
    {
67
        $country = CountryPrice_EcommerceCountry::get_distributor_country();
68
        if ($country && strlen($country->FAQContent) > 17) {
69
            return $country->FAQContent;
70
        } else {
71
            return $this->dataRecord->Content;
72
        }
73
    }
74
75
    public function Distributor()
76
    {
77
    }
78
}
79