CountryPrice_Translation

Complexity

Total Complexity

13

Size/Duplication

Total Lines	170
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
B	getCMSFields()	0	25	1
A	canCreate()	0	7	2
B	validate()	0	22	4
A	FieldsToReplace()	0	22	1
A	Link()	0	4	1
A	getLink()	0	8	2

<?php



class CountryPrice_Translation extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'Title' => 'Varchar(200)',
        'Content' => 'HTMLText',
        'WithoutTranslation' => 'Boolean'
    );

    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        'Title' => 'Page Title',
        'Content' => 'Page Content',
        'EcommerceCountryID' => 'Country',
        'WithoutTranslation' => 'Without Translation'
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'EcommerceCountry' => 'EcommerceCountry',
        'Parent' => 'SiteTree'
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'EcommerceCountry.Name' => 'Country',
        'Title' => 'Title',
        'WithoutTranslation.Nice' => 'Price Difference Only'
    );

    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        'Link' => 'Varchar'
    );

    /**
     * @var string
     */
    private static $locale_get_parameter = 'ecomlocale';

The property $locale_get_parameter is not used and could be removed.

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $singular_name = 'Translation';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $plural_name = 'Translations';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $countries = CountryPrice_EcommerceCountry::get_real_countries_list()->map()->toArray();
        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create(
                'EcommerceCountryID',
                $fields->dataFieldByName('EcommerceCountryID')->Title(),
                array('' => '-- make sure to select a country --')+$countries
            ),
            'Title'
        );
        $withoutTranslationField = $fields->dataFieldByName('WithoutTranslation');
        $fields->addFieldToTab(
            'Root.Main',
            CheckboxField::create(
                'WithoutTranslation',
                $withoutTranslationField->Title()
            )->setRightTitle('The page is <em>translated</em> for search engines because it has prices for this country. '),
            'Title'
        );
        $fields->removeFieldFromTab("Root.Main", 'ParentID');
        return $fields;
    }

    public function canCreate($member = null)
    {
        if (CountryPrice_EcommerceCountry::get_real_countries_list()->count()) {
            return parent::canCreate($member);
        }
        return false;
    }

    /**
     * {@inheritdoc}
     */
    protected function validate()
    {
        $validation = parent::validate();
        if ($validation->valid()) {
            if ($this->exists()) {
                $existing = CountryPrice_Translation::get()
                    ->exclude(array("ID" => $this->ID))
                    ->filter(
                        array(
                            "EcommerceCountryID" => $this->EcommerceCountryID,

The property EcommerceCountryID does not exist on object<CountryPrice_Translation>. Since you implemented __get, maybe consider adding a @property annotation.

                            "ParentID" => $this->ParentID

The property ParentID does not exist on object<CountryPrice_Translation>. Since you implemented __get, maybe consider adding a @property annotation.

                        )
                    );
                if ($existing->count() > 0) {
                    $validation->error(
                        'There is already an entry for this country and page'
                    );
                }
            }
        }
        return $validation;
    }

    /**
     *     'PageField' => 'Title'
     *     'TranslationField' => 'Title'
     *
     * @return ArrayList
     */
    public function FieldsToReplace()
    {
        $al = ArrayList::create();
        $al->push(
            ArrayData::create(
                array(
                    'PageField' => 'Title',
                    'TranslationField' => 'Title'
                )
            )
        );
        $al->push(
            ArrayData::create(
                array(
                    'PageField' => 'Content',
                    'TranslationField' => 'Content'
                )
            )
        );
        $this->extend('updateFieldsToReplace', $al);
        return $al;
    }

    /**
     * @return string
     */
    function Link()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->getLink();
    }

    /**
     * @return string
     */
    function getLink()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $link = $this->Parent()->Link();

The method Parent() does not exist on CountryPrice_Translation. Did you maybe mean parentClass()?

        if($this->EcommerceCountryID) {

The property EcommerceCountryID does not exist on object<CountryPrice_Translation>. Since you implemented __get, maybe consider adding a @property annotation.

            $link .= '?'.$this->Config()->get('locale_get_parameter').'='.$this->EcommerceCountry()->Code;

The method EcommerceCountry does not exist on object<CountryPrice_Translation>? Since you implemented __call, maybe consider adding a @method annotation.

        }
        return Director::absoluteURL($link);
    }
}