sunnysideup / silverstripe-ecommerce_countries

code/control/cms/CountryPrice_DistributorManagementTool.php

Spacing +28 added lines, -28 removed lines

@@ -69,7 +69,7 @@ 
                         return $this->redirect(CountryPrices_ChangeCountryController::new_country_link($distributorPrimaryCountryCode));
                     }
                 } else {
-                    die("ERROR: No primary country has been set for this ".  _t('Distributor.SINGULAR_NAME', 'Distributor') .".");
+                    die("ERROR: No primary country has been set for this "._t('Distributor.SINGULAR_NAME', 'Distributor').".");
                 }
             }
             if ($countries && $countries->count()) {
@@ -77,7 +77,7 @@ 
             }
         }
         if (!$canViewAndEdit) {
-            Security::permissionFailure($this, 'Please log in first or log in as a '. _t('Distributor.SINGULAR_NAME', 'Distributor'). '.');
+            Security::permissionFailure($this, 'Please log in first or log in as a '._t('Distributor.SINGULAR_NAME', 'Distributor').'.');
         }
     }
 
@@ -106,7 +106,7 @@ 
         $fields['Price'] = 'Price';
 
         foreach ($fields as $field) {
-            if (! isset($_REQUEST[$field])) {
+            if (!isset($_REQUEST[$field])) {
                 return "$field value missing";
             }
         }
@@ -121,13 +121,13 @@ 
                 $valid = true;
             }
         }
-        if (! $valid) {
+        if (!$valid) {
             return 'ObjectClass value incorrect';
         }
 
         $objectID = intval($_REQUEST['ObjectID']);
         $object = $objectClass::get()->byID($objectID);
-        if (! $object) {
+        if (!$object) {
             return 'ObjectID value incorrect';
         }
 
@@ -143,12 +143,12 @@ 
             $valid = true;
             if ($this->distributor) {
                 $countries = $this->distributor->Countries()->map('Code', 'Code')->toArray();
-                if (! in_array($countryCode, $countries)) {
+                if (!in_array($countryCode, $countries)) {
                     $valid = false;
                 }
             }
         }
-        if (! $valid) {
+        if (!$valid) {
             return 'Country value incorrect';
         }
 
@@ -158,7 +158,7 @@ 
         }
 
         $price = $_REQUEST['Price'];
-        if (! is_numeric($price)) {
+        if (!is_numeric($price)) {
             return 'Price value incorrect';
         }
 
@@ -179,13 +179,13 @@ 
      */
     public function setobjectfield()
     {
-        if (isset($_REQUEST["F"]) && $_REQUEST["F"]== "TESTONLY") {
+        if (isset($_REQUEST["F"]) && $_REQUEST["F"] == "TESTONLY") {
             return "THIS IS FOR TESTING ONLY";
         }
         // 1) Check that all parameters have been specified
 
         foreach (array('T', 'I', 'F', 'V') as $field) {
-            if (! isset($_REQUEST[$field])) {
+            if (!isset($_REQUEST[$field])) {
                 return "$field value missing";
             }
         }
@@ -195,7 +195,7 @@ 
         $result = 1; // Updated
 
         $objectClass = $_REQUEST['T'];
-        if (! class_exists($objectClass)) {
+        if (!class_exists($objectClass)) {
             return 'ObjectClass value incorrect';
         }
 
@@ -207,7 +207,7 @@ 
         } elseif (intval($objectID)) {
             $objectID = intval($objectID);
             $object = $objectClass::get()->byID($objectID);
-            if (! $object) {
+            if (!$object) {
                 return 'ObjectID (ID: $objectID, Class Name: $objectClass) value incorrect';
             }
         } else {
@@ -221,7 +221,7 @@ 
         $fieldName = Convert::raw2sql($_REQUEST['F']);
         $value = $_REQUEST['V'];
 
-        if ($fieldName == 'Price' && (! is_numeric($value) || $value < 0)) {
+        if ($fieldName == 'Price' && (!is_numeric($value) || $value < 0)) {
             return 'Price value incorrect';
         }
         if ($value == '0') {
@@ -333,7 +333,7 @@ 
                 }
                 if (Permission::check("ADMIN")) {
                     $html .= $this->createEditNode(
-                        "Default " . _t('Distributor.SINGULAR_NAME', 'Distributor'),
+                        "Default "._t('Distributor.SINGULAR_NAME', 'Distributor'),
                         $distributor->IsDefault ? "YES" : "NO"
                     );
                 }
@@ -342,7 +342,7 @@ 
                 $countryList = array();
                 $countries = $distributor->Countries();
                 foreach ($countries as $country) {
-                    $countryList[] = $country->Name . ($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
+                    $countryList[] = $country->Name.($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
                 }
                 $html .= $this->createEditNode(
                     'Countries',
@@ -424,7 +424,7 @@ 
                 $data = array('T' => 'EcommerceCountry', 'I' => $country->ID);
                 $distributorName = $country->Distributor()->Name;
                 if (!$distributorName) {
-                    $distributorName = "<p class=\"message bad\">No ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." has been assigned to this country.</p>";
+                    $distributorName = "<p class=\"message bad\">No "._t('Distributor.SINGULAR_NAME', 'Distributor')." has been assigned to this country.</p>";
                 }
                 $html .= $this->createTreeNode($country->Code." - ".$country->Name, $country->Code, array($country));
                 $distributorTitlePlural = _t('Distributor.PLURAL_NAME', 'Distributor');
@@ -441,15 +441,15 @@ 
                 $html .= $this->closeTreeNode();
             }
         }
-        $countries =  EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 0));
+        $countries = EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 0));
         if ($countries && $countries->count()) {
             $list = implode(", ", $countries->map("ID", "Code")->toArray());
-            $html .= $this->createEditNode("Countries without a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." that allow sales", $list);
+            $html .= $this->createEditNode("Countries without a "._t('Distributor.SINGULAR_NAME', 'Distributor')." that allow sales", $list);
         }
-        $countries =  EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 1));
+        $countries = EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 1));
         if ($countries && $countries->count()) {
             $list = implode(", ", $countries->map("ID", "Code")->toArray());
-            $html .= $this->createEditNode("Countries without a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." that do not allow sales", $list);
+            $html .= $this->createEditNode("Countries without a "._t('Distributor.SINGULAR_NAME', 'Distributor')." that do not allow sales", $list);
         }
         return $html;
     }
@@ -470,7 +470,7 @@ 
         $defaultPriceText = ' (N.B. This is default for new variations ONLY - set actual prices under variations)';
         if ($products && $products->count()) {
             foreach ($products as $product) {
-                $withDefaultPrices = Permission::check('ADMIN') || (! $product->hasVariations());
+                $withDefaultPrices = Permission::check('ADMIN') || (!$product->hasVariations());
                 $html .= $this->createTreeNode($product->FullName, "pricing", array($product));
 
                 //country exceptions
@@ -492,7 +492,7 @@ 
                     //only show default price for ShopAdmin
                     if ($withDefaultPrices) {
                         $html .= $this->createEditNode(
-                            'Default Price' . ($product->hasVariations() ? $defaultPriceText : ''),
+                            'Default Price'.($product->hasVariations() ? $defaultPriceText : ''),
                             EcommercePayment::site_currency(),
                             $product->Price,
                             array(
@@ -508,7 +508,7 @@ 
                 $outstandingCountries = $this->countryArray;
                 if ($withDefaultPrices) {
                     $html .= $this->createTreeNode(
-                        'Country Prices' . ($product->hasVariations() ? $defaultPriceText : ''),
+                        'Country Prices'.($product->hasVariations() ? $defaultPriceText : ''),
                         " pricing countryPrices"
                     );
                 }
@@ -532,7 +532,7 @@ 
                             $countryName = EcommerceCountry::find_title($countryPricesObject->Country);
                             if ($withDefaultPrices) {
                                 $html .= $this->createEditNode(
-                                    $countryPricesObject->Country . ' - '. $countryName,
+                                    $countryPricesObject->Country.' - '.$countryName,
                                     $countryPricesObject->Currency,
                                     $countryPricesObject->Price,
                                     $data,
@@ -566,7 +566,7 @@ 
                         $countryName = EcommerceCountry::find_title($countryCode);
                         if ($withDefaultPrices) {
                             $html .= $this->createEditNode(
-                                $countryCode . ' - '. $countryName,
+                                $countryCode.' - '.$countryName,
                                 $currencyObject->Code,
                                 $addText,
                                 $data,
@@ -619,8 +619,8 @@ 
                                                 "F" => "Price"
                                             );
                                             $countryName = EcommerceCountry::find_title($countryPricesObject->Country);
-                                            $html .=  $this->createEditNode(
-                                                $countryPricesObject->Country . ' - '. $countryName,
+                                            $html .= $this->createEditNode(
+                                                $countryPricesObject->Country.' - '.$countryName,
                                                 $countryPricesObject->Currency,
                                                 $countryPricesObject->Price,
                                                 $data,
@@ -666,7 +666,7 @@ 
                                         );
                                         $countryName = EcommerceCountry::find_title($countryCode);
                                         $html .= $this->createEditNode(
-                                            $countryCode . ' - '. $countryName,
+                                            $countryCode.' - '.$countryName,
                                             $currency->Code,
                                             $addText,
                                             $data,

code/model/money/CountryPrice_EcommerceCurrency.php

Spacing +4 added lines, -4 removed lines

@@ -44,10 +44,10 @@ 
             $currencyCode = isset($currencyPerCountry[$countryCode]) ? $currencyPerCountry[$countryCode] : EcommerceCurrency::default_currency_code();
             $currencyDO = EcommerceCurrency::get_one_from_code($currencyCode);
         }
-        if (! $currencyDO) {
+        if (!$currencyDO) {
             $currencyDO = EcommerceCurrency::create_new($currencyCode);
         }
-        if (! $currencyDO) {
+        if (!$currencyDO) {
             $currencyDO = EcommerceCurrency::get_default();
         }
         return $currencyDO;
@@ -67,7 +67,7 @@ 
     {
         $cachekey = "EcommerceCurrencyCountryMatrix";
         $cache = SS_Cache::factory('CountryPrice_EcommerceCurrency');
-        if (! ($serializedArray = $cache->load($cachekey))) {
+        if (!($serializedArray = $cache->load($cachekey))) {
             $countries = CountryPrice_EcommerceCountry::get_real_countries_list();
             $unserializedArray = array();
             $defaultCurrencyCode = EcommerceCurrency::default_currency_code();
@@ -130,7 +130,7 @@ 
             return null;
         }
         $key = $this->owner->ClassName.'____'.$countryCode;
-        if (! isset(self::$_money_object_currency[$key])) {
+        if (!isset(self::$_money_object_currency[$key])) {
             if (is_null($currencyCode)) {
                 $currency = CountryPrice_EcommerceCurrency::get_currency_for_country($countryCode);
                 if ($currency) {

code/model/address/CountryPrice_EcommerceCountry.php

Spacing +6 added lines, -6 removed lines

@@ -88,7 +88,7 @@ 
                     'Root.FAQPage',
                     new LiteralField(
                         "FAQPageExplanation",
-                        "<p class=\"message warning\">FAQ information can only be added to the main country for a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ."</p>"
+                        "<p class=\"message warning\">FAQ information can only be added to the main country for a "._t('Distributor.SINGULAR_NAME', 'Distributor')."</p>"
                     )
                 );
             }
@@ -210,7 +210,7 @@ 
             $originalCountry = $country;
 
             //no country provided
-            if (! $country) {
+            if (!$country) {
                 $urlCountryCode = CountryPrice_Translation::get_country_url_provider()->CurrentCountrySegment();
 
                 // 2. CHECK WHAT THE SYSTEM THINKS THE COUNTRY CHOULD BE
@@ -225,7 +225,7 @@ 
                 }
 
                 //if we still dont have a country then we use the standard e-commerce methods ...
-                if (! $countryCode) {
+                if (!$countryCode) {
                     $countryCode = EcommerceCountry::get_country();
                 }
 
@@ -244,7 +244,7 @@ 
                     if (
                             ($country && $country->Code !== $urlCountryCode)
                         ||
-                            ! $country
+                            !$country
 
                     ) {
                         $country = DataObject::get_one('EcommerceCountry', ['Code' => $urlCountryCode]);
@@ -314,9 +314,9 @@ 
     public static function get_backup_country()
     {
         $obj = EcommerceCountry::get()->filter(array("IsBackupCountry" => true))->first();
-        if (! $obj) {
+        if (!$obj) {
             $obj = EcommerceCountry::get()->filter(array("Code" => EcommerceConfig::get('EcommerceCountry', 'default_country_code')))->first();
-            if (! $obj) {
+            if (!$obj) {
                 $obj = EcommerceCountry::get()->first();
             }
         }

Doc Comments +4 added lines

@@ -303,6 +303,10 @@
         return self::$_get_real_country_cache[$cacheKey];
     }
 
+    /**
+     * @param string $countryOrCountryCodeA
+     * @param string $countryOrCountryCodeB
+     */
     public static function countries_belong_to_same_group($countryOrCountryCodeA, $countryOrCountryCodeB)
     {
         $countryA = EcommerceCountry::get_country_from_mixed_var($countryOrCountryCodeA);

Indentation +3 added lines, -3 removed lines

@@ -168,9 +168,9 @@
     }
 
     /**
-    * checks if the country has a distributor
-    * and returns the primary country for the distributor.
-    * If not, returns the default country.
+     * checks if the country has a distributor
+     * and returns the primary country for the distributor.
+     * If not, returns the default country.
      *
      * @return EcommerceCountry
      *

code/control/CountryPrice_ChangeCountryController.php

Spacing +5 added lines, -5 removed lines

@@ -85,7 +85,7 @@ 
 
         //redirect now
         if (isset($_GET['force']) && $_GET['force']) {
-            return $this->redirect($this->Link($newCountryCode) . '?force-back-home');
+            return $this->redirect($this->Link($newCountryCode).'?force-back-home');
         }
         if (isset($_GET['force-back-home']) && $_GET['force-back-home']) {
             return $this->redirect(Director::baseURL('/'));
@@ -106,7 +106,7 @@ 
             $action
         );
 
-        return $link . '/';
+        return $link.'/';
     }
 
     /**
@@ -160,10 +160,10 @@ 
 
             $path = isset($parsedUrl['path']) ? $parsedUrl['path'] : '';
 
-            $query = empty($query) ? '' :  '?'. http_build_query($query);
+            $query = empty($query) ? '' : '?'.http_build_query($query);
             $newURL =
-                $parsedUrl['scheme'] .
-                '://' .
+                $parsedUrl['scheme'].
+                '://'.
                 Controller::join_links(
                     $parsedUrl['host'],
                     $parsedUrl['path']

code/api/CountryURLProvider.php

Spacing +3 added lines, -3 removed lines

@@ -92,14 +92,14 @@
             }
             $parsedUrl['path'] = implode('/', $pathParts);
             $newURL =
-                $parsedUrl['scheme'] .
-                '://' .
+                $parsedUrl['scheme'].
+                '://'.
                 Controller::join_links(
                     $parsedUrl['host'],
                     $parsedUrl['path']
                 );
             if (isset($parsedUrl['query'])) {
-                $newURL = $newURL . '?' . $parsedUrl['query'];
+                $newURL = $newURL.'?'.$parsedUrl['query'];
             }
         }
         if (trim($oldURL, '/') !== trim($newURL, '/')) {

code/model/translations/CountryPrice_Translation.php

Spacing +7 added lines, -7 removed lines

@@ -100,7 +100,7 @@ 
         $countryDropdownField = DropdownField::create(
             'EcommerceCountryID',
             $fields->dataFieldByName('EcommerceCountryID')->Title(),
-            array('' => '-- make sure to select a country --')+$countries
+            array('' => '-- make sure to select a country --') + $countries
         );
 
         // //$fields->removeFieldFromTab("Root.Main", 'ParentID');
@@ -133,7 +133,7 @@ 
                 );
             }
             if ($fields->dataFieldByName($useField)) {
-                $fields->dataFieldByName($useField)->setDescription(_t('CountryPrice_Translation.IGNORE', 'Use untranslated value for ') . $dbField);
+                $fields->dataFieldByName($useField)->setDescription(_t('CountryPrice_Translation.IGNORE', 'Use untranslated value for ').$dbField);
             }
         }
         if ($this->exists() && $this->ParentID) {
@@ -166,12 +166,12 @@ 
     {
         $validation = parent::validate();
         if ($validation->valid()) {
-            if (! $this->EcommerceCountryID) {
+            if (!$this->EcommerceCountryID) {
                 $validation->error(
                     'You can not create a translation without seleting a country.'
                 );
             }
-            if (! $this->ParentID) {
+            if (!$this->ParentID) {
                 $validation->error(
                     'You can not create a translation without attaching it to a page.'
                 );
@@ -221,7 +221,7 @@ 
         );
         $this->extend('updateFieldsToReplace', $al);
         foreach ($al as $fieldToReplace) {
-            $ignoreField = 'UseOriginal' . $fieldToReplace->PageField;
+            $ignoreField = 'UseOriginal'.$fieldToReplace->PageField;
             if (!empty($this->owner->$ignoreField)) {
                 $al->remove($fieldToReplace);
             }
@@ -278,7 +278,7 @@ 
                                     'ParentID' => $buyable->ID
                                 );
                                 $ecommerceCountries[$countryObject->ID] = $countryObject;
-                                if (! CountryPrice_Translation::get()->filter($filter)->first()) {
+                                if (!CountryPrice_Translation::get()->filter($filter)->first()) {
                                     DB::alteration_message(
                                         'Creating fake translation for '.$buyable->Title.' for country '.$countryObject->Code,
                                         'created'
@@ -299,7 +299,7 @@ 
                             'EcommerceCountryID' => $countryObject->ID,
                             'ParentID' => $productGroup->ID
                         );
-                        if (! CountryPrice_Translation::get()->filter($filter)->first()) {
+                        if (!CountryPrice_Translation::get()->filter($filter)->first()) {
                             DB::alteration_message(
                                 'Creating fake translation for '.$productGroup->Title.' for country '.$countryObject->Code,
                                 'created'