Passed
Push — master ( e83a6e...cf5bc3 )
by
unknown
02:40
created
code/model/translations/CountryPrice_Translation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         $countryDropdownField = DropdownField::create(
99 99
             'EcommerceCountryID',
100 100
             $fields->dataFieldByName('EcommerceCountryID')->Title(),
101
-            array('' => '-- make sure to select a country --')+$countries
101
+            array('' => '-- make sure to select a country --') + $countries
102 102
         );
103 103
 
104 104
         // //$fields->removeFieldFromTab("Root.Main", 'ParentID');
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
                 );
132 132
             }
133 133
             if ($fields->dataFieldByName($useField)) {
134
-                $fields->dataFieldByName($useField)->setDescription(_t('CountryPrice_Translation.IGNORE', 'Use untranslated value for ') . $dbField);
134
+                $fields->dataFieldByName($useField)->setDescription(_t('CountryPrice_Translation.IGNORE', 'Use untranslated value for ').$dbField);
135 135
             }
136 136
         }
137 137
         if ($this->exists() && $this->ParentID) {
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
         );
211 211
         $this->extend('updateFieldsToReplace', $al);
212 212
         foreach ($al as $fieldToReplace) {
213
-            $ignoreField = 'UseOriginal' . $fieldToReplace->PageField;
213
+            $ignoreField = 'UseOriginal'.$fieldToReplace->PageField;
214 214
             if (!empty($this->owner->$ignoreField)) {
215 215
                 $al->remove($fieldToReplace);
216 216
             }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
                                     'ParentID' => $buyable->ID
262 262
                                 );
263 263
                                 $ecommerceCountries[$countryObject->ID] = $countryObject;
264
-                                if (! CountryPrice_Translation::get()->filter($filter)->first()) {
264
+                                if (!CountryPrice_Translation::get()->filter($filter)->first()) {
265 265
                                     DB::alteration_message(
266 266
                                         'Creating fake translation for '.$buyable->Title.' for country '.$countryObject->Code,
267 267
                                         'created'
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
                             'EcommerceCountryID' => $countryObject->ID,
283 283
                             'ParentID' => $productGroup->ID
284 284
                         );
285
-                        if (! CountryPrice_Translation::get()->filter($filter)->first()) {
285
+                        if (!CountryPrice_Translation::get()->filter($filter)->first()) {
286 286
                             DB::alteration_message(
287 287
                                 'Creating fake translation for '.$productGroup->Title.' for country '.$countryObject->Code,
288 288
                                 'created'
Please login to merge, or discard this patch.
code/model/process/extensions/CountryPrice_OrderDOD.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
                 'Root.Country',
149 149
                 DropdownField::create(
150 150
                     'DistributorID',
151
-                     _t('Distributor.SINGULAR_NAME', 'Distributor'),
151
+                        _t('Distributor.SINGULAR_NAME', 'Distributor'),
152 152
                     array(''=> '--- Please select ---') + Distributor::get()->map()->toArray()
153 153
                 )
154 154
             );
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             if ($order->IsSubmitted()) {
63 63
                 return true;
64 64
             }
65
-            if (! $countryCode) {
65
+            if (!$countryCode) {
66 66
                 $countryCode = $order->getCountry();
67 67
             }
68 68
             $currencyObject = CountryPrice_EcommerceCurrency::get_currency_for_country($countryCode);
@@ -76,13 +76,13 @@  discard block
 block discarded – undo
76 76
             //check if the billing and shipping address have a country so that they will not be overridden by previous Orders
77 77
             //we do this to make sure that the previous address can not change the region and thereby destroy the order in the cart
78 78
             if ($billingAddress = $order->CreateOrReturnExistingAddress('BillingAddress')) {
79
-                if (! $billingAddress->Country || $force) {
79
+                if (!$billingAddress->Country || $force) {
80 80
                     $billingAddress->Country = $countryCode;
81 81
                     $billingAddress->write();
82 82
                 }
83 83
             }
84 84
             if ($shippingAddress = $order->CreateOrReturnExistingAddress('ShippingAddress')) {
85
-                if (! $shippingAddress->ShippingCountry || $force) {
85
+                if (!$shippingAddress->ShippingCountry || $force) {
86 86
                     $shippingAddress->ShippingCountry = $countryCode;
87 87
                     $shippingAddress->write();
88 88
                 }
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
             //if a country code and currency has been set then all is good
92 92
             //from there we keep it this way
93 93
             if (
94
-                $order->OriginatingCountryCode ==  $countryCode &&
94
+                $order->OriginatingCountryCode == $countryCode &&
95 95
                 $order->CurrencyUsedID == $currencyObject->ID
96 96
             ) {
97 97
                 return true;
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
                 if ($items) {
114 114
                     foreach ($items as $item) {
115 115
                         $buyable = $item->Buyable(true);
116
-                        if (! $buyable->canPurchase()) {
116
+                        if (!$buyable->canPurchase()) {
117 117
                             $item->delete();
118 118
                         }
119 119
                     }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function onAfterWrite()
162 162
     {
163
-        if (! $this->owner->DistributorID) {
163
+        if (!$this->owner->DistributorID) {
164 164
             if ($defaultDistributor = Distributor::get_default_distributor()) {
165 165
                 if ($defaultDistributor->exists()) {
166 166
                     if ($defaultDistributor->ID) {
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
     public function canEdit($member = null)
181 181
     {
182
-        if (! $member) {
182
+        if (!$member) {
183 183
             $member = Member::currentUser();
184 184
         }
185 185
         if ($member) {
Please login to merge, or discard this patch.
code/control/cms/CountryPrice_DistributorManagementTool.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
                         return $this->redirect(CountryPrices_ChangeCountryController::new_country_link($distributorPrimaryCountryCode));
70 70
                     }
71 71
                 } else {
72
-                    die("ERROR: No primary country has been set for this ".  _t('Distributor.SINGULAR_NAME', 'Distributor') .".");
72
+                    die("ERROR: No primary country has been set for this "._t('Distributor.SINGULAR_NAME', 'Distributor').".");
73 73
                 }
74 74
             }
75 75
             if ($countries && $countries->count()) {
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             }
78 78
         }
79 79
         if (!$canViewAndEdit) {
80
-            Security::permissionFailure($this, 'Please log in first or log in as a '. _t('Distributor.SINGULAR_NAME', 'Distributor'). '.');
80
+            Security::permissionFailure($this, 'Please log in first or log in as a '._t('Distributor.SINGULAR_NAME', 'Distributor').'.');
81 81
         }
82 82
     }
83 83
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
         $fields['Price'] = 'Price';
107 107
 
108 108
         foreach ($fields as $field) {
109
-            if (! isset($_REQUEST[$field])) {
109
+            if (!isset($_REQUEST[$field])) {
110 110
                 return "$field value missing";
111 111
             }
112 112
         }
@@ -121,13 +121,13 @@  discard block
 block discarded – undo
121 121
                 $valid = true;
122 122
             }
123 123
         }
124
-        if (! $valid) {
124
+        if (!$valid) {
125 125
             return 'ObjectClass value incorrect';
126 126
         }
127 127
 
128 128
         $objectID = intval($_REQUEST['ObjectID']);
129 129
         $object = $objectClass::get()->byID($objectID);
130
-        if (! $object) {
130
+        if (!$object) {
131 131
             return 'ObjectID value incorrect';
132 132
         }
133 133
 
@@ -143,12 +143,12 @@  discard block
 block discarded – undo
143 143
             $valid = true;
144 144
             if ($this->distributor) {
145 145
                 $countries = $this->distributor->Countries()->map('Code', 'Code')->toArray();
146
-                if (! in_array($countryCode, $countries)) {
146
+                if (!in_array($countryCode, $countries)) {
147 147
                     $valid = false;
148 148
                 }
149 149
             }
150 150
         }
151
-        if (! $valid) {
151
+        if (!$valid) {
152 152
             return 'Country value incorrect';
153 153
         }
154 154
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
         }
159 159
 
160 160
         $price = $_REQUEST['Price'];
161
-        if (! is_numeric($price)) {
161
+        if (!is_numeric($price)) {
162 162
             return 'Price value incorrect';
163 163
         }
164 164
 
@@ -179,13 +179,13 @@  discard block
 block discarded – undo
179 179
      */
180 180
     public function setobjectfield()
181 181
     {
182
-        if (isset($_REQUEST["F"]) && $_REQUEST["F"]== "TESTONLY") {
182
+        if (isset($_REQUEST["F"]) && $_REQUEST["F"] == "TESTONLY") {
183 183
             return "THIS IS FOR TESTING ONLY";
184 184
         }
185 185
         // 1) Check that all parameters have been specified
186 186
 
187 187
         foreach (array('T', 'I', 'F', 'V') as $field) {
188
-            if (! isset($_REQUEST[$field])) {
188
+            if (!isset($_REQUEST[$field])) {
189 189
                 return "$field value missing";
190 190
             }
191 191
         }
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
         $result = 1; // Updated
196 196
 
197 197
         $objectClass = $_REQUEST['T'];
198
-        if (! class_exists($objectClass)) {
198
+        if (!class_exists($objectClass)) {
199 199
             return 'ObjectClass value incorrect';
200 200
         }
201 201
 
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
         } elseif (intval($objectID)) {
208 208
             $objectID = intval($objectID);
209 209
             $object = $objectClass::get()->byID($objectID);
210
-            if (! $object) {
210
+            if (!$object) {
211 211
                 return 'ObjectID (ID: $objectID, Class Name: $objectClass) value incorrect';
212 212
             }
213 213
         } else {
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
         $fieldName = Convert::raw2sql($_REQUEST['F']);
222 222
         $value = $_REQUEST['V'];
223 223
 
224
-        if ($fieldName == 'Price' && (! is_numeric($value) || $value < 0)) {
224
+        if ($fieldName == 'Price' && (!is_numeric($value) || $value < 0)) {
225 225
             return 'Price value incorrect';
226 226
         }
227 227
         if ($value == '0') {
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
                 }
334 334
                 if (Permission::check("ADMIN")) {
335 335
                     $html .= $this->createEditNode(
336
-                        "Default " . _t('Distributor.SINGULAR_NAME', 'Distributor'),
336
+                        "Default "._t('Distributor.SINGULAR_NAME', 'Distributor'),
337 337
                         $distributor->IsDefault ? "YES" : "NO"
338 338
                     );
339 339
                 }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
                 $countryList = array();
343 343
                 $countries = $distributor->Countries();
344 344
                 foreach ($countries as $country) {
345
-                    $countryList[] = $country->Name . ($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
345
+                    $countryList[] = $country->Name.($country->DoNotAllowSales ? ' (Sales not allowed)' : '');
346 346
                 }
347 347
                 $html .= $this->createEditNode(
348 348
                     'Countries',
@@ -424,7 +424,7 @@  discard block
 block discarded – undo
424 424
                 $data = array('T' => 'EcommerceCountry', 'I' => $country->ID);
425 425
                 $distributorName = $country->Distributor()->Name;
426 426
                 if (!$distributorName) {
427
-                    $distributorName = "<p class=\"message bad\">No ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." has been assigned to this country.</p>";
427
+                    $distributorName = "<p class=\"message bad\">No "._t('Distributor.SINGULAR_NAME', 'Distributor')." has been assigned to this country.</p>";
428 428
                 }
429 429
                 $html .= $this->createTreeNode($country->Code." - ".$country->Name, $country->Code, array($country));
430 430
                 $distributorTitlePlural = _t('Distributor.PLURAL_NAME', 'Distributor');
@@ -441,15 +441,15 @@  discard block
 block discarded – undo
441 441
                 $html .= $this->closeTreeNode();
442 442
             }
443 443
         }
444
-        $countries =  EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 0));
444
+        $countries = EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 0));
445 445
         if ($countries && $countries->count()) {
446 446
             $list = implode(", ", $countries->map("ID", "Code")->toArray());
447
-            $html .= $this->createEditNode("Countries without a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." that allow sales", $list);
447
+            $html .= $this->createEditNode("Countries without a "._t('Distributor.SINGULAR_NAME', 'Distributor')." that allow sales", $list);
448 448
         }
449
-        $countries =  EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 1));
449
+        $countries = EcommerceCountry::get()->filter(array("DistributorID" => 0, "DoNotAllowSales" => 1));
450 450
         if ($countries && $countries->count()) {
451 451
             $list = implode(", ", $countries->map("ID", "Code")->toArray());
452
-            $html .= $this->createEditNode("Countries without a ". _t('Distributor.SINGULAR_NAME', 'Distributor') ." that do not allow sales", $list);
452
+            $html .= $this->createEditNode("Countries without a "._t('Distributor.SINGULAR_NAME', 'Distributor')." that do not allow sales", $list);
453 453
         }
454 454
         return $html;
455 455
     }
@@ -470,7 +470,7 @@  discard block
 block discarded – undo
470 470
         $defaultPriceText = ' (N.B. This is default for new variations ONLY - set actual prices under variations)';
471 471
         if ($products && $products->count()) {
472 472
             foreach ($products as $product) {
473
-                $withDefaultPrices = Permission::check('ADMIN') || (! $product->hasVariations());
473
+                $withDefaultPrices = Permission::check('ADMIN') || (!$product->hasVariations());
474 474
                 $html .= $this->createTreeNode($product->FullName, "pricing", array($product));
475 475
 
476 476
                 //country exceptions
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
                     //only show default price for ShopAdmin
493 493
                     if ($withDefaultPrices) {
494 494
                         $html .= $this->createEditNode(
495
-                            'Default Price' . ($product->hasVariations() ? $defaultPriceText : ''),
495
+                            'Default Price'.($product->hasVariations() ? $defaultPriceText : ''),
496 496
                             EcommercePayment::site_currency(),
497 497
                             $product->Price,
498 498
                             array(
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
                 $outstandingCountries = $this->countryArray;
509 509
                 if ($withDefaultPrices) {
510 510
                     $html .= $this->createTreeNode(
511
-                        'Country Prices' . ($product->hasVariations() ? $defaultPriceText : ''),
511
+                        'Country Prices'.($product->hasVariations() ? $defaultPriceText : ''),
512 512
                         " pricing countryPrices"
513 513
                     );
514 514
                 }
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
                             $countryName = EcommerceCountry::find_title($countryPricesObject->Country);
533 533
                             if ($withDefaultPrices) {
534 534
                                 $html .= $this->createEditNode(
535
-                                    $countryPricesObject->Country . ' - '. $countryName,
535
+                                    $countryPricesObject->Country.' - '.$countryName,
536 536
                                     $countryPricesObject->Currency,
537 537
                                     $countryPricesObject->Price,
538 538
                                     $data,
@@ -566,7 +566,7 @@  discard block
 block discarded – undo
566 566
                         $countryName = EcommerceCountry::find_title($countryCode);
567 567
                         if ($withDefaultPrices) {
568 568
                             $html .= $this->createEditNode(
569
-                                $countryCode . ' - '. $countryName,
569
+                                $countryCode.' - '.$countryName,
570 570
                                 $currencyObject->Code,
571 571
                                 $addText,
572 572
                                 $data,
@@ -619,8 +619,8 @@  discard block
 block discarded – undo
619 619
                                                 "F" => "Price"
620 620
                                             );
621 621
                                             $countryName = EcommerceCountry::find_title($countryPricesObject->Country);
622
-                                            $html .=  $this->createEditNode(
623
-                                                $countryPricesObject->Country . ' - '. $countryName,
622
+                                            $html .= $this->createEditNode(
623
+                                                $countryPricesObject->Country.' - '.$countryName,
624 624
                                                 $countryPricesObject->Currency,
625 625
                                                 $countryPricesObject->Price,
626 626
                                                 $data,
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
                                         );
667 667
                                         $countryName = EcommerceCountry::find_title($countryCode);
668 668
                                         $html .= $this->createEditNode(
669
-                                            $countryCode . ' - '. $countryName,
669
+                                            $countryCode.' - '.$countryName,
670 670
                                             $currency->Code,
671 671
                                             $addText,
672 672
                                             $data,
Please login to merge, or discard this patch.
code/model/money/CountryPrice_EcommerceCurrency.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,10 +44,10 @@  discard block
 block discarded – undo
44 44
             $currencyCode = isset($currencyPerCountry[$countryCode]) ? $currencyPerCountry[$countryCode] : EcommerceCurrency::default_currency_code();
45 45
             $currencyDO = EcommerceCurrency::get_one_from_code($currencyCode);
46 46
         }
47
-        if (! $currencyDO) {
47
+        if (!$currencyDO) {
48 48
             $currencyDO = EcommerceCurrency::create_new($currencyCode);
49 49
         }
50
-        if (! $currencyDO) {
50
+        if (!$currencyDO) {
51 51
             $currencyDO = EcommerceCurrency::get_default();
52 52
         }
53 53
         return $currencyDO;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     {
68 68
         $cachekey = "EcommerceCurrencyCountryMatrix";
69 69
         $cache = SS_Cache::factory('CountryPrice_EcommerceCurrency');
70
-        if (! ($serializedArray = $cache->load($cachekey))) {
70
+        if (!($serializedArray = $cache->load($cachekey))) {
71 71
             $countries = CountryPrice_EcommerceCountry::get_real_countries_list();
72 72
             $unserializedArray = array();
73 73
             $defaultCurrencyCode = EcommerceCurrency::default_currency_code();
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
             return null;
131 131
         }
132 132
         $key = $this->owner->ClassName.'____'.$countryCode;
133
-        if (! isset(self::$_money_object_currency[$key])) {
133
+        if (!isset(self::$_money_object_currency[$key])) {
134 134
             if (is_null($currencyCode)) {
135 135
                 $currency = CountryPrice_EcommerceCurrency::get_currency_for_country($countryCode);
136 136
                 if ($currency) {
Please login to merge, or discard this patch.
code/control/CountryPrice_ChangeCountryController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -102,6 +102,9 @@
 block discarded – undo
102 102
         return [];
103 103
     }
104 104
 
105
+    /**
106
+     * @param string $action
107
+     */
105 108
     public function Link($action = null)
106 109
     {
107 110
         $link = Controller::join_links(
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
         //redirect now
90 90
         if (isset($_GET['force']) && $_GET['force']) {
91
-            return $this->redirect($this->Link($newCountryCode) . '?force-back-home');
91
+            return $this->redirect($this->Link($newCountryCode).'?force-back-home');
92 92
         }
93 93
         if (isset($_GET['force-back-home']) && $_GET['force-back-home']) {
94 94
             return $this->redirect(Director::baseURL('/'));
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
             $action
110 110
         );
111 111
 
112
-        return $link . '/';
112
+        return $link.'/';
113 113
     }
114 114
 
115 115
     /**
@@ -163,10 +163,10 @@  discard block
 block discarded – undo
163 163
 
164 164
             $path = isset($parsedUrl['path']) ? $parsedUrl['path'] : '';
165 165
 
166
-            $query = !empty($query) ? '?'. http_build_query($query) : '';
166
+            $query = !empty($query) ? '?'.http_build_query($query) : '';
167 167
             $newURL =
168
-                $parsedUrl['scheme'] .
169
-                '://' .
168
+                $parsedUrl['scheme'].
169
+                '://'.
170 170
                 Controller::join_links(
171 171
                     $parsedUrl['host'],
172 172
                     $parsedUrl['path']
Please login to merge, or discard this patch.
code/api/CountryURLProvider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,14 +77,14 @@
 block discarded – undo
77 77
             }
78 78
             $parsedUrl['path'] = implode('/', $pathParts);
79 79
             $newURL =
80
-                $parsedUrl['scheme'] .
81
-                '://' .
80
+                $parsedUrl['scheme'].
81
+                '://'.
82 82
                 Controller::join_links(
83 83
                     $parsedUrl['host'],
84 84
                     $parsedUrl['path']
85 85
                 );
86 86
             if (isset($parsedUrl['query'])) {
87
-                $newURL = $newURL . '?' . $parsedUrl['query'];
87
+                $newURL = $newURL.'?'.$parsedUrl['query'];
88 88
             }
89 89
         }
90 90
         if ($oldURL !== $newURL) {
Please login to merge, or discard this patch.