CountryPrice_OrderStepDOD::updateCMSFields() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_countries - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 81fcb0...eef980 )

by Nicolaas

created 2017-03-30 02:00 UTC

CountryPrice_OrderStepDOD::updateCMSFields() B

↳ Parent: CountryPrice_OrderStepDOD

Complexity

Conditions	2
Paths	2

Size

Total Lines	38
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	38
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	25
nc	2
nop	1

<?php

/**
 * Adds individual country messages
 * for ordersteps
 *
 */

class CountryPrice_OrderStepDOD extends DataExtension
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'SendEmailToDistributor' => 'Boolean'
    );

    private static $has_many = array(

        'EcommerceOrderStepCountryDatas' => 'EcommerceOrderStepCountryData',
    );

    private static $field_labels = array(

        'EcommerceOrderStepCountryDatas' => 'Regionalisation',
    );

    /**
     * Update Fields
     * @return FieldList

     */
    public function updateCMSFields(FieldList $fields)
    {
        $owner = $this->owner;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $bccExplanation = _t(
            'CountryPrice_OrderStepDOD.BCC_EXPLANATION',
            '
                E-mails during this step (if any) will be copied to distributor?
                <br />These emails can be customised.
        ');

        $gridField = $fields->dataFieldByName('EcommerceOrderStepCountryDatas');
        $fields->removeFieldFromTab(
            'Root.EcommerceOrderStepCountryDatas',
            'EcommerceOrderStepCountryDatas'
        );
        $fields->addFieldsToTab(
            'Root.EcommerceOrderStepCountryDatas',
            array(
                CheckboxField::create(
                    'SendEmailToDistributor',
                    _t('CountryPrice_OrderStepDOD.SEND_EMAIL_TO_DISTRIBUTOR', 'BCC to Distributor')
                )->setDescription(
                    $bccExplanation
                ),
            )
        );
        if($this->owner->SendEmailToDistributor) {
            $customisation = _t(
                'CountryPrice_OrderStepDOD.CUSTOMISATION_PER_COUNTRY',
                'Customisation per country');
            $gridField->setTitle($customisation);
            $fields->addFieldsToTab(
                'Root.EcommerceOrderStepCountryDatas',
                $gridField
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }

    }

}


1			<?php
2
3			/**
4			* Adds individual country messages
5			* for ordersteps
6			*
7			*/
8
9			class CountryPrice_OrderStepDOD extends DataExtension
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			private static $db = array(
			0 ignored issues – show Unused Code introduced 2017-03-30 02:03 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12			'SendEmailToDistributor' => 'Boolean'
13			);
14
15			private static $has_many = array(
			0 ignored issues – show Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$has_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16			'EcommerceOrderStepCountryDatas' => 'EcommerceOrderStepCountryData',
17			);
18
19			private static $field_labels = array(
			0 ignored issues – show Unused Code introduced 2017-03-30 02:03 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			'EcommerceOrderStepCountryDatas' => 'Regionalisation',
21			);
22
23			/**
24			* Update Fields
25			* @return FieldList
			0 ignored issues – show Documentation introduced 2017-03-30 02:03 UTC by Report Bug Copy Issue Report Should the return type not be `FieldList\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
26			*/
27			public function updateCMSFields(FieldList $fields)
28			{
29			$owner = $this->owner;
			0 ignored issues – show Unused Code introduced 2017-03-30 02:03 UTC by Report Bug Copy Issue Report `$owner` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
30			$bccExplanation = _t(
31			'CountryPrice_OrderStepDOD.BCC_EXPLANATION',
32			'
33			E-mails during this step (if any) will be copied to distributor?
34			<br />These emails can be customised.
35			');
36
37			$gridField = $fields->dataFieldByName('EcommerceOrderStepCountryDatas');
38			$fields->removeFieldFromTab(
39			'Root.EcommerceOrderStepCountryDatas',
40			'EcommerceOrderStepCountryDatas'
41			);
42			$fields->addFieldsToTab(
43			'Root.EcommerceOrderStepCountryDatas',
44			array(
45			CheckboxField::create(
46			'SendEmailToDistributor',
47			_t('CountryPrice_OrderStepDOD.SEND_EMAIL_TO_DISTRIBUTOR', 'BCC to Distributor')
48			)->setDescription(
49			$bccExplanation
50			),
51			)
52			);
53			if($this->owner->SendEmailToDistributor) {
54			$customisation = _t(
55			'CountryPrice_OrderStepDOD.CUSTOMISATION_PER_COUNTRY',
56			'Customisation per country');
57			$gridField->setTitle($customisation);
58			$fields->addFieldsToTab(
59			'Root.EcommerceOrderStepCountryDatas',
60			$gridField
			0 ignored issues – show Documentation introduced 2017-03-30 02:03 UTC by Report Bug Copy Issue Report `$gridField` is of type `object<FormField>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			);
62			}
63
64			}
65
66			}
67

sunnysideup / silverstripe-ecommerce_countries

Push — master ( 81fcb0...eef980 )

CountryPrice_OrderStepDOD::updateCMSFields() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like