CountryPrice_Translation - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_countries - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cf3ebf...13bedb )

unknown

created 2017-03-30 04:14 UTC

CountryPrice_Translation B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	284
Duplicated Lines	6.34 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes

Metric	Value
wmc	34
lcom	1
cbo	16
dl	18
loc	284
rs	7.7846
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	get_country_url_provider()	0	5	1
B	getCMSFields()	0	52	5
A	canCreate()	0	7	2
B	validate()	0	22	4
B	FieldsToReplace()	0	28	3
A	Link()	0	4	1
A	getLink()	0	14	3
C	requireDefaultRecords()	18	51	13

How to fix Duplicated Code

<?php



class CountryPrice_Translation extends DataObject
namespace YourVendor;

class YourClass { }
{

    private static $automatically_create_dummy_translations_for_products_and_productgroups = true;


    private static $dependencies = array(

        'CountryURLProvider' => '%$CountryURLProvider',
    );

    /**
     * automatically populated by the dependency manager.
     *
     * @var CountryURLProvider
     */
    public $CountryURLProvider = null;

    private static $db = array(

        'Title' => 'Varchar(200)',
        'UseOriginalTitle' => 'Boolean',
        'Content' => 'HTMLText',
        'UseOriginalContent' => 'Boolean',
        'WithoutTranslation' => 'Boolean'
    );

    private static $field_labels = array(

        'Title' => 'Page Title',
        'Content' => 'Page Content',
        'EcommerceCountryID' => 'Country',
        'WithoutTranslation' => 'Price Difference Only'
    );

    private static $has_one = array(

        'EcommerceCountry' => 'EcommerceCountry',
        'Parent' => 'SiteTree'
    );

    private static $summary_fields = array(

        'EcommerceCountry.Name' => 'Country',
        'Title' => 'Title',
        'WithoutTranslation.Nice' => 'Price Difference Only'
    );

    private static $casting = array(

        'Link' => 'Varchar'
    );

    /**
     * @var string
     */
    private static $locale_get_parameter = 'ecomlocale';


    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $singular_name = 'Translation';

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $plural_name = 'Translations';

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    public static function get_country_url_provider()

    {
        $obj = Injector::inst()->get('CountryPrice_Translation');
        return $obj->CountryURLProvider;
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $withoutTranslationField = $fields->dataFieldByName('WithoutTranslation');
        $withoutTranslationField = CheckboxField::create(
            'WithoutTranslation',
            $withoutTranslationField->Title()
        )
        ->setDescription('The page is <em>translated</em> for search engines because it has prices for this country. ');

        $countries = CountryPrice_EcommerceCountry::get_real_countries_list()->map()->toArray();
        $countryDropdownField = DropdownField::create(
            'EcommerceCountryID',
            $fields->dataFieldByName('EcommerceCountryID')->Title(),
            array('' => '-- make sure to select a country --')+$countries
        );

        $fields->removeFieldFromTab("Root.Main", 'ParentID');
        if($this->WithoutTranslation) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return FieldList::create(
                array(
                    $countryDropdownField,
                    $withoutTranslationField
                )
            );
        } else {
            $fields->addFieldToTab(
                'Root.Main',
                $countryDropdownField,
                'Title'
            );
            $fields->addFieldToTab(
                'Root.Main',
                $withoutTranslationField,
                'Title'
            );
        }
        $dbFields = $this->inheritedDatabaseFields();
        foreach($dbFields as $dbField => $fieldType) {
            $useField = 'UseOriginal'.$dbField;
            if(!empty($this->$useField)) {
                $fields->replaceField(
                    $dbField,
                    $fields->dataFieldByName($dbField)->performReadonlyTransformation()
                );
            }
            if($fields->dataFieldByName($useField)){
                $fields->dataFieldByName($useField)->setDescription(_t('CountryPrice_Translation.IGNORE', 'Use original value for ') . $dbField);
            }
        }
        return $fields;
    }

    public function canCreate($member = null)
    {
        if (CountryPrice_EcommerceCountry::get_real_countries_list()->count()) {
            return parent::canCreate($member);
        }
        return false;
    }

    /**
     * {@inheritdoc}
     */
    protected function validate()
    {
        $validation = parent::validate();
        if ($validation->valid()) {
            if ($this->exists()) {
                $existing = CountryPrice_Translation::get()
                    ->exclude(array("ID" => $this->ID))
                    ->filter(
                        array(
                            "EcommerceCountryID" => $this->EcommerceCountryID,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            "ParentID" => $this->ParentID
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        )
                    );
                if ($existing->count() > 0) {
                    $validation->error(
                        'There is already an entry for this country and page'
                    );
                }
            }
        }
        return $validation;
    }

    /**
     *     'PageField' => 'Title'
     *     'TranslationField' => 'Title'
     *
     * @return ArrayList
     */
    public function FieldsToReplace()
    {
        $al = ArrayList::create();
        $al->push(
            ArrayData::create(
                array(
                    'PageField' => 'Title',
                    'TranslationField' => 'Title'
                )
            )
        );
        $al->push(
            ArrayData::create(
                array(
                    'PageField' => 'Content',
                    'TranslationField' => 'Content'
                )
            )
        );
        $this->extend('updateFieldsToReplace', $al);
        foreach($al as $fieldToReplace) {
            $ignoreField = 'UseOriginal' . $fieldToReplace->PageField;
            if(!empty($this->owner->$ignoreField)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $al->remove($fieldToReplace);
            }
        }
        return $al;
    }

    /**
     * @return string

     */
    public function Link()
    {
        return $this->getLink();
    }

    /**
     * @return string

     */
    public function getLink()
    {
        $link = $this->Parent()->Link();

        if ($this->EcommerceCountryID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $hasCountrySegment = CountryPrice_Translation::get_country_url_provider()->hasCountrySegment($link);
            if($hasCountrySegment){
                $link = CountryPrice_Translation::get_country_url_provider()->replaceCountryCodeInUrl($this->EcommerceCountry()->Code, $link);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }
            else {
                $link = CountryPrice_Translation::get_country_url_provider()->addCountryCodeToUrl($this->EcommerceCountry()->Code, $link);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }
        }
        return Director::absoluteURL($link);
    }

    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        if(Config::inst()->get('CountryPrice_Translation', 'automatically_create_dummy_translations_for_products_and_productgroups')) {
            $prices = CountryPrice::get();
            $ecommerceCountries = array();
            foreach($prices as $price) {
                if($countryObject = $price->CountryObject()) {
                    if($buyable = $price->Buyable()) {
                        if($buyable instanceof Product) {
                            if($buyable->ID && $countryObject->ID) {
                                $filter = array(
                                    'EcommerceCountryID' => $countryObject->ID,
                                    'ParentID' => $buyable->ID
                                );
                                $ecommerceCountries[$countryObject->ID] = $countryObject;
                                if(! CountryPrice_Translation::get()->filter($filter)->first()) {

                                    DB::alteration_message(
                                        'Creating fake translation for '.$buyable->Title.' for country '.$countryObject->Code,
                                        'created'
                                    );
                                    $obj = CountryPrice_Translation::create($filter);
                                    $obj->WithoutTranslation = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                    $obj->write();
                                }
                            }
                        }
                    }
                }
            }
            if(count($ecommerceCountries)) {
                foreach(ProductGroup::get() as $productGroup) {
                    foreach($ecommerceCountries as $countryID => $countryObject) {
                        $filter = array(
                            'EcommerceCountryID' => $countryObject->ID,
                            'ParentID' => $productGroup->ID
                        );
                        if(! CountryPrice_Translation::get()->filter($filter)->first()) {

                            DB::alteration_message(
                                'Creating fake translation for '.$productGroup->Title.' for country '.$countryObject->Code,
                                'created'
                            );
                            $obj = CountryPrice_Translation::create($filter);
                            $obj->WithoutTranslation = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $obj->write();
                        }
                    }
                }
            }
        }
    }

}


1			<?php
2
3
4
5			class CountryPrice_Translation extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7
8			private static $automatically_create_dummy_translations_for_products_and_productgroups = true;
			0 ignored issues – show Unused Code introduced 2017-01-27 02:23 UTC by Report Bug Copy Issue Report The property `$automatically_create_du...ducts_and_productgroups` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9
10			private static $dependencies = array(
			0 ignored issues – show Unused Code introduced 2017-03-30 04:17 UTC by Report Bug Copy Issue Report The property `$dependencies` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11			'CountryURLProvider' => '%$CountryURLProvider',
12			);
13
14			/**
15			* automatically populated by the dependency manager.
16			*
17			* @var CountryURLProvider
18			*/
19			public $CountryURLProvider = null;
20
21			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22			'Title' => 'Varchar(200)',
23			'UseOriginalTitle' => 'Boolean',
24			'Content' => 'HTMLText',
25			'UseOriginalContent' => 'Boolean',
26			'WithoutTranslation' => 'Boolean'
27			);
28
29			private static $field_labels = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
30			'Title' => 'Page Title',
31			'Content' => 'Page Content',
32			'EcommerceCountryID' => 'Country',
33			'WithoutTranslation' => 'Price Difference Only'
34			);
35

sunnysideup / silverstripe-ecommerce_countries

Push — master ( cf3ebf...13bedb )

CountryPrice_Translation B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like