CountryPrice_Translation::canEdit() - Code Metrics - Inspection of "MINOR: improved ways to deal with non-translation..." - sunnysideup/silverstripe-ecommerce_countries - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00b45d...3dd24a )

by Nicolaas

created 2017-01-27 02:21 UTC

CountryPrice_Translation::canEdit() A

↳ Parent: CountryPrice_Translation

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
eloc	2
nc	2
nop	1

<?php



class CountryPrice_Translation extends DataObject
namespace YourVendor;

class YourClass { }
{

    private static $automatically_create_dummy_translations_for_products_and_productgroups = true;


    private static $db = array(

        'Title' => 'Varchar(200)',
        'Content' => 'HTMLText',
        'WithoutTranslation' => 'Boolean'
    );

    private static $field_labels = array(

        'Title' => 'Page Title',
        'Content' => 'Page Content',
        'EcommerceCountryID' => 'Country',
        'WithoutTranslation' => 'Price Difference Only'
    );

    private static $has_one = array(

        'EcommerceCountry' => 'EcommerceCountry',
        'Parent' => 'SiteTree'
    );

    private static $summary_fields = array(

        'EcommerceCountry.Name' => 'Country',
        'Title' => 'Title',
        'WithoutTranslation.Nice' => 'Price Difference Only'
    );

    private static $casting = array(

        'Link' => 'Varchar'
    );

    /**
     * @var string
     */
    private static $locale_get_parameter = 'ecomlocale';


    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $singular_name = 'Translation';

    public function i18n_singular_name()
    {
        return self::$singular_name;
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $plural_name = 'Translations';

    public function i18n_plural_name()
    {
        return self::$plural_name;
    }

    /**
     * CMS Fields
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $countries = CountryPrice_EcommerceCountry::get_real_countries_list()->map()->toArray();
        $fields->addFieldToTab(
            'Root.Main',
            DropdownField::create(
                'EcommerceCountryID',
                $fields->dataFieldByName('EcommerceCountryID')->Title(),
                array('' => '-- make sure to select a country --')+$countries
            ),
            'Title'
        );
        $withoutTranslationField = $fields->dataFieldByName('WithoutTranslation');
        $fields->addFieldToTab(
            'Root.Main',
            CheckboxField::create(
                'WithoutTranslation',
                $withoutTranslationField->Title()
            )->setDescription('The page is <em>translated</em> for search engines because it has prices for this country. '),
            'Title'
        );
        $fields->removeFieldFromTab("Root.Main", 'ParentID');
        return $fields;
    }

    public function canCreate($member = null)
    {
        if (CountryPrice_EcommerceCountry::get_real_countries_list()->count()) {
            return parent::canCreate($member);
        }
        return false;
    }

    public function canEdit($member = null)
    {
        return $this->WithoutTranslation ? false : parent::canEdit($member);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * {@inheritdoc}
     */
    protected function validate()
    {
        $validation = parent::validate();
        if ($validation->valid()) {
            if ($this->exists()) {
                $existing = CountryPrice_Translation::get()
                    ->exclude(array("ID" => $this->ID))
                    ->filter(
                        array(
                            "EcommerceCountryID" => $this->EcommerceCountryID,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            "ParentID" => $this->ParentID
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        )
                    );
                if ($existing->count() > 0) {
                    $validation->error(
                        'There is already an entry for this country and page'
                    );
                }
            }
        }
        return $validation;
    }

    /**
     *     'PageField' => 'Title'
     *     'TranslationField' => 'Title'
     *
     * @return ArrayList
     */
    public function FieldsToReplace()
    {
        $al = ArrayList::create();
        $al->push(
            ArrayData::create(
                array(
                    'PageField' => 'Title',
                    'TranslationField' => 'Title'
                )
            )
        );
        $al->push(
            ArrayData::create(
                array(
                    'PageField' => 'Content',
                    'TranslationField' => 'Content'
                )
            )
        );
        $this->extend('updateFieldsToReplace', $al);
        return $al;
    }

    /**
     * @return string

     */
    public function Link()
    {
        return $this->getLink();
    }

    /**
     * @return string

     */
    public function getLink()
    {
        $link = $this->Parent()->Link();

        if ($this->EcommerceCountryID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $link .= '?'.$this->Config()->get('locale_get_parameter').'='.$this->EcommerceCountry()->Code;
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        return Director::absoluteURL($link);
    }

    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        if(Config::inst()->get('CountryPrice_Translation', 'automatically_create_dummy_translations_for_products_and_productgroups')) {
            $prices = CountryPrice::get();
            $ecommerceCountries = array();
            foreach($prices as $price) {
                if($countryObject = $price->CountryObject()) {
                    if($buyable = $price->Buyable()) {
                        if($buyable instanceof Product) {
                            $filter = array(
                                'EcommerceCountryID' => $countryObject->ID,
                                'ParentID' => $buyable->ID
                            );
                            $ecommerceCountries[$countryObject->ID] = $countryObject;
                            if(! CountryPrice_Translation::get()->filter($filter)->first()) {

                                DB::alteration_message(
                                    'Creating fake translation for '.$buyable->Title.' for country '.$countryObject->Code,
                                    'created'
                                );
                                $obj = CountryPrice_Translation::create($filter);
                                $obj->WithoutTranslation = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->write();
                            }
                        }
                    }
                }
            }
            if(count($ecommerceCountries)) {
                foreach(ProductGroup::get() as $productGroup) {
                    foreach($ecommerceCountries as $countryID => $countryObject) {
                        $filter = array(
                            'EcommerceCountryID' => $countryObject->ID,
                            'ParentID' => $productGroup->ID
                        );
                        if(! CountryPrice_Translation::get()->filter($filter)->first()) {

                            DB::alteration_message(
                                'Creating fake translation for '.$productGroup->Title.' for country '.$countryObject->Code,
                                'created'
                            );
                            $obj = CountryPrice_Translation::create($filter);
                            $obj->WithoutTranslation = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $obj->write();
                        }
                    }
                }
            }
        }
    }

}


1			<?php
2
3
4
5			class CountryPrice_Translation extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7
8			private static $automatically_create_dummy_translations_for_products_and_productgroups = true;
			0 ignored issues – show Unused Code introduced 2017-01-27 02:23 UTC by Report Bug Copy Issue Report The property `$automatically_create_du...ducts_and_productgroups` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9
10			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11			'Title' => 'Varchar(200)',
12			'Content' => 'HTMLText',
13			'WithoutTranslation' => 'Boolean'
14			);
15
16			private static $field_labels = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17			'Title' => 'Page Title',
18			'Content' => 'Page Content',
19			'EcommerceCountryID' => 'Country',
20			'WithoutTranslation' => 'Price Difference Only'
21			);
22
23			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
24			'EcommerceCountry' => 'EcommerceCountry',
25			'Parent' => 'SiteTree'
26			);
27
28			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
29			'EcommerceCountry.Name' => 'Country',
30			'Title' => 'Title',
31			'WithoutTranslation.Nice' => 'Price Difference Only'
32			);
33
34			private static $casting = array(

sunnysideup / silverstripe-ecommerce_countries

Push — master ( 00b45d...3dd24a )

CountryPrice_Translation::canEdit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like