CountryPrice_Page_Controller_Extension::addCountryCodeToUrlIfRequired() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce_countries - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 82e94b...bd5823 )

by Nicolaas

created 2018-01-31 01:14 UTC

addCountryCodeToUrlIfRequired() B

↳ Parent: CountryPrice_Page_Controller_Extension

Complexity

Conditions	7
Paths	9

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	7.551
c	0
b	0
f	0
cc	7
eloc	14
nc	9
nop	1

<?php


/**
 * www.mysite.com/mypage/?ecomlocale=AU
 * if there is a tranlsation page redirects to
 * URL with ?ecomlocale=AU
 *
 * if you go to a URL with ?ecomlocale=AU and the shop country does not match
 * the get param then you get redirected to that shop country.
 *
 *
 */

class CountryPrice_Page_Controller_Extension extends Extension
namespace YourVendor;

class YourClass { }
{

    /**
     * replaces `Title` and `Content` with translated content
     * where available.
     *
     * If the country code in the get parameter is not correct then
     * @return [type] [description]

     */
    public function onAfterInit()
    {
        $countryID = 0;
        //provided by stealth ...
        $countryObject = CountryPrice_EcommerceCountry::get_real_country();

        if ($countryObject) {

            //check if a redirect is required ...
            $this->checkForOffsiteRedirects($countryObject);

            $countryID = $countryObject->ID;
            //check that there is a translation
            if ($this->owner->dataRecord->thisPageHasTranslation($countryID)) {
                //if there is a translation but it is not showing in the URL then redirect
                $newURL = $this->addCountryCodeToUrlIfRequired($countryObject->Code);
                if ($newURL) {
                    $this->owner->redirect($newURL);
                }
            }
        }

        $this->owner->dataRecord->loadTranslatedValues($countryID, null);
    }

    /**
     * returns the best fieldname for
     * @param string $fieldName [description]
     */
    public function CountryDistributorBestContentValue($fieldName)

    {
        $countryObject = CountryPrice_EcommerceCountry::get_real_country();

        //check country
        if (!empty($countryObject->$fieldName)) {
            return $countryObject->$fieldName;
        }

        //check distributor
        $distributor = Distributor::get_one_for_country($countryObject->Code);
        if (!empty($distributor->$fieldName)) {
            return $distributor->$fieldName;
        }
        //check EcomConfig
        $distributor = Distributor::get_one_for_country($countryObject->Code);
        if (!empty($distributor->$fieldName)) {
            return $distributor->$fieldName;
        }
    }

    /**
     * caching variable
     *
     * @var integer
     */
    private static $_redirection_count = 0;

    /**
     * returns a string for the new url if a locale parameter can be added
     *
     * @return string | null
     */
    private function addCountryCodeToUrlIfRequired($countryCode = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_POST) && count($_POST)) {
            return null;
        }
        //to do: add query here!
        $protocol = Director::is_https() ? 'https://' : 'http://';
        $oldURL = $protocol.$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI'];

        $hasCountrySegment = CountryPrice_Translation::get_country_url_provider()->hasCountrySegment($oldURL);
        if ($hasCountrySegment) {
            $newURL = CountryPrice_Translation::get_country_url_provider()->replaceCountryCodeInUrl($countryCode, $oldURL);
        } else {
            $newURL = CountryPrice_Translation::get_country_url_provider()->addCountryCodeToUrl($countryCode, $oldURL);
        }
        if ($oldURL !== $newURL && self::$_redirection_count < 3) {
            self::$_redirection_count++;
            return $newURL;
        }
        return null;
    }


    /**
     *
     *
     * @return ArrayList
     */
    public function ChooseNewCountryList()
    {
        $countries = CountryPrice_EcommerceCountry::get_real_countries_list();
        $currentCode = '';
        if ($obj = CountryPrice_EcommerceCountry::get_real_country()) {
            $currentCode = $obj->Code;
        }
        $al = ArrayList::create();
        foreach ($countries as $country) {
            $isCurrentOne = $currentCode == $country->Code ? true : false;
            $currency = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $currency = CountryPrice_EcommerceCurrency::get_currency_for_country($country->Code);
            $currencyCode = CountryPrice_EcommerceCurrency::get_currency_for_country($country->Code);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $al->push(
                ArrayData::create(
                    array(
                        'Link' => CountryPrices_ChangeCountryController::new_country_link($country->Code),
                        'Title' => $country->Name,
                        'CountryCode' => $country->Code,
                        'LinkingMode' => ($isCurrentOne ? 'current' : 'link'),
                        'Currency' => $currency,
                        'CurrencyCode' => $currency
                    )
                )
            );
        }
        return $al;
    }

    /**
     *
     * @return DataList

     */
    public function AlternativeHrefLangLinksCachingKey()
    {
        $countryObject = CountryPrice_EcommerceCountry::get_real_country();
        if ($countryObject && $countryObject->Code) {
            return 'AlternativeHrefLangLinksCachingKey-'.$countryObject->Code.'-'.$this->owner->dataRecord->ID.'-'.strtotime($this->owner->dataRecord->LastEdited);
        }
        return 'AlternativeHrefLangLinksCachingKey'.$this->owner->dataRecord->ID.'-'.$this->owner->dataRecord->ID.'-'.strtotime($this->owner->dataRecord->LastEdited);
    }

    /**
     *
     * @param string $link - passed by reference
     */
    public function UpdateCanonicalLink(&$link)

    {
        $obj = $this->owner->dataRecord->CanonicalObject();
        if ($obj) {
            $link = $obj->Link();
        } else {
            $link = $this->owner->dataRecord->AbsoluteLink();
        }
        return $link;
    }

    /**
     * redirects visitors to another website if they are listed as such in
     * CountryPrices_ChangeCountryController.off_site_url_redirects
     *
     * @param  EcommerceCountry $countryObject current country of visitor
     *
     * @return null|SS_HTTPResponse
     */
    protected function checkForOffsiteRedirects($countryObject)
    {
        $redirectsArray = Config::inst()->get('CountryPrices_ChangeCountryController', 'off_site_url_redirects');
        $myCountryCode = strtoupper($countryObject->Code);
        if (isset($redirectsArray[$myCountryCode])) {
            return $this->redirect($redirectsArray[$myCountryCode]);

        }
    }
}


1			<?php
2
3
4			/**
5			* www.mysite.com/mypage/?ecomlocale=AU
6			* if there is a tranlsation page redirects to
7			* URL with ?ecomlocale=AU
8			*
9			* if you go to a URL with ?ecomlocale=AU and the shop country does not match
10			* the get param then you get redirected to that shop country.
11			*
12			*
13			*/
14
15			class CountryPrice_Page_Controller_Extension extends Extension
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
16			{
17
18			/**
19			* replaces `Title` and `Content` with translated content
20			* where available.
21			*
22			* If the country code in the get parameter is not correct then
23			* @return [type] [description]
			0 ignored issues – show Documentation introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
24			*/
25			public function onAfterInit()
26			{
27			$countryID = 0;
28			//provided by stealth ...
29			$countryObject = CountryPrice_EcommerceCountry::get_real_country();
30
31			if ($countryObject) {
32
33			//check if a redirect is required ...
34			$this->checkForOffsiteRedirects($countryObject);
35
36			$countryID = $countryObject->ID;
37			//check that there is a translation
38			if ($this->owner->dataRecord->thisPageHasTranslation($countryID)) {
39			//if there is a translation but it is not showing in the URL then redirect
40			$newURL = $this->addCountryCodeToUrlIfRequired($countryObject->Code);
41			if ($newURL) {
42			$this->owner->redirect($newURL);
43			}
44			}
45			}
46
47			$this->owner->dataRecord->loadTranslatedValues($countryID, null);
48			}
49
50			/**
51			* returns the best fieldname for
52			* @param string $fieldName [description]
53			*/
54			public function CountryDistributorBestContentValue($fieldName)
			0 ignored issues – show Documentation introduced 2017-10-18 01:15 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
55			{
56			$countryObject = CountryPrice_EcommerceCountry::get_real_country();
57
58			//check country
59			if (!empty($countryObject->$fieldName)) {
60			return $countryObject->$fieldName;
61			}
62
63			//check distributor
64			$distributor = Distributor::get_one_for_country($countryObject->Code);
65			if (!empty($distributor->$fieldName)) {
66			return $distributor->$fieldName;
67			}
68			//check EcomConfig
69			$distributor = Distributor::get_one_for_country($countryObject->Code);
70			if (!empty($distributor->$fieldName)) {
71			return $distributor->$fieldName;
72			}
73			}
74
75			/**
76			* caching variable
77			*
78			* @var integer
79			*/
80			private static $_redirection_count = 0;
81
82			/**
83			* returns a string for the new url if a locale parameter can be added
84			*
85			* @return string \| null
86			*/
87			private function addCountryCodeToUrlIfRequired($countryCode = '')
			0 ignored issues – show Coding Style introduced 2017-10-18 01:15 UTC by Report Bug Copy Issue Report `addCountryCodeToUrlIfRequired` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-10-18 01:15 UTC by Report Bug Copy Issue Report `addCountryCodeToUrlIfRequired` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
88			{
89			if (isset($_POST) && count($_POST)) {
90			return null;
91			}
92			//to do: add query here!
93			$protocol = Director::is_https() ? 'https://' : 'http://';
94			$oldURL = $protocol.$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI'];
95
96			$hasCountrySegment = CountryPrice_Translation::get_country_url_provider()->hasCountrySegment($oldURL);
97			if ($hasCountrySegment) {
98			$newURL = CountryPrice_Translation::get_country_url_provider()->replaceCountryCodeInUrl($countryCode, $oldURL);
99			} else {
100			$newURL = CountryPrice_Translation::get_country_url_provider()->addCountryCodeToUrl($countryCode, $oldURL);
101			}
102			if ($oldURL !== $newURL && self::$_redirection_count < 3) {
103			self::$_redirection_count++;
104			return $newURL;
105			}
106			return null;
107			}
108
109
110			/**
111			*
112			*
113			* @return ArrayList
114			*/
115			public function ChooseNewCountryList()
116			{
117			$countries = CountryPrice_EcommerceCountry::get_real_countries_list();
118			$currentCode = '';
119			if ($obj = CountryPrice_EcommerceCountry::get_real_country()) {
120			$currentCode = $obj->Code;
121			}
122			$al = ArrayList::create();
123			foreach ($countries as $country) {
124			$isCurrentOne = $currentCode == $country->Code ? true : false;
125			$currency = null;
			0 ignored issues – show Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report `$currency` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
126			$currency = CountryPrice_EcommerceCurrency::get_currency_for_country($country->Code);
127			$currencyCode = CountryPrice_EcommerceCurrency::get_currency_for_country($country->Code);
			0 ignored issues – show Unused Code introduced 2016-10-31 22:45 UTC by Report Bug Copy Issue Report `$currencyCode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
128			$al->push(
129			ArrayData::create(
130			array(
131			'Link' => CountryPrices_ChangeCountryController::new_country_link($country->Code),
132			'Title' => $country->Name,
133			'CountryCode' => $country->Code,
134			'LinkingMode' => ($isCurrentOne ? 'current' : 'link'),
135			'Currency' => $currency,
136			'CurrencyCode' => $currency
137			)
138			)
139			);
140			}
141			return $al;
142			}
143
144			/**
145			*
146			* @return DataList
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Should the return type not be `string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
147			*/
148			public function AlternativeHrefLangLinksCachingKey()
149			{
150			$countryObject = CountryPrice_EcommerceCountry::get_real_country();
151			if ($countryObject && $countryObject->Code) {
152			return 'AlternativeHrefLangLinksCachingKey-'.$countryObject->Code.'-'.$this->owner->dataRecord->ID.'-'.strtotime($this->owner->dataRecord->LastEdited);
153			}
154			return 'AlternativeHrefLangLinksCachingKey'.$this->owner->dataRecord->ID.'-'.$this->owner->dataRecord->ID.'-'.strtotime($this->owner->dataRecord->LastEdited);
155			}
156
157			/**
158			*
159			* @param string $link - passed by reference
160			*/
161			public function UpdateCanonicalLink(&$link)
			0 ignored issues – show Documentation introduced 2017-10-18 01:15 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
162			{
163			$obj = $this->owner->dataRecord->CanonicalObject();
164			if ($obj) {
165			$link = $obj->Link();
166			} else {
167			$link = $this->owner->dataRecord->AbsoluteLink();
168			}
169			return $link;
170			}
171
172			/**
173			* redirects visitors to another website if they are listed as such in
174			* CountryPrices_ChangeCountryController.off_site_url_redirects
175			*
176			* @param EcommerceCountry $countryObject current country of visitor
177			*
178			* @return null\|SS_HTTPResponse
179			*/
180			protected function checkForOffsiteRedirects($countryObject)
181			{
182			$redirectsArray = Config::inst()->get('CountryPrices_ChangeCountryController', 'off_site_url_redirects');
183			$myCountryCode = strtoupper($countryObject->Code);
184			if (isset($redirectsArray[$myCountryCode])) {
185			return $this->redirect($redirectsArray[$myCountryCode]);
			0 ignored issues – show Bug introduced 2018-01-16 22:48 UTC by Report Bug Copy Issue Report The method `redirect()` does not exist on `CountryPrice_Page_Controller_Extension`. Did you maybe mean `checkForOffsiteRedirects()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
186			}
187			}
188			}
189

sunnysideup / silverstripe-ecommerce_countries

Push — master ( 82e94b...bd5823 )

addCountryCodeToUrlIfRequired() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like