+global\TEST_GEOIP_COUNTRY_CODE_BY_NAME::run()

Complexity

Conditions	6
Paths	4

Size

Total Lines

24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function run($request)
    {
        if (isset($_GET["ip"])) {
            $ar = array($_GET["ip"] => "user defined");
        } else {
            $ar = Config::inst()->get('TEST_GEOIP_COUNTRY_CODE_BY_NAME', 'test_ips');
        }
        if (count($ar)) {
            foreach ($ar as $ip => $description) {

The expression $ar of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

                $codeArray = Geoip::ip2country($ip);
                echo "<hr /><h2>$ip: ---".print_r($codeArray, 1)."---</h2>";
                if ($codeArray["code"] != $description && strlen($description) == 2) {
                    DB::alteration_message("ERROR - this should be: ".$description, "deleted");
                }
            }
        }
        echo "
            <hr />
            <p>
                You can also add your own IP address at the end of the URL
                - e.g. dev/tasks/TEST_GEOIP_COUNTRY_CODE_BY_NAME?ip=111.111.111.111
                to test a specific IP address
            </p>";
    }
}