CountryPrice_OrderStepDOD

Complexity

Total Complexity

1

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	36	1

<?php

/**
 * Adds individual country messages
 * for ordersteps
 *
 */

class CountryPrice_OrderStepDOD extends DataExtension
{
    private static $db = array(
        'SendEmailToDistributor' => 'Boolean'
    );

    private static $has_many = array(
        'EcommerceOrderStepCountryDatas' => 'EcommerceOrderStepCountryData',
    );

    private static $field_labels = array(
        'EcommerceOrderStepCountryDatas' => 'Regionalisation',
    );

    /**
     * Update Fields
     * @return FieldList

Should the return type not be FieldList|null?

     */
    public function updateCMSFields(FieldList $fields)
    {
        $owner = $this->owner;

$owner is not used, you could remove the assignment.

        $bccExplanation = _t(
            'CountryPrice_OrderStepDOD.BCC_EXPLANATION',
            '
                E-mails during this step (if any) will be copied to distributor?
                <br />These emails can be customised.
        '
        );
        $gridField = $fields->dataFieldByName('EcommerceOrderStepCountryDatas');
        $fields->removeFieldFromTab(
            'Root.EcommerceOrderStepCountryDatas',
            'EcommerceOrderStepCountryDatas'
        );
        $fields->addFieldsToTab(
            'Root.EcommerceOrderStepCountryDatas',
            array(
                CheckboxField::create(
                    'SendEmailToDistributor',
                    _t('CountryPrice_OrderStepDOD.SEND_EMAIL_TO_DISTRIBUTOR', 'BCC to Distributor')
                )->setDescription(
                    $bccExplanation
                ),
            )
        );
        $customisation = _t(
            'CountryPrice_OrderStepDOD.CUSTOMISATION_PER_COUNTRY',
            'Customisation per country'
        );
        $gridField->setTitle($customisation);
        $fields->addFieldsToTab(
            'Root.EcommerceOrderStepCountryDatas',
            $gridField

$gridField is of type object<FormField>, but the function expects a array.

        );
    }
}