EcommerceCountry_VisitorCountryProviderCloudFlare

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCountry()	0	7	2
A	getIP()	0	7	2

<?php

/**
 * this is a very basic class with as its sole purpose providing
 * the country of the customer.
 *
 *
 */
class EcommerceCountry_VisitorCountryProviderCloudFlare extends Object implements EcommerceGEOipProvider

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     *
     * @var string
     */
    private static $forced_country_code = "";

The property $forced_country_code is not used and could be removed.

    /**
     *
     * @var string
     */
    private static $forced_ip_address = "";

The property $forced_ip_address is not used and could be removed.

    /**
     *
     * @return String (Country Code - e.g. NZ, AU, or AF)

Should the return type not be array|integer|double|string|boolean?

     */
    public function getCountry()
    {
        if ($code = Config::inst()->get("EcommerceCountry_VisitorCountryProviderCloudFlare", "forced_country_code")) {
            return $code;
        }
        return CloudFlareGeoip::visitor_country();
    }

    /**
     *
     *
     * @return string

Should the return type not be array|integer|double|string|boolean?

     */
    public function getIP()
    {
        if ($ip = Config::inst()->get("EcommerceCountry_VisitorCountryProviderCloudFlare", "forced_ip_address")) {
            return $ip;
        }
        return CloudFlareGeoip::get_remote_address();
    }
}